[Bug fortran/103715] New: [12 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301

[Bug fortran/103715] New: [12 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

            Bug ID: 103715
           Summary: [12 Regression] ICE in gfc_find_gsymbol, at
                    fortran/symbol.c:4301
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20210905 and 20210919 :
(gcc configured with --enable-checking=yes)


$ cat z1.f90
program p
   select type (y => g())
   end select
   call g()
end


$ gfortran-12-20211212 -c z1.f90 -g -fcoarray=lib
z1.f90:2:25:

    2 |    select type (y => g())
      |                         1
Error: Selector shall be polymorphic in SELECT TYPE statement at (1)
z1.f90:4:11:

    2 |    select type (y => g())
      |                     2
    3 |    end select
    4 |    call g()
      |           1
Error: Global name 'g' at (1) is already being used as a FUNCTION at (2)
f951: internal compiler error: Segmentation fault
0xf12d1f crash_signal
        ../../gcc/toplev.c:322
0x879ee4 gfc_find_gsymbol(gfc_gsymbol*, char const*)
        ../../gcc/fortran/symbol.c:4301
0x950bd1 check_externals_procedure
        ../../gcc/fortran/frontend-passes.c:5720
0x953885 gfc_expr_walker(gfc_expr**, int (*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5227
0x955a09 gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*, void*), int
(*)(gfc_expr**, int*, void*), void*)
        ../../gcc/fortran/frontend-passes.c:5666
0x95716b gfc_check_externals0
        ../../gcc/fortran/frontend-passes.c:5848
0x958044 gfc_check_externals(gfc_namespace*)
        ../../gcc/fortran/frontend-passes.c:5870
0x83fa02 gfc_parse_file()
        ../../gcc/fortran/parse.c:6869
0x88db0f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

[Bug fortran/103715] [9/10/11/12 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |pault at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-12-15
            Summary|[12 Regression] ICE in      |[9/10/11/12 Regression] ICE
                   |gfc_find_gsymbol, at        |in gfc_find_gsymbol, at
                   |fortran/symbol.c:4301       |fortran/symbol.c:4301 since
                   |                            |r9-3803-ga5fbc2f36a291cbe

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r9-3803-ga5fbc2f36a291cbe.
One can see valgrind Invalid read errors.

[Bug fortran/103715] [9/10/11/12 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |9.5

[Bug fortran/103715] [10/11/12/13 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug fortran/103715] [10/11/12/13 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug fortran/103715] [11/12/13/14 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.

[Bug fortran/103715] [11/12/13/14 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #5 from anlauf at gcc dot gnu.org ---
Obvious fix for the invalid read (untested):

diff --git a/gcc/fortran/frontend-passes.cc b/gcc/fortran/frontend-passes.cc
index 06dfa1a3232..3c06018fdbb 100644
--- a/gcc/fortran/frontend-passes.cc
+++ b/gcc/fortran/frontend-passes.cc
@@ -5807,6 +5807,9 @@ check_externals_expr (gfc_expr **ep, int *walk_subtrees
ATTRIBUTE_UNUSED,
   if (e->expr_type != EXPR_FUNCTION)
     return 0;

+  if (e->symtree && e->symtree->n.sym->attr.subroutine)
+    return 0;
+
   sym = e->value.function.esym;
   if (sym == NULL)
     return 0;

[Bug fortran/103715] [11/12/13/14 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jvdelisle at gcc dot gnu.org

--- Comment #6 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
(In reply to anlauf from comment #5)
> Obvious fix for the invalid read (untested):
> 
If it test OK feel free to commit.

[Bug fortran/103715] [11/12/13/14 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

--- Comment #7 from anlauf at gcc dot gnu.org ---
(In reply to Jerry DeLisle from comment #6)
> (In reply to anlauf from comment #5)
> > Obvious fix for the invalid read (untested):
> > 
> If it test OK feel free to commit.

Unsurprisingly it regtests fine  :-)

Will commit soon.

[Bug fortran/103715] [11/12/13/14 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:3be2b8f475f22c531d6cef1b041c0573b3ea5133

commit r14-9522-g3be2b8f475f22c531d6cef1b041c0573b3ea5133
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Mar 18 19:36:59 2024 +0100

    Fortran: error recovery in frontend optimization [PR103715]

    gcc/fortran/ChangeLog:

            PR fortran/103715
            * frontend-passes.cc (check_externals_expr): Prevent invalid read
            in case of mismatch of external subroutine with function.

    gcc/testsuite/ChangeLog:

            PR fortran/103715
            * gfortran.dg/pr103715.f90: New test.

[Bug fortran/103715] [11/12/13/14 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:9623e5dd70b0d8334ebe093459721d0d447ce4f2

commit r13-8467-g9623e5dd70b0d8334ebe093459721d0d447ce4f2
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Mar 18 19:36:59 2024 +0100

    Fortran: error recovery in frontend optimization [PR103715]

    gcc/fortran/ChangeLog:

            PR fortran/103715
            * frontend-passes.cc (check_externals_expr): Prevent invalid read
            in case of mismatch of external subroutine with function.

    gcc/testsuite/ChangeLog:

            PR fortran/103715
            * gfortran.dg/pr103715.f90: New test.

    (cherry picked from commit 3be2b8f475f22c531d6cef1b041c0573b3ea5133)

[Bug fortran/103715] [11/12/13/14 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:811145b10ff30608bb5ea459ea277219ada4f13d

commit r12-10286-g811145b10ff30608bb5ea459ea277219ada4f13d
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Mar 18 19:36:59 2024 +0100

    Fortran: error recovery in frontend optimization [PR103715]

    gcc/fortran/ChangeLog:

            PR fortran/103715
            * frontend-passes.cc (check_externals_expr): Prevent invalid read
            in case of mismatch of external subroutine with function.

    gcc/testsuite/ChangeLog:

            PR fortran/103715
            * gfortran.dg/pr103715.f90: New test.

    (cherry picked from commit 3be2b8f475f22c531d6cef1b041c0573b3ea5133)

[Bug fortran/103715] [11/12/13/14 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:7294f1a7aa457fe24d11270f06fd15c2b3ffd4ab

commit r11-11287-g7294f1a7aa457fe24d11270f06fd15c2b3ffd4ab
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Mar 18 19:36:59 2024 +0100

    Fortran: error recovery in frontend optimization [PR103715]

    gcc/fortran/ChangeLog:

            PR fortran/103715
            * frontend-passes.c (check_externals_expr): Prevent invalid read
            in case of mismatch of external subroutine with function.

    gcc/testsuite/ChangeLog:

            PR fortran/103715
            * gfortran.dg/pr103715.f90: New test.

    (cherry picked from commit 3be2b8f475f22c531d6cef1b041c0573b3ea5133)

[Bug fortran/103715] [11/12/13/14 Regression] ICE in gfc_find_gsymbol, at fortran/symbol.c:4301 since r9-3803-ga5fbc2f36a291cbe

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103715

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-14, and backported to open branches.  Closing.