[Bug fortran/103796] New: ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446

[Bug fortran/103796] New: ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

            Bug ID: 103796
           Summary: ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started with r8 :


$ cat z1.f90
program p
   form team ('a', team)
end


$ cat z2.f90
program p
   form team (1, team)
end


$ gfortran-12-20211219 -c z1.f90 -fcoarray=single
$
$ gfortran-12-20211219 -c z1.f90 -fcoarray=lib
z1.f90:2:24:

    2 |    form team ('a', team)
      |                        1
internal compiler error: in gfc_conv_expr_val, at fortran/trans-expr.c:9446
0x888132 gfc_conv_expr_val(gfc_se*, gfc_expr*)
        ../../gcc/fortran/trans-expr.c:9446
0x8ce5bd gfc_trans_form_team(gfc_code*)
        ../../gcc/fortran/trans-stmt.c:744
0x854747 trans_code
        ../../gcc/fortran/trans.c:2068
0x87d6be gfc_generate_function_code(gfc_namespace*)
        ../../gcc/fortran/trans-decl.c:7644
0x80063e translate_all_program_units
        ../../gcc/fortran/parse.c:6651
0x80063e gfc_parse_file()
        ../../gcc/fortran/parse.c:6938
0x84d53f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

[Bug fortran/103796] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446 since r8-6395-gf8862a1b2afad9d1

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |damian at sourceryinstitute dot or
                   |                            |g, marxin at gcc dot gnu.org
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-12-22
            Summary|ICE in gfc_conv_expr_val,   |ICE in gfc_conv_expr_val,
                   |at                          |at
                   |fortran/trans-expr.c:9446   |fortran/trans-expr.c:9446
                   |                            |since
                   |                            |r8-6395-gf8862a1b2afad9d1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r8-6395-gf8862a1b2afad9d1.

[Bug fortran/103796] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446 since r8-6395-gf8862a1b2afad9d1

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #2 from kargl at gcc dot gnu.org ---
Created attachment 52045
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52045&action=edit
Check FORM TEAM

The requirements on parsing of FORM TEAM are not checked.  The attached
patch checks TEAM_NUMBER and TEAM.  The optional form-team-spec-list is
currently not implemented in gfortran. Add a PSA to recruit new contributors.

[Bug fortran/103796] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446 since r8-6395-gf8862a1b2afad9d1

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

--- Comment #3 from kargl at gcc dot gnu.org ---
Created attachment 52046
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52046&action=edit
New diff

[Bug fortran/103796] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446 since r8-6395-gf8862a1b2afad9d1

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

--- Comment #4 from kargl at gcc dot gnu.org ---
Comment on attachment 52046
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52046
New diff

This replaces the first diff, which was prematurely created.

[Bug fortran/103796] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446 since r8-6395-gf8862a1b2afad9d1

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

--- Comment #5 from kargl at gcc dot gnu.org ---
(In reply to kargl from comment #4)
> Comment on attachment 52046 [details]
> New diff
> 
> This replaces the first diff, which was prematurely created.

The 'new diff' patch still rejects both z1.f90 and z2.f90.

[Bug fortran/103796] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446 since r8-6395-gf8862a1b2afad9d1

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jvdelisle at gcc dot gnu.org

--- Comment #6 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
This appears to be fixed on trunk. Can we close it?

[Bug fortran/103796] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446 since r8-6395-gf8862a1b2afad9d1

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

--- Comment #7 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Tue, Jul 04, 2023 at 09:34:02PM +0000, jvdelisle at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796
> 
> Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |jvdelisle at gcc dot gnu.org
> 
> --- Comment #6 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
> This appears to be fixed on trunk. Can we close it?
> 

Yes.  Likely fixed by 

2022-05-10  Harald Anlauf  <anlauf@gmx.de>

        PR fortran/105526
        * resolve.cc (check_team): New.
        (gfc_resolve_code): Add checks for arguments to coarray intrinsics
        FORM TEAM, CHANGE TEAM, and SYNC TEAM.

[Bug fortran/103796] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446 since r8-6395-gf8862a1b2afad9d1

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #8 from anlauf at gcc dot gnu.org ---
Dup of pr105526.

*** This bug has been marked as a duplicate of bug 105526 ***

[Bug fortran/103796] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9446 since r8-6395-gf8862a1b2afad9d1

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|DUPLICATE                   |---
             Status|RESOLVED                    |REOPENED

--- Comment #9 from anlauf at gcc dot gnu.org ---
Steve correctly noted in pr105526#c5 that his patch provides parsing of
the form-team-spec-list, although it will only emit a sorry-type error
message for a not implemented feature, instead of a syntax error.

Reopening, so that his patch won't be lost.

This PR might be referenced in a suitable coarray meta-bug.

[Bug fortran/103796] form-team-spec-list is unsupported

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103796

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-on-invalid-code         |
           Priority|P3                          |P4
            Summary|ICE in gfc_conv_expr_val,   |form-team-spec-list is
                   |at                          |unsupported
                   |fortran/trans-expr.c:9446   |
                   |since                       |
                   |r8-6395-gf8862a1b2afad9d1   |

--- Comment #10 from kargl at gcc dot gnu.org ---
Thanks Harald for re-opening the bug.  I've updated the Summary as you fixed
the ICE and this now documents the missing support for form-team-spec-list. 
I've also updated the Importance level.