[Bug c/105069] New: [12 regression] sh-elf internal compiler errors and test failures with -Os

[Bug c/105069] New: [12 regression] sh-elf internal compiler errors and test failures with -Os

[jscott at posteo dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

            Bug ID: 105069
           Summary: [12 regression] sh-elf internal compiler errors and
                    test failures with -Os
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jscott at posteo dot net
  Target Milestone: ---

Hi,

This seems to be a regression as compared to GCC 11. When building a bare-metal
compiler for sh-elf (Newlib or an ISO C standard library is not required), GCC
aborts with an internal compiler error:

gcc.c-torture/compile/pr104327.c:13:1: internal compiler error:
‘global_options’ are modified in local context
   13 | {
      | ^

There are numerous test suite failures that this causes:
gcc.c-torture/compile/pr104327.c (no special flags needed, since -Os is set via
an attribute)
and for the following, building with -Os is necessary:
gcc.c-torture/compile/pr58332.c
gcc.c-torture/compile/pr81360.c
gcc.c-torture/compile/pr84425.c

Here is a one-line reproducer:
cat bar.c
[[gnu::optimize("Os")]] int main(void) {}
$ sh-elf-gcc bar.c
bar.c:1:1: internal compiler error: ‘global_options’ are modified in local
context
    1 | [[gnu::optimize("Os")]] int main(void) {}
      | ^
0x7f231098a7fc __libc_start_main
        ../csu/libc-start.c:332

This occurs using the latest Git master on an x86_64 Debian Bullseye GNU/Linux
system. I'm not sure that this issue lies in the C frontend, so please reassign
wherever appropriate.

I discovered this issue running the test suite to upgrade the Debian gcc-sh-elf
package.

[Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
          Component|c                           |target
   Target Milestone|---                         |12.0

[Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os

[jscott at posteo dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

--- Comment #1 from John Scott <jscott at posteo dot net> ---
Here is a backtrace:

bar.c:2:1: internal compiler error: ‘global_options’ are modified in local
context
    2 | [[gnu::optimize("Os")]] int main(void) {}
      | ^
0xe71b6b cl_optimization_compare(gcc_options*, gcc_options*)
        /tmp/build/gcc/options-save.cc:13029
0xa077ac handle_optimize_attribute
        /tmp/gcc/gcc/c-family/c-attribs.cc:5567
0x9056f2 decl_attributes(tree_node**, tree_node*, int, tree_node*)
        /tmp/gcc/gcc/attribs.cc:867
0x9229bc start_function(c_declspecs*, c_declarator*, tree_node*)
        /tmp/gcc/gcc/c/c-decl.cc:9516
0x984a0e c_parser_declaration_or_fndef
        /tmp/gcc/gcc/c/c-parser.cc:2445
0x98db33 c_parser_external_declaration
        /tmp/gcc/gcc/c/c-parser.cc:1779
0x98e57b c_parser_translation_unit
        /tmp/gcc/gcc/c/c-parser.cc:1652
0x98e57b c_parse_file()
        /tmp/gcc/gcc/c/c-parser.cc:23357
0x9eef8d c_common_parse_file()
        /tmp/gcc/gcc/c-family/c-opts.cc:1240

[Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The ICE started with the PR92860 change.
sh_option_optimization_table has:
static const struct default_options sh_option_optimization_table[] =
  {
    { OPT_LEVELS_SIZE, OPT_mdiv_, SH_DIV_STR_FOR_SIZE, 1 },
    { OPT_LEVELS_0_ONLY, OPT_mdiv_, "", 1 },
    { OPT_LEVELS_ALL, OPT__param_simultaneous_prefetches_, NULL, 2 },
    { OPT_LEVELS_NONE, 0, NULL, 0 }
  };
and so wants to change sh_div_str for -Os or -O0.
But I think SH doesn't support target attribute.
Does sh_override_options_after_change need to do something, or is target
attribute handling now required for backends that do want to change some Target
options based on optimization levels?

[Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
SH isn't primary nor secondary, so P4.

[Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-03-28
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Lemme take a look.

[Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|marxin at gcc dot gnu.org          |unassigned at gcc dot gnu.org

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Well, the fix should be using TargetVariable for sh_div_str which will be then
automatically saved/restore in cl_target_option. However, one would need to
convert it from 'const char *' to an enum value.
Leaving that to a port maintainer.

[Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoliva at gcc dot gnu.org,
                   |                            |olegendo at gcc dot gnu.org

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
While changing mdiv= from accepting a string to Enum(something) might be worth
it, wouldn't that be GCC 13 material?  I think right now -mdiv= accepts random
garbage like -mdiv=foobar .  There is also an enum already but there is no 1:1
mapping between what is assigned to sh_div_strategy from what is in sh_div_str,
and sh_div_strategy probably should be a TargetVariable.

Anyway, wouldn't the following be enough for now to just do:

2022-03-31  Jakub Jelinek  <jakub@redhat.com>

        PR target/105069
        * config/sh/sh.opt (mdiv=): Add Save.

--- gcc/config/sh/sh.opt.jj     2022-01-11 23:11:21.990295775 +0100
+++ gcc/config/sh/sh.opt        2022-03-31 09:43:45.916244944 +0200
@@ -207,7 +207,7 @@ Target RejectNegative Mask(ALIGN_DOUBLE)
 Align doubles at 64-bit boundaries.

 mdiv=
-Target RejectNegative Joined Var(sh_div_str) Init("")
+Target Save RejectNegative Joined Var(sh_div_str) Init("")
 Division strategy, one of: call-div1, call-fp, call-table.

 mdivsi3_libfunc=

The testcase doesn't ICE with it anymore, and e.g. i386.opt has various Save
strings too.

[Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #6)
> While changing mdiv= from accepting a string to Enum(something) might be
> worth it, wouldn't that be GCC 13 material?  I think right now -mdiv=
> accepts random garbage like -mdiv=foobar .  There is also an enum already
> but there is no 1:1
> mapping between what is assigned to sh_div_strategy from what is in
> sh_div_str,
> and sh_div_strategy probably should be a TargetVariable.
> 
> Anyway, wouldn't the following be enough for now to just do:
> 
> 2022-03-31  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR target/105069
> 	* config/sh/sh.opt (mdiv=): Add Save.
> 
> --- gcc/config/sh/sh.opt.jj	2022-01-11 23:11:21.990295775 +0100
> +++ gcc/config/sh/sh.opt	2022-03-31 09:43:45.916244944 +0200
> @@ -207,7 +207,7 @@ Target RejectNegative Mask(ALIGN_DOUBLE)
>  Align doubles at 64-bit boundaries.
>  
>  mdiv=
> -Target RejectNegative Joined Var(sh_div_str) Init("")
> +Target Save RejectNegative Joined Var(sh_div_str) Init("")
>  Division strategy, one of: call-div1, call-fp, call-table.
>  
>  mdivsi3_libfunc=
> 
> The testcase doesn't ICE with it anymore, and e.g. i386.opt has various Save
> strings too.

Yes, that's going to work as with the patch the target value is properly saved
and restored in cl_target_option_{save,restore}.

[Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:6283d5ad4779d3e5b7b2a93e76de03264a7c7cc6

commit r12-8027-g6283d5ad4779d3e5b7b2a93e76de03264a7c7cc6
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Apr 6 17:36:54 2022 +0200

    sh: Fix up __attribute__((optimize ("Os"))) handling on SH [PR105069]

    As mentioned in the PR, various tests on sh-elf ICE like:
    make check-gcc RUNTESTFLAGS="compile.exp='pr104327.c pr58332.c pr81360.c
pr84425.c'"
    FAIL: gcc.c-torture/compile/pr104327.c   -O0  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr104327.c   -O0  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr104327.c   -O1  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr104327.c   -O1  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr104327.c   -O2  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr104327.c   -O2  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr104327.c   -O3 -g  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr104327.c   -O3 -g  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr104327.c   -Os  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr58332.c   -O0  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr58332.c   -O1  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr58332.c   -O1  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr58332.c   -O2  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr58332.c   -O2  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr58332.c   -O3 -g  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr58332.c   -O3 -g  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr58332.c   -Os  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr58332.c   -Os  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr81360.c   -O0  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr81360.c   -O1  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr81360.c   -O1  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr81360.c   -O2  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr81360.c   -O2  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr81360.c   -O3 -g  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr81360.c   -O3 -g  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr81360.c   -Os  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr81360.c   -Os  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr84425.c   -O0  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr84425.c   -O1  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr84425.c   -O1  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr84425.c   -O2  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr84425.c   -O2  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr84425.c   -O3 -g  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr84425.c   -O3 -g  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr84425.c   -Os  (internal compiler error:
'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr84425.c   -Os  (test for excess errors)
    With the following patch, none of those tests ICE anymore, though
    pr104327.c still FAILs with:
    Excess errors:
    /usr/src/gcc/gcc/testsuite/gcc.c-torture/compile/pr104327.c:6:1: error:
inlining failed in call to 'always_inline' 'bar': target specific option
mismatch
    I think that would be fixable by overriding TARGET_CAN_INLINE_P
    hook and allowing at least for always_inline changes in sh_div_str.

    2022-04-06  Jakub Jelinek  <jakub@redhat.com>

            PR target/105069
            * config/sh/sh.opt (mdiv=): Add Save.

[Bug target/105069] [12 regression] sh-elf internal compiler errors and test failures with -Os

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Some of the ICEs are gone, but pr104327.c is still rejected.

[Bug target/105069] [12/13 regression] sh-elf internal compiler errors and test failures with -Os

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.0                        |12.2

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 12.1 is being released, retargeting bugs to GCC 12.2.

[Bug target/105069] [12/13/14 regression] sh-elf internal compiler errors and test failures with -Os

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.3                        |12.4

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 12.3 is being released, retargeting bugs to GCC 12.4.