public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/105394] [12 Regression] ICE: verify_gimple failed with MVE during GIMPLE pass: veclower2
Date: Tue, 26 Apr 2022 13:18:52 +0000	[thread overview]
Message-ID: <bug-105394-4-mM7T0SUBt1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105394-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105394

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
We are calling tree_vec_extract with bitsize 32 but a QImode boolean type.

ICK.

(gdb) p debug_gimple_stmt (stmt)
_8 = VEC_COND_EXPR <_6, _7, { 3.0e+0, 3.0e+0, 3.0e+0, 3.0e+0 }>;
$15 = void
(gdb) p debug_tree (a)
 <ssa_name 0x7ffff6492318
    type <vector_type 0x7ffff66309d8
        type <boolean_type 0x7ffff6630930 public QI
            size <integer_cst 0x7ffff6526348 constant 8>
            unit-size <integer_cst 0x7ffff6526360 constant 1>
            align:8 warn_if_not_align:0 symtab:0 alias-set -1 canonical-type
0x7ffff6630930 precision:4 min <integer_cst 0x7ffff662e300 -8> max <integer_cst
0x7ffff662e348 7>>
        V4BI
        size <integer_cst 0x7ffff6526408 constant 16>
        unit-size <integer_cst 0x7ffff6526420 constant 2>
        align:16 warn_if_not_align:0 symtab:0 alias-set -1 canonical-type
0x7ffff66309d8 nunits:4>
    visited
    def_stmt _6 = _27;
    version:6>

so we have a non 1-precision BImode bool.  That's something we assume
doesn't happen (here).

I see V4BImode is 2 bytes in size, are there really 4 bits used for each
element?

The patch below assumes that and generates

  _40 = VIEW_CONVERT_EXPR<unsigned short>(_6);
  _41 = _40 & 15;
  _42 = _41 != 0 ? _30 : 3.0e+0;
  _43 = _40 & 240;
  _44 = _43 != 0 ? _33 : 3.0e+0;
  _45 = _40 & 3840;
  _46 = _45 != 0 ? _36 : 3.0e+0;
  _47 = _40 & 61440;
  _48 = _47 != 0 ? _39 : 3.0e+0;
  _8 = {_42, _44, _46, _48};

for the unsupported VEC_COND_EXPR.  The approach won't work for variable-length
vectors since we cannot pun that to an integer type (precision is always
constant).  So eventually using an adjusted BIT_FIELD_REF for the
vector BImode case is better - as said the current code simply assumes
a classical mask.

I suppose for SVE we never run into unsupported conds?

  parent reply	other threads:[~2022-04-26 13:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 12:23 [Bug tree-optimization/105394] New: " acoplan at gcc dot gnu.org
2022-04-26 12:40 ` [Bug tree-optimization/105394] " rguenth at gcc dot gnu.org
2022-04-26 12:42 ` acoplan at gcc dot gnu.org
2022-04-26 13:18 ` rguenth at gcc dot gnu.org [this message]
2022-04-26 13:19 ` rguenth at gcc dot gnu.org
2022-04-26 13:22 ` [Bug target/105394] " rguenth at gcc dot gnu.org
2022-04-29  9:07 ` [Bug target/105394] [12/13 " rguenth at gcc dot gnu.org
2022-04-29  9:20 ` rguenth at gcc dot gnu.org
2022-04-29  9:57 ` rguenth at gcc dot gnu.org
2022-04-29  9:59 ` acoplan at gcc dot gnu.org
2022-05-03  8:34 ` acoplan at gcc dot gnu.org
2022-05-03  8:49 ` rguenther at suse dot de
2022-05-03  9:19 ` cvs-commit at gcc dot gnu.org
2022-05-03  9:25 ` [Bug target/105394] [12 " rguenth at gcc dot gnu.org
2022-05-06  8:33 ` jakub at gcc dot gnu.org
2022-05-06  9:27 ` cvs-commit at gcc dot gnu.org
2022-05-06  9:28 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105394-4-mM7T0SUBt1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).