public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "roland at logikalsolutions dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105470] ranged for loop whitespace parsing
Date: Wed, 04 May 2022 14:40:39 +0000 [thread overview]
Message-ID: <bug-105470-4-RphGTDw9Gl@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105470-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105470
--- Comment #10 from Roland Hughes <roland at logikalsolutions dot com> ---
(In reply to Marek Polacek from comment #1)
>
> The warning is completely correct, and the code should be fixed.
>
> for ( const std::pair<KeyModifiers, Scintilla::Message> &it : someMap )
>
> This iterates over a map, with values of type:
>
> std::pair<const KeyModifiers, Scintilla::Message>
>
No, it doesn't.
[code]
roland@roland-HP-EliteDesk-800-G2-SFF:~/sf_projects/roland_hughes-csscintilla$
grep -irn GetKeyMap *
copperspice/CsScintillaEditBase/CsScintillaEditBase.cpp:1031: // the fact
GetKeyMap() returns const means we can't use an iterator
copperspice/CsScintillaEditBase/CsScintillaEditBase.cpp:1034: for ( const
std::pair<KeyModifiers, Scintilla::Message> &it : sqt->kmap.GetKeyMap() )
copperspice/CsScintillaEditBase/CsScintillaEditBase.cpp:1059: auto
findResult = std::find_if( std::begin( sqt->kmap.GetKeyMap() ),
copperspice/CsScintillaEditBase/CsScintillaEditBase.cpp:1060:
std::end( sqt->kmap.GetKeyMap() ),
copperspice/CsScintillaEditBase/CsScintillaEditBase.cpp:1066: if (
findResult != std::end( sqt->kmap.GetKeyMap() ) )
copperspice/CsScintillaEditBase/CsScintillaEditBase.cpp:4314:const
std::map<Scintilla::Internal::KeyModifiers, Scintilla::Message>
&CsScintillaEditBase::GetKeyMap() const noexcept
copperspice/CsScintillaEditBase/CsScintillaEditBase.cpp:4316: return
sqt->kmap.GetKeyMap();
copperspice/CsScintillaEditBase/CsScintillaEditBase.h:79: const
std::map<Scintilla::Internal::KeyModifiers, Scintilla::Message> &GetKeyMap()
const noexcept;
src/KeyMap.h:60: const std::map<KeyModifiers, Scintilla::Message>
&GetKeyMap() const noexcept;
src/KeyMap.cxx:50:const std::map<KeyModifiers, Message> &KeyMap::GetKeyMap()
const noexcept {
[/code]
There is no definition of that map anywhere in the codebase where KeyModifiers
is declared const.
The method being called returns a const & to the entire map, but there is no
const declared within the map.
next prev parent reply other threads:[~2022-05-04 14:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 23:28 [Bug c++/105470] New: " roland at logikalsolutions dot com
2022-05-03 23:41 ` [Bug c++/105470] " mpolacek at gcc dot gnu.org
2022-05-03 23:49 ` pinskia at gcc dot gnu.org
2022-05-04 0:14 ` redi at gcc dot gnu.org
2022-05-04 0:18 ` redi at gcc dot gnu.org
2022-05-04 0:21 ` redi at gcc dot gnu.org
2022-05-04 0:32 ` pinskia at gcc dot gnu.org
2022-05-04 8:07 ` redi at gcc dot gnu.org
2022-05-04 14:33 ` roland at logikalsolutions dot com
2022-05-04 14:39 ` mpolacek at gcc dot gnu.org
2022-05-04 14:40 ` roland at logikalsolutions dot com [this message]
2022-05-04 14:43 ` roland at logikalsolutions dot com
2022-05-04 15:31 ` redi at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-105470-4-RphGTDw9Gl@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).