public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105470] ranged for loop whitespace parsing
Date: Wed, 04 May 2022 00:32:34 +0000 [thread overview]
Message-ID: <bug-105470-4-W1rJPGhErN@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105470-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105470
--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #5)
> GCC even tells you exactly how to fix the code.
>
> Here's the GCC error reformatted to make it a bit easier to read:
>
> error: loop variable it of type
> const std::pair<Scintilla::Internal::KeyModifiers, Scintilla::Message>&
> binds to a temporary constructed from type
> const std::pair<const Scintilla::Internal::KeyModifiers, Scintilla::Message>
> [-Werror=range-loop-construct]
>
> note: use non-reference type
> const std::pair<Scintilla::Internal::KeyModifiers, Scintilla::Message>
> to make the copy explicit or
> const std::pair<const Scintilla::Internal::KeyModifiers, Scintilla::Message>&
> to prevent copying
>
> cc1plus: all warnings being treated as errors
auto comes in handy here so you could also just do:
for ( const auto &it : sqt->kmap.GetKeyMap() )
And not worry about the type matches exactly.
next prev parent reply other threads:[~2022-05-04 0:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 23:28 [Bug c++/105470] New: " roland at logikalsolutions dot com
2022-05-03 23:41 ` [Bug c++/105470] " mpolacek at gcc dot gnu.org
2022-05-03 23:49 ` pinskia at gcc dot gnu.org
2022-05-04 0:14 ` redi at gcc dot gnu.org
2022-05-04 0:18 ` redi at gcc dot gnu.org
2022-05-04 0:21 ` redi at gcc dot gnu.org
2022-05-04 0:32 ` pinskia at gcc dot gnu.org [this message]
2022-05-04 8:07 ` redi at gcc dot gnu.org
2022-05-04 14:33 ` roland at logikalsolutions dot com
2022-05-04 14:39 ` mpolacek at gcc dot gnu.org
2022-05-04 14:40 ` roland at logikalsolutions dot com
2022-05-04 14:43 ` roland at logikalsolutions dot com
2022-05-04 15:31 ` redi at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-105470-4-W1rJPGhErN@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).