public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/105470] ranged for loop whitespace parsing Date: Wed, 04 May 2022 00:18:24 +0000 [thread overview] Message-ID: <bug-105470-4-gH93HCcPGQ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-105470-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105470 Jonathan Wakely <redi at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|WAITING |RESOLVED Resolution|--- |INVALID --- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> --- (In reply to Roland Hughes from comment #0) > If you look at the error message, this version of the compiler demands the & > be against > instead of out with the variable. No it doesn't. > This appears to be a whitespace parsing bug. I don't think so. The warning is completely correct, and the code should be fixed. for ( const std::pair<KeyModifiers, Scintilla::Message> &it : someMap ) This iterates over a map, with values of type: std::pair<const KeyModifiers, Scintilla::Message> But the loop is using a reference to a different type: std::pair<KeyModifiers, Scintilla::Message> That causes a temporary to be created on every iteration of the loop, and the const-refernece binds to the temporary. The new GCC is smart enough to tell you this, and you've asked for that warning to be a fatal error. Either don't enable errors for that warning, or fix the code to avoid the unnecessary temporaries being created.
next prev parent reply other threads:[~2022-05-04 0:18 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-03 23:28 [Bug c++/105470] New: " roland at logikalsolutions dot com 2022-05-03 23:41 ` [Bug c++/105470] " mpolacek at gcc dot gnu.org 2022-05-03 23:49 ` pinskia at gcc dot gnu.org 2022-05-04 0:14 ` redi at gcc dot gnu.org 2022-05-04 0:18 ` redi at gcc dot gnu.org [this message] 2022-05-04 0:21 ` redi at gcc dot gnu.org 2022-05-04 0:32 ` pinskia at gcc dot gnu.org 2022-05-04 8:07 ` redi at gcc dot gnu.org 2022-05-04 14:33 ` roland at logikalsolutions dot com 2022-05-04 14:39 ` mpolacek at gcc dot gnu.org 2022-05-04 14:40 ` roland at logikalsolutions dot com 2022-05-04 14:43 ` roland at logikalsolutions dot com 2022-05-04 15:31 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-105470-4-gH93HCcPGQ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).