public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
@ 2022-05-09 10:23 ro at gcc dot gnu.org
2022-05-09 10:23 ` [Bug sanitizer/105531] " ro at gcc dot gnu.org
` (13 more replies)
0 siblings, 14 replies; 15+ messages in thread
From: ro at gcc dot gnu.org @ 2022-05-09 10:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
Bug ID: 105531
Summary: [13 regression] Recent libsanitizer imports breaks
Solaris 11.3 build
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: sanitizer
Assignee: unassigned at gcc dot gnu.org
Reporter: ro at gcc dot gnu.org
CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
jakub at gcc dot gnu.org, kcc at gcc dot gnu.org, marxin at gcc dot gnu.org
Target Milestone: ---
Target: i386-pc-solaris2.11, sparc-sun-solaris2.11
The recent libsanitizer import broke the build on Solaris 11.3, both SPARC and
x86:
/vol/gcc/src/hg/master/local/libsanitizer/sanitizer_common/sanitizer_linux_libcdep.cpp:
In function 'int __sanitizer::CollectStaticTlsBlocks(dl_phdr_info*,
std::size_t, void*)':
/vol/gcc/src/hg/master/local/libsanitizer/sanitizer_common/sanitizer_linux_libcdep.cpp:380:28:
error: 'struct dl_phdr_info' has no member named 'dlpi_tls_data'
380 | uptr begin = (uptr)info->dlpi_tls_data;
| ^~~~~~~~~~~~~
This happens because Solaris doesn't support dlpi_tls_data (and dlpi_tls_modid)
before Solaris 11.4 SRU 10.3.
It's not an issue for LLVM upstream which only support Solaris 11.4, but GCC
continues to support Solaris 11.3 as well.
I have an (abandoned) patch to fix this: https://reviews.llvm.org/D120059.
I'll
see if I can get it approved upstream (it needs slight modifications for
changes
to compiler-rt since it was submitted); otherwise it will have to be kept
gcc-local.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
@ 2022-05-09 10:23 ` ro at gcc dot gnu.org
2022-07-22 11:18 ` cvs-commit at gcc dot gnu.org
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ro at gcc dot gnu.org @ 2022-05-09 10:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |13.0
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
2022-05-09 10:23 ` [Bug sanitizer/105531] " ro at gcc dot gnu.org
@ 2022-07-22 11:18 ` cvs-commit at gcc dot gnu.org
2022-07-22 11:20 ` ro at gcc dot gnu.org
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-07-22 11:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:
https://gcc.gnu.org/g:786e51648bd9a6880339329380751809fb97cd6d
commit r13-1797-g786e51648bd9a6880339329380751809fb97cd6d
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date: Fri Jul 22 13:18:14 2022 +0200
libsanitizer: Fix Solaris 11.3 compilation [PR105531]
The libsanitizer build has been broken on Solaris 11.3 by the latest
import. An upstream patch to fix this has now been committed:
[sanitizer_common] Support Solaris < 11.4 in GetStaticTlsBoundary
https://reviews.llvm.org/D120059
I'd like to cherry-pick it into libsanitizer, too.
Bootstrapped without regressions on sparc-sun-solaris2.11,
i386-pc-solaris2.11 (both Solaris 11.3 and 11.4), and
x86_64-pc-linux-gnu.
2022-07-21 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
libsanitizer:
PR sanitizer/105531
* sanitizer_common/sanitizer_linux_libcdep.cpp,
sanitizer_common/sanitizer_solaris.h:: Cherry-pick
llvm-project revision 3776db9a4fd2080d23d6a5f52e405eea44558761.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
2022-05-09 10:23 ` [Bug sanitizer/105531] " ro at gcc dot gnu.org
2022-07-22 11:18 ` cvs-commit at gcc dot gnu.org
@ 2022-07-22 11:20 ` ro at gcc dot gnu.org
2022-10-03 8:29 ` ebotcazou at gcc dot gnu.org
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ro at gcc dot gnu.org @ 2022-07-22 11:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
URL| |https://gcc.gnu.org/piperma
| |il/gcc-patches/2022-July/59
| |8690.html
Status|UNCONFIRMED |RESOLVED
Assignee|unassigned at gcc dot gnu.org |ro at gcc dot gnu.org
--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> ---
Mine. Patch posted and commited.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (2 preceding siblings ...)
2022-07-22 11:20 ` ro at gcc dot gnu.org
@ 2022-10-03 8:29 ` ebotcazou at gcc dot gnu.org
2022-10-03 9:45 ` marxin at gcc dot gnu.org
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ebotcazou at gcc dot gnu.org @ 2022-10-03 8:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
Last reconfirmed| |2022-10-03
Ever confirmed|0 |1
CC| |ebotcazou at gcc dot gnu.org
--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Broken again, but apparently you already fixed it upstream?
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (3 preceding siblings ...)
2022-10-03 8:29 ` ebotcazou at gcc dot gnu.org
@ 2022-10-03 9:45 ` marxin at gcc dot gnu.org
2022-10-03 9:49 ` ro at CeBiTec dot Uni-Bielefeld.DE
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-10-03 9:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Yes, the change landed to upstream as 3776db9a4fd2080d23d6a5f52e405eea44558761
and thus should be part of what I merged in r13-2269-g600413c4f3d703.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (4 preceding siblings ...)
2022-10-03 9:45 ` marxin at gcc dot gnu.org
@ 2022-10-03 9:49 ` ro at CeBiTec dot Uni-Bielefeld.DE
2022-10-03 9:50 ` marxin at gcc dot gnu.org
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2022-10-03 9:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
--- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
> Yes, the change landed to upstream as 3776db9a4fd2080d23d6a5f52e405eea44558761
> and thus should be part of what I merged in r13-2269-g600413c4f3d703.
That's the fix for the previous breakage. The one Eric is alluding to
is https://reviews.llvm.org/D133556
(1cd4d63fb9ab0f04c7151911dde0d58b673823de). I mean to submit a patch
cherry-picking that one shortly.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (5 preceding siblings ...)
2022-10-03 9:49 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2022-10-03 9:50 ` marxin at gcc dot gnu.org
2022-10-03 9:54 ` ebotcazou at gcc dot gnu.org
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-10-03 9:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #5)
> > --- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
> > Yes, the change landed to upstream as 3776db9a4fd2080d23d6a5f52e405eea44558761
> > and thus should be part of what I merged in r13-2269-g600413c4f3d703.
>
> That's the fix for the previous breakage. The one Eric is alluding to
> is https://reviews.llvm.org/D133556
> (1cd4d63fb9ab0f04c7151911dde0d58b673823de). I mean to submit a patch
> cherry-picking that one shortly.
Ok, I see. Please commit the change once you send it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (6 preceding siblings ...)
2022-10-03 9:50 ` marxin at gcc dot gnu.org
@ 2022-10-03 9:54 ` ebotcazou at gcc dot gnu.org
2022-10-03 12:53 ` ro at gcc dot gnu.org
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ebotcazou at gcc dot gnu.org @ 2022-10-03 9:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
--- Comment #7 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> I mean to submit a patch cherry-picking that one shortly.
OK, thanks in advance.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (7 preceding siblings ...)
2022-10-03 9:54 ` ebotcazou at gcc dot gnu.org
@ 2022-10-03 12:53 ` ro at gcc dot gnu.org
2022-10-03 14:10 ` marxin at gcc dot gnu.org
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ro at gcc dot gnu.org @ 2022-10-03 12:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #8 from Rainer Orth <ro at gcc dot gnu.org> ---
Done now, however this wasn't somehow picked up in the PR.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (8 preceding siblings ...)
2022-10-03 12:53 ` ro at gcc dot gnu.org
@ 2022-10-03 14:10 ` marxin at gcc dot gnu.org
2022-10-03 14:11 ` marxin at gcc dot gnu.org
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-10-03 14:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
--- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
I can't see the commit in git history, have you pushed the revision?
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (9 preceding siblings ...)
2022-10-03 14:10 ` marxin at gcc dot gnu.org
@ 2022-10-03 14:11 ` marxin at gcc dot gnu.org
2022-10-03 14:29 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-10-03 14:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--- Comment #10 from Martin Liška <marxin at gcc dot gnu.org> ---
Openning..
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (10 preceding siblings ...)
2022-10-03 14:11 ` marxin at gcc dot gnu.org
@ 2022-10-03 14:29 ` cvs-commit at gcc dot gnu.org
2022-10-03 14:31 ` ro at CeBiTec dot Uni-Bielefeld.DE
2022-10-03 14:31 ` ro at gcc dot gnu.org
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-10-03 14:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:
https://gcc.gnu.org/g:77d0627c244f7520bf74ec9cf2a8b69c32b6d30d
commit r13-3033-g77d0627c244f7520bf74ec9cf2a8b69c32b6d30d
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date: Mon Oct 3 16:28:46 2022 +0200
libsanitizer: Fix Solaris 11.3 compilation of
sanitizer_procmaps_solaris.cpp [PR105531]
The latest libsanitizer import broke Solaris 11.3 bootstrap again, due
to an oversight of mine. A fix has been committed upstream
https://reviews.llvm.org/D133556
This patch cherry-picks it. Tested on Solaris 11.3 and 11.4, SPARC and
x86.
2022-09-23 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
libsanitizer:
PR sanitizer/105531
* sanitizer_common/sanitizer_procmaps_solaris.cpp: Cherry-pick
llvm-project revision 1cd4d63fb9ab0f04c7151911dde0d58b673823de.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (11 preceding siblings ...)
2022-10-03 14:29 ` cvs-commit at gcc dot gnu.org
@ 2022-10-03 14:31 ` ro at CeBiTec dot Uni-Bielefeld.DE
2022-10-03 14:31 ` ro at gcc dot gnu.org
13 siblings, 0 replies; 15+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2022-10-03 14:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
--- Comment #12 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
> I can't see the commit in git history, have you pushed the revision?
I hadn't. Seems I shouldn't work on a holiday ;-)
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug sanitizer/105531] [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
` (12 preceding siblings ...)
2022-10-03 14:31 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2022-10-03 14:31 ` ro at gcc dot gnu.org
13 siblings, 0 replies; 15+ messages in thread
From: ro at gcc dot gnu.org @ 2022-10-03 14:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105531
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #13 from Rainer Orth <ro at gcc dot gnu.org> ---
Fixed for real now.
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-10-03 14:31 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 10:23 [Bug sanitizer/105531] New: [13 regression] Recent libsanitizer imports breaks Solaris 11.3 build ro at gcc dot gnu.org
2022-05-09 10:23 ` [Bug sanitizer/105531] " ro at gcc dot gnu.org
2022-07-22 11:18 ` cvs-commit at gcc dot gnu.org
2022-07-22 11:20 ` ro at gcc dot gnu.org
2022-10-03 8:29 ` ebotcazou at gcc dot gnu.org
2022-10-03 9:45 ` marxin at gcc dot gnu.org
2022-10-03 9:49 ` ro at CeBiTec dot Uni-Bielefeld.DE
2022-10-03 9:50 ` marxin at gcc dot gnu.org
2022-10-03 9:54 ` ebotcazou at gcc dot gnu.org
2022-10-03 12:53 ` ro at gcc dot gnu.org
2022-10-03 14:10 ` marxin at gcc dot gnu.org
2022-10-03 14:11 ` marxin at gcc dot gnu.org
2022-10-03 14:29 ` cvs-commit at gcc dot gnu.org
2022-10-03 14:31 ` ro at CeBiTec dot Uni-Bielefeld.DE
2022-10-03 14:31 ` ro at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).