[Bug rtl-optimization/105686] New: [10/11/12/13 Regression] ICE: verify_flow_info failed: missing REG_EH_REGION note at the end of bb 8 with -fnon-call-exceptions

[Bug rtl-optimization/105686] New: [10/11/12/13 Regression] ICE: verify_flow_info failed: missing REG_EH_REGION note at the end of bb 8 with -fnon-call-exceptions

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105686

            Bug ID: 105686
           Summary: [10/11/12/13 Regression] ICE: verify_flow_info failed:
                    missing REG_EH_REGION note at the end of bb 8 with
                    -fnon-call-exceptions
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: aarch64-unknown-linux-gnu

Created attachment 53013
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53013&action=edit
reduced testcase

Compiler output:
$ aarch64-unknown-linux-gnu-gcc -O -fno-delete-dead-exceptions
-fnon-call-exceptions -fexceptions -fno-tree-dce -fno-tree-forwprop testcase.c
testcase.c: In function 'foo':
testcase.c:11:1: error: missing REG_EH_REGION note at the end of bb 8
   11 | }
      | ^
testcase.c:11:1: error: missing REG_EH_REGION note at the end of bb 7
testcase.c:11:1: error: missing REG_EH_REGION note at the end of bb 6
testcase.c:11:1: error: missing REG_EH_REGION note at the end of bb 5
testcase.c:11:1: error: missing REG_EH_REGION note at the end of bb 4
testcase.c:11:1: error: missing REG_EH_REGION note at the end of bb 3
during RTL pass: cprop_hardreg
testcase.c:11:1: internal compiler error: verify_flow_info failed
0xc42133 verify_flow_info()
        /repo/gcc-trunk/gcc/cfghooks.cc:284
0x1055eba execute_function_todo
        /repo/gcc-trunk/gcc/passes.cc:2097
0x105643b execute_todo
        /repo/gcc-trunk/gcc/passes.cc:2139
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ aarch64-unknown-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-aarch64/bin/aarch64-unknown-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r13-694-20220520170416-gd5cf2a1f15e-checking-yes-rtl-df-extra-aarch64/bin/../libexec/gcc/aarch64-unknown-linux-gnu/13.0.0/lto-wrapper
Target: aarch64-unknown-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl
--with-sysroot=/usr/aarch64-unknown-linux-gnu --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=aarch64-unknown-linux-gnu
--with-ld=/usr/bin/aarch64-unknown-linux-gnu-ld
--with-as=/usr/bin/aarch64-unknown-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r13-694-20220520170416-gd5cf2a1f15e-checking-yes-rtl-df-extra-aarch64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.0.0 20220520 (experimental) (GCC)

[Bug rtl-optimization/105686] [10/11/12/13 Regression] ICE: verify_flow_info failed: missing REG_EH_REGION note at the end of bb 8 with -fnon-call-exceptions

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105686

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.4

[Bug rtl-optimization/105686] [10/11/12/13 Regression] ICE: verify_flow_info failed: missing REG_EH_REGION note at the end of bb 8 with -fnon-call-exceptions

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105686

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |ebotcazou at gcc dot gnu.org
   Last reconfirmed|                            |2022-05-23
           Priority|P3                          |P2

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
@@ -67,31 +63,11 @@
   179: NOTE_INSN_BASIC_BLOCK 3
     9: NOTE_INSN_DELETED
   183: x2:DI=[sp:DI+0x40]
-  184: x0:DI=[sp:DI+0x48]
-      REG_UNUSED x0:DI
-  185: x0:DI=[sp:DI+0x50]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   217: NOTE_INSN_BASIC_BLOCK 4
-  186: x0:DI=[sp:DI+0x58]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   218: NOTE_INSN_BASIC_BLOCK 5
-  187: x0:DI=[sp:DI+0x60]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   219: NOTE_INSN_BASIC_BLOCK 6
-  188: x0:DI=[sp:DI+0x68]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   220: NOTE_INSN_BASIC_BLOCK 7
-  189: x0:DI=[sp:DI+0x70]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   221: NOTE_INSN_BASIC_BLOCK 8
-  190: x0:DI=[sp:DI+0x78]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   226: NOTE_INSN_BASIC_BLOCK 9
   228: pc=L227
   229: barrier

while there's nothing wrong with the transform, cprop-hardreg likely lacks
cleanup of EH side-effects / edges.

      /* Detect obviously dead sets (via REG_UNUSED notes) and remove them.  */
      if (set
          && !RTX_FRAME_RELATED_P (insn)
          && NONJUMP_INSN_P (insn)
          && !may_trap_p (set)
          && find_reg_note (insn, REG_UNUSED, SET_DEST (set))
          && !side_effects_p (SET_SRC (set))
          && !side_effects_p (SET_DEST (set)))
        {
          bool last = insn == BB_END (bb);
          delete_insn (insn);
          if (last)
            break;
          continue;

using delete_insn_and_edges here fixes it but reg_cprop doesn't schedule
a CFG cleanup so that isn't enough.

leaving to RTL maintainers.

[Bug rtl-optimization/105686] [10/11/12/13 Regression] ICE: verify_flow_info failed: missing REG_EH_REGION note at the end of bb 8 with -fnon-call-exceptions

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105686

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Btw. 2092f134b7180cd2542cff93bd8a876b3e59a77b revision made it visible.

[Bug rtl-optimization/105686] [10/11/12/13 Regression] ICE: verify_flow_info failed: missing REG_EH_REGION note at the end of bb 8 with -fnon-call-exceptions

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105686

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug rtl-optimization/105686] [10/11/12/13 Regression] ICE: verify_flow_info failed: missing REG_EH_REGION note at the end of bb 8 with -fnon-call-exceptions

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105686

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #2)
> Btw. 2092f134b7180cd2542cff93bd8a876b3e59a77b revision made it visible.

r10-358-g2092f134b7180c

[Bug rtl-optimization/105686] [10/11/12/13/14 Regression] ICE: verify_flow_info failed: missing REG_EH_REGION note at the end of bb 8 with -fnon-call-exceptions

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105686

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|13.0                        |
           Keywords|                            |needs-bisection

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This seems like it has gone latent again in GCC 13.
I noticed something in the pro_and_epilogue pass that merges the basic blocks
at that point even.

[Bug rtl-optimization/105686] [10/11/12/13/14 Regression] ICE: verify_flow_info failed: missing REG_EH_REGION note at the end of bb 8 with -fnon-call-exceptions

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105686

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
           Keywords|needs-bisection             |

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Nope it was fully fixed, via PR 90259. See bug 90259 comment #7 which makes
this an exact duplicate of that bug so closing as such.

*** This bug has been marked as a duplicate of bug 90259 ***