public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "davidfromonline at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/105768] New: Missed optimization: shifting signed to unsigned range before comparison not removed
Date: Sun, 29 May 2022 16:17:37 +0000	[thread overview]
Message-ID: <bug-105768-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105768

            Bug ID: 105768
           Summary: Missed optimization: shifting signed to unsigned range
                    before comparison not removed
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: davidfromonline at gmail dot com
  Target Milestone: ---

The following translation unit:

```
#include <limits.h>

inline unsigned to_unsigned(int value) {
        return (unsigned)value + (unsigned)INT_MIN;
}

bool f(int lhs, int rhs) {
        return to_unsigned(lhs) < to_unsigned(rhs);
}
```

when compiled with `-O3` optimizes to

```
f(int, int):
        add     esi, -2147483648
        add     edi, -2147483648
        cmp     edi, esi
        setb    al
        ret
```

I would expect this to optimize to

```
f(int, int):
        cmp     edi, esi
        setl    al
        ret
```

Essentially, I want gcc to recognize that a signed value + minimum signed
value, as an unsigned, has the same comparison semantics as just comparing the
original signed value.

This code pattern comes up in implementations of radix sort (specifically,
ska_sort) when it falls back to std::sort (for instance, because the range is
small).

See it live: https://godbolt.org/z/Gn4rxr3nY

             reply	other threads:[~2022-05-29 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-29 16:17 davidfromonline at gmail dot com [this message]
2022-10-24 19:28 ` [Bug middle-end/105768] " pinskia at gcc dot gnu.org
2023-05-17 21:31 ` [Bug tree-optimization/105768] " pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105768-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).