public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/105768] New: Missed optimization: shifting signed to unsigned range before comparison not removed
@ 2022-05-29 16:17 davidfromonline at gmail dot com
  2022-10-24 19:28 ` [Bug middle-end/105768] " pinskia at gcc dot gnu.org
  2023-05-17 21:31 ` [Bug tree-optimization/105768] " pinskia at gcc dot gnu.org
  0 siblings, 2 replies; 3+ messages in thread
From: davidfromonline at gmail dot com @ 2022-05-29 16:17 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105768

            Bug ID: 105768
           Summary: Missed optimization: shifting signed to unsigned range
                    before comparison not removed
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: davidfromonline at gmail dot com
  Target Milestone: ---

The following translation unit:

```
#include <limits.h>

inline unsigned to_unsigned(int value) {
        return (unsigned)value + (unsigned)INT_MIN;
}

bool f(int lhs, int rhs) {
        return to_unsigned(lhs) < to_unsigned(rhs);
}
```

when compiled with `-O3` optimizes to

```
f(int, int):
        add     esi, -2147483648
        add     edi, -2147483648
        cmp     edi, esi
        setb    al
        ret
```

I would expect this to optimize to

```
f(int, int):
        cmp     edi, esi
        setl    al
        ret
```

Essentially, I want gcc to recognize that a signed value + minimum signed
value, as an unsigned, has the same comparison semantics as just comparing the
original signed value.

This code pattern comes up in implementations of radix sort (specifically,
ska_sort) when it falls back to std::sort (for instance, because the range is
small).

See it live: https://godbolt.org/z/Gn4rxr3nY

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug middle-end/105768] Missed optimization: shifting signed to unsigned range before comparison not removed
  2022-05-29 16:17 [Bug middle-end/105768] New: Missed optimization: shifting signed to unsigned range before comparison not removed davidfromonline at gmail dot com
@ 2022-10-24 19:28 ` pinskia at gcc dot gnu.org
  2023-05-17 21:31 ` [Bug tree-optimization/105768] " pinskia at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-10-24 19:28 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105768

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug tree-optimization/105768] Missed optimization: shifting signed to unsigned range before comparison not removed
  2022-05-29 16:17 [Bug middle-end/105768] New: Missed optimization: shifting signed to unsigned range before comparison not removed davidfromonline at gmail dot com
  2022-10-24 19:28 ` [Bug middle-end/105768] " pinskia at gcc dot gnu.org
@ 2023-05-17 21:31 ` pinskia at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-05-17 21:31 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105768

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|UNCONFIRMED                 |RESOLVED
          Component|middle-end                  |tree-optimization

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Dup of bug 94899 which is fixed for GCC 13.

*** This bug has been marked as a duplicate of bug 94899 ***

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-17 21:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-29 16:17 [Bug middle-end/105768] New: Missed optimization: shifting signed to unsigned range before comparison not removed davidfromonline at gmail dot com
2022-10-24 19:28 ` [Bug middle-end/105768] " pinskia at gcc dot gnu.org
2023-05-17 21:31 ` [Bug tree-optimization/105768] " pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).