public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/106498] New: [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645
@ 2022-08-01 10:32 asolokha at gmx dot com
2022-08-01 11:17 ` [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945 marxin at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: asolokha at gmx dot com @ 2022-08-01 10:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106498
Bug ID: 106498
Summary: [13 Regression] ICE in check_loop_closed_ssa_def, at
tree-ssa-loop-manip.cc:645
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Keywords: ice-on-valid-code
Severity: normal
Priority: P3
Component: tree-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: asolokha at gmx dot com
Target Milestone: ---
Target: powerpc-e300c3-linux-gnu
gcc 13.0.0 20220731 snapshot (g:525a1a73a5a563c829a5f76858fe122c9b39f254) ICEs
when compiling gcc/testsuite/gcc.c-torture/execute/pr71335.c for a 32-bit BE
powerpc target w/ -O1 -floop-parallelize-all -ftree-parallelize-loops=2:
% powerpc-e300c3-linux-gnu-gcc-13.0.0 -O1 -floop-parallelize-all
-ftree-parallelize-loops=2 -w -c gcc/testsuite/gcc.c-torture/execute/pr71335.c
during GIMPLE pass: ompexpssa
gcc/testsuite/gcc.c-torture/execute/pr71335.c: In function 'main':
gcc/testsuite/gcc.c-torture/execute/pr71335.c:3:1: internal compiler error: in
check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645
3 | main ()
| ^~~~
0x6e62f7 check_loop_closed_ssa_def
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20220731/work/gcc-13-20220731/gcc/tree-ssa-loop-manip.cc:645
0xfd3834 check_loop_closed_ssa_bb
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20220731/work/gcc-13-20220731/gcc/tree-ssa-loop-manip.cc:659
0xfd4e26 verify_loop_closed_ssa(bool, loop*)
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20220731/work/gcc-13-20220731/gcc/tree-ssa-loop-manip.cc:695
0xfd4e26 verify_loop_closed_ssa(bool, loop*)
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20220731/work/gcc-13-20220731/gcc/tree-ssa-loop-manip.cc:679
0xd691a4 execute_function_todo
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20220731/work/gcc-13-20220731/gcc/passes.cc:2109
0xd695eb execute_todo
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20220731/work/gcc-13-20220731/gcc/passes.cc:2145
This PR can in fact be a duplicate of PR106099, or PR106249, or both.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945
2022-08-01 10:32 [Bug tree-optimization/106498] New: [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 asolokha at gmx dot com
@ 2022-08-01 11:17 ` marxin at gcc dot gnu.org
2022-08-01 13:22 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-08-01 11:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106498
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
CC| |marxin at gcc dot gnu.org,
| |rguenth at gcc dot gnu.org
Last reconfirmed| |2022-08-01
Summary|[13 Regression] ICE in |[13 Regression] ICE in
|check_loop_closed_ssa_def, |check_loop_closed_ssa_def,
|at |at
|tree-ssa-loop-manip.cc:645 |tree-ssa-loop-manip.cc:645
| |since
| |r13-1450-gd2a89866660945
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-1450-gd2a89866660945.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945
2022-08-01 10:32 [Bug tree-optimization/106498] New: [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 asolokha at gmx dot com
2022-08-01 11:17 ` [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945 marxin at gcc dot gnu.org
@ 2022-08-01 13:22 ` rguenth at gcc dot gnu.org
2022-08-01 13:57 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-08-01 13:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106498
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org
Target Milestone|--- |13.0
Status|NEW |ASSIGNED
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will try to investigate.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945
2022-08-01 10:32 [Bug tree-optimization/106498] New: [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 asolokha at gmx dot com
2022-08-01 11:17 ` [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945 marxin at gcc dot gnu.org
2022-08-01 13:22 ` rguenth at gcc dot gnu.org
@ 2022-08-01 13:57 ` rguenth at gcc dot gnu.org
2022-08-02 6:40 ` cvs-commit at gcc dot gnu.org
2022-08-02 6:41 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-08-01 13:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106498
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed. Before OMP expansion the loops do not define virtual operands.
After OMP expansion there's (useless) loop-around virtual operands.
SSA form is updated at
#0 update_ssa (update_flags=2048)
at /space/rguenther/src/gcc-clean/gcc/tree-into-ssa.cc:3377
#1 0x00000000023fad6d in expand_omp_taskreg (region=0x3614bb0)
at /space/rguenther/src/gcc-clean/gcc/omp-expand.cc:1511
#2 0x000000000242a485 in expand_omp (region=0x3614bb0)
at /space/rguenther/src/gcc-clean/gcc/omp-expand.cc:10353
#3 0x000000000242aac4 in execute_expand_omp ()
at /space/rguenther/src/gcc-clean/gcc/omp-expand.cc:10592
#4 0x000000000242ac3f in (anonymous namespace)::pass_expand_omp_ssa::execute (
this=0x349c290) at /space/rguenther/src/gcc-clean/gcc/omp-expand.cc:10681
#5 0x000000000126d265 in execute_one_pass (
pass=<opt_pass* 0x349c290 "ompexpssa"(174)>)
which ends up adding this virtual def. The reason is a __builtin_GOMP_parallel
but the use is in a if (0 != 0) guarded region (that's possibly outlined
afterwards?).
It's quite ugly, SSA omp-expansion performs update_ssa sometimes per stmt!
SSA omp-expansion test coverage is quite weak and autopar isn't well maintained
:/
I do have a patch for this particular case though.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945
2022-08-01 10:32 [Bug tree-optimization/106498] New: [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 asolokha at gmx dot com
` (2 preceding siblings ...)
2022-08-01 13:57 ` rguenth at gcc dot gnu.org
@ 2022-08-02 6:40 ` cvs-commit at gcc dot gnu.org
2022-08-02 6:41 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-08-02 6:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106498
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:c30bbd4d169c98b7535a30384c6a971ee875fa44
commit r13-1926-gc30bbd4d169c98b7535a30384c6a971ee875fa44
Author: Richard Biener <rguenther@suse.de>
Date: Tue Aug 2 08:37:16 2022 +0200
tree-optimization/106498 - reduce SSA updates in autopar
The following reduces the number of SSA updates done during autopar
OMP expansion, specifically avoiding the cases that just add virtual
operands (where maybe none have been before) in dead regions of the CFG.
Instead virtual SSA update is delayed until after the pass. There's
much more TLC needed here, but test coverage makes it really difficult.
PR tree-optimization/106498
* omp-expand.cc (expand_omp_taskreg): Do not perform virtual
SSA update here.
(expand_omp_for): Or here.
(execute_expand_omp): Instead schedule it here together
with CFG cleanup via TODO.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945
2022-08-01 10:32 [Bug tree-optimization/106498] New: [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 asolokha at gmx dot com
` (3 preceding siblings ...)
2022-08-02 6:40 ` cvs-commit at gcc dot gnu.org
@ 2022-08-02 6:41 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-08-02 6:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106498
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-02 6:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-01 10:32 [Bug tree-optimization/106498] New: [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 asolokha at gmx dot com
2022-08-01 11:17 ` [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945 marxin at gcc dot gnu.org
2022-08-01 13:22 ` rguenth at gcc dot gnu.org
2022-08-01 13:57 ` rguenth at gcc dot gnu.org
2022-08-02 6:40 ` cvs-commit at gcc dot gnu.org
2022-08-02 6:41 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).