public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/106723] Unreplaced mode/code attributes in aarch64/arm backends
       [not found] <bug-106723-4@http.gcc.gnu.org/bugzilla/>
@ 2022-08-24  7:10 ` rguenth at gcc dot gnu.org
  2022-08-24  7:44 ` jakub at gcc dot gnu.org
  2022-08-24 15:34 ` rearnsha at gcc dot gnu.org
  2 siblings, 0 replies; 3+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-08-24  7:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106723

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
I wonder if the generator should simply skip mode combinations when a mode
attribute fails to expand?  That could be also used as "conditional iteration"
using a mode attribute expanding to "".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug target/106723] Unreplaced mode/code attributes in aarch64/arm backends
       [not found] <bug-106723-4@http.gcc.gnu.org/bugzilla/>
  2022-08-24  7:10 ` [Bug target/106723] Unreplaced mode/code attributes in aarch64/arm backends rguenth at gcc dot gnu.org
@ 2022-08-24  7:44 ` jakub at gcc dot gnu.org
  2022-08-24 15:34 ` rearnsha at gcc dot gnu.org
  2 siblings, 0 replies; 3+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-08-24  7:44 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106723

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I think better would be to error out (or just warn) if we see a valid mode/code
attribute which doesn't handle the corresponding mode/code.
For the PR106721, that would diagnose all but the last issue where there was a
typo, but that one is hard to distinguish from <x> or <logic> etc. appearing in
comments or perhaps assembly syntax on some targets.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug target/106723] Unreplaced mode/code attributes in aarch64/arm backends
       [not found] <bug-106723-4@http.gcc.gnu.org/bugzilla/>
  2022-08-24  7:10 ` [Bug target/106723] Unreplaced mode/code attributes in aarch64/arm backends rguenth at gcc dot gnu.org
  2022-08-24  7:44 ` jakub at gcc dot gnu.org
@ 2022-08-24 15:34 ` rearnsha at gcc dot gnu.org
  2 siblings, 0 replies; 3+ messages in thread
From: rearnsha at gcc dot gnu.org @ 2022-08-24 15:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106723

--- Comment #3 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
I think we should error if the name matches some iteration values, but not
others.  If <foo> is valid in the assembler output 'as-is' then it's bad form
to have an attribute that overloads this - and the fix is easy: rename the
iterator attribute.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-24 15:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-106723-4@http.gcc.gnu.org/bugzilla/>
2022-08-24  7:10 ` [Bug target/106723] Unreplaced mode/code attributes in aarch64/arm backends rguenth at gcc dot gnu.org
2022-08-24  7:44 ` jakub at gcc dot gnu.org
2022-08-24 15:34 ` rearnsha at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).