public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rodgertq at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/106772] atomic<T>::wait shouldn't touch waiter pool if used platform wait Date: Tue, 20 Sep 2022 03:38:34 +0000 [thread overview] Message-ID: <bug-106772-4-7BK09FAslF@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106772-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106772 --- Comment #3 from Thomas Rodgers <rodgertq at gcc dot gnu.org> --- Since this latter point has come up before, I want to additionally note that the optimization to use an atomic count of waiters per-waiter pool bucket means that a call to notify_one/notify_all is roughly 25x faster based on my testing than naively issuing a syscall to FUTEX_WAKE when there is no possibility of the wake being issued to a waiter. 2022-09-19T20:34:28-07:00 Running ./benchmark Run on (20 X 4800 MHz CPU s) CPU Caches: L1 Data 48 KiB (x10) L1 Instruction 32 KiB (x10) L2 Unified 1280 KiB (x10) L3 Unified 24576 KiB (x1) Load Average: 0.69, 0.61, 1.30 ***WARNING*** CPU scaling is enabled, the benchmark real time measurements may be noisy and will incur extra overhead. ------------------------------------------------------------------ Benchmark Time CPU Iterations ------------------------------------------------------------------ BM_empty_notify_checked 3.79 ns 3.79 ns 179929051 BM_empty_notify_syscall 94.1 ns 93.9 ns 7477997 For types that can use a FUTEX directly (e.g. int) there is no place to put that extra atomic to perform this check, so we can either have the type that is directly usable by the underlying platform be significantly more expensive to call, or we can use the waiter count in the waiter_pool.
next prev parent reply other threads:[~2022-09-20 3:38 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-29 12:38 [Bug libstdc++/106772] New: " valera.mironow at gmail dot com 2022-08-29 12:40 ` [Bug libstdc++/106772] " valera.mironow at gmail dot com 2022-08-29 15:12 ` rodgertq at gcc dot gnu.org 2022-09-20 3:38 ` rodgertq at gcc dot gnu.org [this message] 2022-09-20 7:39 ` valera.mironow at gmail dot com 2022-09-20 7:47 ` valera.mironow at gmail dot com 2022-09-20 14:14 ` rodgertq at gcc dot gnu.org 2022-09-20 14:20 ` valera.mironow at gmail dot com 2022-09-20 14:23 ` valera.mironow at gmail dot com 2022-09-20 14:27 ` valera.mironow at gmail dot com 2022-09-20 14:36 ` redi at gcc dot gnu.org 2022-09-20 14:40 ` rodgertq at gcc dot gnu.org 2022-09-20 14:54 ` valera.mironow at gmail dot com 2022-09-20 15:45 ` valera.mironow at gmail dot com 2022-09-20 15:55 ` redi at gcc dot gnu.org 2022-09-20 16:00 ` valera.mironow at gmail dot com 2022-09-20 16:05 ` valera.mironow at gmail dot com 2022-09-28 21:54 ` rodgertq at gcc dot gnu.org 2022-09-28 22:00 ` valera.mironow at gmail dot com 2022-09-28 22:04 ` valera.mironow at gmail dot com 2022-09-28 22:18 ` valera.mironow at gmail dot com 2022-09-28 22:34 ` rodgertq at gcc dot gnu.org 2022-09-28 22:50 ` rodgertq at gcc dot gnu.org 2022-09-28 23:09 ` valera.mironow at gmail dot com 2022-09-28 23:25 ` valera.mironow at gmail dot com 2022-09-28 23:40 ` rodgertq at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106772-4-7BK09FAslF@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).