[Bug c++/106875] New: [11/12/13 Regression] ICE in ix86_emit_outlined_ms2sysv_save, at config/i386/i386.cc:8343

[Bug c++/106875] New: [11/12/13 Regression] ICE in ix86_emit_outlined_ms2sysv_save, at config/i386/i386.cc:8343

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

            Bug ID: 106875
           Summary: [11/12/13 Regression] ICE in
                    ix86_emit_outlined_ms2sysv_save, at
                    config/i386/i386.cc:8343
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20211114 and 20211121, at -O0,
with file g++.target/i386/pr101180.C :


$ g++-13-20220904 -c pr101180.C -O0 -mabi=ms -fabi-version=3
-mcall-ms2sysv-xlogues
during RTL pass: pro_and_epilogue
pr101180.C: In function 'void f(T, FromT) [with T = A<float>; FromT = int]':
pr101180.C:19:1: internal compiler error: in ix86_emit_outlined_ms2sysv_save,
at config/i386/i386.cc:8343
   19 | }
      | ^
0x116e58a ix86_emit_outlined_ms2sysv_save
        ../../gcc/config/i386/i386.cc:8343
0x1184d2c ix86_expand_prologue()
        ../../gcc/config/i386/i386.cc:8919
0x162266a gen_prologue()
        ../../gcc/config/i386/i386.md:16194
0x11749c8 target_gen_prologue
        ../../gcc/config/i386/i386.md:23608
0xb77279 make_prologue_seq
        ../../gcc/function.cc:5826
0xb77454 thread_prologue_and_epilogue_insns()
        ../../gcc/function.cc:6058
0xb77a32 rest_of_handle_thread_prologue_and_epilogue
        ../../gcc/function.cc:6549
0xb77a32 execute
        ../../gcc/function.cc:6625

[Bug c++/106875] [11/12/13 Regression] ICE in ix86_emit_outlined_ms2sysv_save, at config/i386/i386.cc:8343 since r11-3183-gba948b37768c99cd

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-09-07
            Summary|[11/12/13 Regression] ICE   |[11/12/13 Regression] ICE
                   |in                          |in
                   |ix86_emit_outlined_ms2sysv_ |ix86_emit_outlined_ms2sysv_
                   |save, at                    |save, at
                   |config/i386/i386.cc:8343    |config/i386/i386.cc:8343
                   |                            |since
                   |                            |r11-3183-gba948b37768c99cd
             Status|UNCONFIRMED                 |NEW
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r11-3183-gba948b37768c99cd.

[Bug target/106875] [11/12/13 Regression] ICE in ix86_emit_outlined_ms2sysv_save, at config/i386/i386.cc:8343 since r11-3183-gba948b37768c99cd

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.4

[Bug target/106875] [11/12/13 Regression] ICE in ix86_emit_outlined_ms2sysv_save with -mabi=ms -mcall-ms2sysv-xlogues and "#pragma GCC target" since r11-3183-gba948b37768c99cd

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug target/106875] [11/12/13 Regression] ICE in ix86_emit_outlined_ms2sysv_save with -mabi=ms -mcall-ms2sysv-xlogues and "#pragma GCC target" since r11-3183-gba948b37768c99cd

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 53965
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53965&action=edit
gcc13-pr106875.patch

Untested fix.

[Bug target/106875] [11/12/13 Regression] ICE in ix86_emit_outlined_ms2sysv_save with -mabi=ms -mcall-ms2sysv-xlogues and "#pragma GCC target" since r11-3183-gba948b37768c99cd

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:ee629d242d9f93a38e49bed904bb334bbe15dde1

commit r13-4353-gee629d242d9f93a38e49bed904bb334bbe15dde1
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Nov 28 10:13:43 2022 +0100

    i386: Fix up ix86_abi handling [PR106875]

    The following testcase fails since my changes to make also
    opts_set saved/restored upon function target/optimization changes
    (before it has been acting as "has this option be ever explicit
    anywhere?").

    The problem is that for ix86_abi we depend on the opts_set
    value for it in ix86_option_override_internal:
      SET_OPTION_IF_UNSET (opts, opts_set, ix86_abi, DEFAULT_ABI);
    but as it is a TargetSave, the backend code is required to
    save/restore it manually (it does that) and since gcc 11 also
    to save/restore the opts_set bit for it (which isn't done).
    We don't do that for various other TargetSave which
    ix86_function_specific_{save,restore} saves/restores, but as long
    as we never test opts_set for it, it doesn't really matter.
    One possible fix would be to introduce some new TargetSave into
    which ix86_function_specific_{save,restore} would save/restore a bitmask
    of the opts_set bits.  The following patch uses an easier fix, by
    making it a TargetVariable instead the saving/restoring is handled
    by the generated code.
    The differences in options.h are just slight movements on where
    *ix86_abi stuff appears in it, ditto for options.cc, the real
    differences are just in options-save.cc, where cl_target_option_save
    gets:
    +  ptr->x_ix86_abi = opts->x_ix86_abi;
    ...
    +  if (opts_set->x_ix86_abi) mask |= HOST_WIDE_INT_1U << 3;
    (plus adjustments of following TargetVariables mask related stuff),
    cl_target_option_restore gets:
    +  opts->x_ix86_abi = ptr->x_ix86_abi;
    ...
    +  opts_set->x_ix86_abi = static_cast<enum calling_abi>((mask & 1) != 0);
    +  mask >>= 1;
    plus the movements in other functions too.  So, by it being a
    TargetVariable, the only thing that changed is that we don't need to
    handle it manually in ix86_function_specific_{save,restore} because it
    is handled automatically including the opts_set stuff.

    2022-11-28  Jakub Jelinek  <jakub@redhat.com>

            PR target/106875
            * config/i386/i386.opt (x_ix86_abi): Remove TargetSave.
            (ix86_abi): Replace it with TargetVariable.
            * config/i386/i386-options.cc (ix86_function_specific_save,
            ix86_function_specific_restore): Don't save and restore x_ix86_abi.

            * g++.target/i386/pr106875.C: New test.

[Bug target/106875] [11/12 Regression] ICE in ix86_emit_outlined_ms2sysv_save with -mabi=ms -mcall-ms2sysv-xlogues and "#pragma GCC target" since r11-3183-gba948b37768c99cd

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12/13 Regression] ICE   |[11/12 Regression] ICE in
                   |in                          |ix86_emit_outlined_ms2sysv_
                   |ix86_emit_outlined_ms2sysv_ |save with -mabi=ms
                   |save with -mabi=ms          |-mcall-ms2sysv-xlogues and
                   |-mcall-ms2sysv-xlogues and  |"#pragma GCC target" since
                   |"#pragma GCC target" since  |r11-3183-gba948b37768c99cd
                   |r11-3183-gba948b37768c99cd  |

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk for now.

[Bug target/106875] [11/12 Regression] ICE in ix86_emit_outlined_ms2sysv_save with -mabi=ms -mcall-ms2sysv-xlogues and "#pragma GCC target" since r11-3183-gba948b37768c99cd

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:85a84ce2e502b820277dbb399c43d4ced291efca

commit r12-9123-g85a84ce2e502b820277dbb399c43d4ced291efca
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Nov 28 10:13:43 2022 +0100

    i386: Fix up ix86_abi handling [PR106875]

    The following testcase fails since my changes to make also
    opts_set saved/restored upon function target/optimization changes
    (before it has been acting as "has this option be ever explicit
    anywhere?").

    The problem is that for ix86_abi we depend on the opts_set
    value for it in ix86_option_override_internal:
      SET_OPTION_IF_UNSET (opts, opts_set, ix86_abi, DEFAULT_ABI);
    but as it is a TargetSave, the backend code is required to
    save/restore it manually (it does that) and since gcc 11 also
    to save/restore the opts_set bit for it (which isn't done).
    We don't do that for various other TargetSave which
    ix86_function_specific_{save,restore} saves/restores, but as long
    as we never test opts_set for it, it doesn't really matter.
    One possible fix would be to introduce some new TargetSave into
    which ix86_function_specific_{save,restore} would save/restore a bitmask
    of the opts_set bits.  The following patch uses an easier fix, by
    making it a TargetVariable instead the saving/restoring is handled
    by the generated code.
    The differences in options.h are just slight movements on where
    *ix86_abi stuff appears in it, ditto for options.cc, the real
    differences are just in options-save.cc, where cl_target_option_save
    gets:
    +  ptr->x_ix86_abi = opts->x_ix86_abi;
    ...
    +  if (opts_set->x_ix86_abi) mask |= HOST_WIDE_INT_1U << 3;
    (plus adjustments of following TargetVariables mask related stuff),
    cl_target_option_restore gets:
    +  opts->x_ix86_abi = ptr->x_ix86_abi;
    ...
    +  opts_set->x_ix86_abi = static_cast<enum calling_abi>((mask & 1) != 0);
    +  mask >>= 1;
    plus the movements in other functions too.  So, by it being a
    TargetVariable, the only thing that changed is that we don't need to
    handle it manually in ix86_function_specific_{save,restore} because it
    is handled automatically including the opts_set stuff.

    2022-11-28  Jakub Jelinek  <jakub@redhat.com>

            PR target/106875
            * config/i386/i386.opt (x_ix86_abi): Remove TargetSave.
            (ix86_abi): Replace it with TargetVariable.
            * config/i386/i386-options.cc (ix86_function_specific_save,
            ix86_function_specific_restore): Don't save and restore x_ix86_abi.

            * g++.target/i386/pr106875.C: New test.

    (cherry picked from commit ee629d242d9f93a38e49bed904bb334bbe15dde1)

[Bug target/106875] [11 Regression] ICE in ix86_emit_outlined_ms2sysv_save with -mabi=ms -mcall-ms2sysv-xlogues and "#pragma GCC target" since r11-3183-gba948b37768c99cd

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12 Regression] ICE in   |[11 Regression] ICE in
                   |ix86_emit_outlined_ms2sysv_ |ix86_emit_outlined_ms2sysv_
                   |save with -mabi=ms          |save with -mabi=ms
                   |-mcall-ms2sysv-xlogues and  |-mcall-ms2sysv-xlogues and
                   |"#pragma GCC target" since  |"#pragma GCC target" since
                   |r11-3183-gba948b37768c99cd  |r11-3183-gba948b37768c99cd

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for gcc 12.3 too.

[Bug target/106875] [11 Regression] ICE in ix86_emit_outlined_ms2sysv_save with -mabi=ms -mcall-ms2sysv-xlogues and "#pragma GCC target" since r11-3183-gba948b37768c99cd

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:511b878b6a808c3d46dccf806223a851e63ad562

commit r11-10685-g511b878b6a808c3d46dccf806223a851e63ad562
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Nov 28 10:13:43 2022 +0100

    i386: Fix up ix86_abi handling [PR106875]

    The following testcase fails since my changes to make also
    opts_set saved/restored upon function target/optimization changes
    (before it has been acting as "has this option be ever explicit
    anywhere?").

    The problem is that for ix86_abi we depend on the opts_set
    value for it in ix86_option_override_internal:
      SET_OPTION_IF_UNSET (opts, opts_set, ix86_abi, DEFAULT_ABI);
    but as it is a TargetSave, the backend code is required to
    save/restore it manually (it does that) and since gcc 11 also
    to save/restore the opts_set bit for it (which isn't done).
    We don't do that for various other TargetSave which
    ix86_function_specific_{save,restore} saves/restores, but as long
    as we never test opts_set for it, it doesn't really matter.
    One possible fix would be to introduce some new TargetSave into
    which ix86_function_specific_{save,restore} would save/restore a bitmask
    of the opts_set bits.  The following patch uses an easier fix, by
    making it a TargetVariable instead the saving/restoring is handled
    by the generated code.
    The differences in options.h are just slight movements on where
    *ix86_abi stuff appears in it, ditto for options.cc, the real
    differences are just in options-save.cc, where cl_target_option_save
    gets:
    +  ptr->x_ix86_abi = opts->x_ix86_abi;
    ...
    +  if (opts_set->x_ix86_abi) mask |= HOST_WIDE_INT_1U << 3;
    (plus adjustments of following TargetVariables mask related stuff),
    cl_target_option_restore gets:
    +  opts->x_ix86_abi = ptr->x_ix86_abi;
    ...
    +  opts_set->x_ix86_abi = static_cast<enum calling_abi>((mask & 1) != 0);
    +  mask >>= 1;
    plus the movements in other functions too.  So, by it being a
    TargetVariable, the only thing that changed is that we don't need to
    handle it manually in ix86_function_specific_{save,restore} because it
    is handled automatically including the opts_set stuff.

    2022-11-28  Jakub Jelinek  <jakub@redhat.com>

            PR target/106875
            * config/i386/i386.opt (x_ix86_abi): Remove TargetSave.
            (ix86_abi): Replace it with TargetVariable.
            * config/i386/i386-options.c (ix86_function_specific_save,
            ix86_function_specific_restore): Don't save and restore x_ix86_abi.

            * g++.target/i386/pr106875.C: New test.

    (cherry picked from commit ee629d242d9f93a38e49bed904bb334bbe15dde1)

[Bug target/106875] [11 Regression] ICE in ix86_emit_outlined_ms2sysv_save with -mabi=ms -mcall-ms2sysv-xlogues and "#pragma GCC target" since r11-3183-gba948b37768c99cd

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106875

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.4 as well.