[Bug c/106881] New: ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740

[Bug c/106881] New: ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

            Bug ID: 106881
           Summary: ice in init_from_control_deps, at
                    gimple-predicate-analysis.cc:1740
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Created attachment 53546
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53546&action=edit
C source code

The attached C code does this:

 /home/dcb/gcc/results/bin/gcc -c -O1 -Wall -fexceptions bug843.c
during GIMPLE pass: uninit
src/eap-gtc.c: In function ‘eap_gtc_check_settings’:
src/eap-gtc.c:74:12: internal compiler error: in init_from_control_deps, at
gimple-predicate-analysis.cc:1740
0x1b161f5 predicate::init_from_control_deps(vec<edge_def*, va_heap, vl_ptr>
const*, unsigned int, bool)
        ../../trunk.git/gcc/gimple-predicate-analysis.cc:1740
0x1b16974 uninit_analysis::init_use_preds(predicate&, basic_block_def*,
basic_block_def*)
        ../../trunk.git/gcc/gimple-predicate-analysis.cc:1996

I will have a go at producing a git range and a reduction.

[Bug c/106881] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
Git range seems to be d6582c662ca0da05..cdcc27c1ca9c485c, i.e. since yesterday.

[Bug c/106881] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

--- Comment #2 from David Binderman <dcb314 at hotmail dot com> ---
Reduced C code seems to be:

inline auto_free(void *a) {
  void **p = a;
  l_free(*p);
}
eap_gtc_check_settings() {
  char *identity __attribute__((cleanup(auto_free)));
  char password __attribute__((cleanup(auto_free)));
  identity = l_settings_get_string();
  eap_append_secret();
}

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ice in                      |[13 Regression] ice in
                   |init_from_control_deps, at  |init_from_control_deps, at
                   |gimple-predicate-analysis.c |gimple-predicate-analysis.c
                   |c:1740                      |c:1740
           Keywords|                            |diagnostic,
                   |                            |ice-on-valid-code
            Version|12.0                        |13.0
   Target Milestone|---                         |13.0
          Component|c                           |tree-optimization

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=106866

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Are you sure this was not already fixed by r13-2518-ga262f969d6fd936f4fb5 (aka
PR 106866)

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

--- Comment #4 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Andrew Pinski from comment #3)
> Are you sure this was not already fixed by r13-2518-ga262f969d6fd936f4fb5
> (aka PR 106866)

Pretty sure. The git range I gave includes this commit.
Feel free to check. It is not unknown for me to make an error with git.

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740 since r13-2500-g0a4a2667dc115ca7

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-09-07
            Summary|[13 Regression] ice in      |[13 Regression] ice in
                   |init_from_control_deps, at  |init_from_control_deps, at
                   |gimple-predicate-analysis.c |gimple-predicate-analysis.c
                   |c:1740                      |c:1740 since
                   |                            |r13-2500-g0a4a2667dc115ca7

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Still present on master (d7f282c4243e24f567b11a5cb6048a27a3df733d), started
with r13-2500-g0a4a2667dc115ca7.

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740 since r13-2500-g0a4a2667dc115ca7

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740 since r13-2500-g0a4a2667dc115ca7

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:c8d3b44dfa2851659f966627835497667c5fed6c

commit r13-2537-gc8d3b44dfa2851659f966627835497667c5fed6c
Author: Richard Biener <rguenther@suse.de>
Date:   Thu Sep 8 12:22:26 2022 +0200

    tree-optimization/106881 - constrain uninit control edge add

    The following avoids adding fallthru edges to the control chain from
    the post-dominator walk.

            PR tree-optimization/106881
            * gimple-predicate-analysis.cc (compute_control_dep_chain_pdom):
            Add only non-fallthru edges and avoid the same set of edges
            as the caller does.

            * gcc.dg/uninit-pr106881.c: New testcase.

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740 since r13-2500-g0a4a2667dc115ca7

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Interesting, we have

<bb 10> [count: 0]:
resx 3

<bb 11> [count: 0]:
<L10>:
goto <bb 13>; [100.00%]

with an EH edge from 10 to 11.  That looks like a missed optimization,
eliding the RESX and turning the EH edge into a fallthru.

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740 since r13-2500-g0a4a2667dc115ca7

[sbergman at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

Stephan Bergmann <sbergman at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbergman at redhat dot com

--- Comment #9 from Stephan Bergmann <sbergman at redhat dot com> ---
*** Bug 106891 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740 since r13-2500-g0a4a2667dc115ca7

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

--- Comment #10 from David Binderman <dcb314 at hotmail dot com> ---
Created attachment 53554
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53554&action=edit
gzipped C++ source code

The attached C++ code, after Richard's fix, seems to break gcc.

Flags -O1 -Wall required.

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740 since r13-2500-g0a4a2667dc115ca7

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #11 from Martin Liška <marxin at gcc dot gnu.org> ---
Confirmed, reducing that right now..

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740 since r13-2500-g0a4a2667dc115ca7

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

--- Comment #12 from rguenther at suse dot de <rguenther at suse dot de> ---
On Fri, 9 Sep 2022, marxin at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881
> 
> Martin Li?ka <marxin at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>          Resolution|FIXED                       |---
>              Status|RESOLVED                    |REOPENED
> 
> --- Comment #11 from Martin Li?ka <marxin at gcc dot gnu.org> ---
> Confirmed, reducing that right now..

I'm already testing the obvious patch - reduction will be iffy because
you need to run into compile-time limits to get the fallback
implementation triggering ...

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740 since r13-2500-g0a4a2667dc115ca7

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:923da63e0f69b091014df5cc91498756053b1a46

commit r13-2557-g923da63e0f69b091014df5cc91498756053b1a46
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Sep 9 09:56:45 2022 +0200

    tree-optimization/106881 - fix simple_control_dep_chain part

    This adjusts simple_control_dep_chain in the same way I adjusted
    compute_control_dep_chain_pdom to avoid adding fallthru edges to
    the predicate chain.

            PR tree-optimization/106881
            * gimple-predicate-analysis.cc (simple_control_dep_chain):
            Add only non-fallthru edges and avoid the same set of edges
            as compute_control_dep_chain_pdom does.

[Bug tree-optimization/106881] [13 Regression] ice in init_from_control_deps, at gimple-predicate-analysis.cc:1740 since r13-2500-g0a4a2667dc115ca7

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106881

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #14 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.