[Bug fortran/106934] New: [10/11/12/13 Regression] ICE: verify_gimple failed

[Bug fortran/106934] New: [10/11/12/13 Regression] ICE: verify_gimple failed

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106934

            Bug ID: 106934
           Summary: [10/11/12/13 Regression] ICE: verify_gimple failed
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started with r9 :
(gcc configured with --enable-checking=yes)


$ cat z1.f90
subroutine s
   logical(1) :: a = .true.
   logical(2) :: b
   a = transfer(b, a)
end


$ gfortran-13-20220911 -c z1.f90 -O2
z1.f90:5:3:

    5 | end
      |   ^
Error: 'bit_field_ref' of non-mode-precision operand
_12 = BIT_FIELD_REF <b_13(D), 8, 0>;
during GIMPLE pass: ccp
z1.f90:5:3: internal compiler error: verify_gimple failed
0xf92e24 verify_gimple_in_cfg(function*, bool)
        ../../gcc/tree-cfg.cc:5569
0xe391ee execute_function_todo
        ../../gcc/passes.cc:2091
0xe39c72 execute_todo
        ../../gcc/passes.cc:2145

[Bug fortran/106934] [10/11/12/13 Regression] ICE: verify_gimple failed

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106934

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.5
           Keywords|                            |needs-bisection

[Bug fortran/106934] [10/11/12/13 Regression] ICE: verify_gimple failed since r9-5682-gef310a95a934d0f3

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106934

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org
           Keywords|needs-bisection             |
     Ever confirmed|0                           |1
            Summary|[10/11/12/13 Regression]    |[10/11/12/13 Regression]
                   |ICE: verify_gimple failed   |ICE: verify_gimple failed
                   |                            |since
                   |                            |r9-5682-gef310a95a934d0f3
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-09-13

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with the added verifier in r9-5682-gef310a95a934d0f3, likely a FE
issue.

[Bug tree-optimization/106934] [10/11/12/13 Regression] ICE: verify_gimple failed since r9-5682-gef310a95a934d0f3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106934

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
          Component|fortran                     |tree-optimization
           Keywords|                            |ice-checking,
                   |                            |ice-on-valid-code

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
We are folding

 __builtin_memcpy (&transfer.0, &b, 1);

to

  _12 = BIT_FIELD_REF <b_13(D), 8, 0>;
  MEM[(c_char * {ref-all})&transfer.0] = _12;

where update_address_taken rewrites

  _12 = MEM[(c_char * {ref-all}&b];

to the BIT_FIELD_REF, exactly because the memory reference
references QImode but the variable has HImode so we cannot use
a VIEW_CONVERT to pun.

The logic in update-address-taken doesn't match that of the verifier here,
the variable is

 <var_decl 0x7ffff6523cf0 b
    type <boolean_type 0x7ffff653e0a8 logical(kind=2) public unsigned HI
        size <integer_cst 0x7ffff6517dc8 constant 16>
        unit-size <integer_cst 0x7ffff6517de0 constant 2>
        align:16 warn_if_not_align:0 symtab:0 alias-set -1 canonical-type
0x7ffff653e0a8 precision:1 min <integer_cst 0x7ffff6539180 0> max <integer_cst
0x7ffff65391b0 1>
        pointer_to_this <pointer_type 0x7ffff670cb28>>
    used unsigned HI t.f90:3:18 size <integer_cst 0x7ffff6517dc8 16> unit-size
<integer_cst 0x7ffff6517de0 2>
    align:16 warn_if_not_align:0 context <function_decl 0x7ffff670e500 s>>

the intent of the verifier is to avoid the need to deal with referencing
padding in registers.  I'm not sure we absolutely have to uphold that
but a workaround would be to V_C_E the non-mode-precision operand to
a mode-precision operand and perform the BIT_FIELD_REF on that instead.
Note we don't seem to have any issue with non-integral typed non-mode-precision
operands here which is a bit inconsistent.

That was changed with the fix for PR88739.

[Bug tree-optimization/106934] [10/11/12/13 Regression] ICE: verify_gimple failed since r9-5682-gef310a95a934d0f3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106934

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:05f5c42cb42c5088187d44cc45a5f671d19ad8c5

commit r13-2657-g05f5c42cb42c5088187d44cc45a5f671d19ad8c5
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Sep 14 09:00:35 2022 +0200

    tree-optimization/106934 - avoid BIT_FIELD_REF of bitfields

    The following avoids creating BIT_FIELD_REF of bitfields in
    update-address-taken.  The patch doesn't implement punning to
    a full precision integer type but leaves a comment according to
    that.

            PR tree-optimization/106934
            * tree-ssa.cc (non_rewritable_mem_ref_base): Avoid BIT_FIELD_REFs
            of bitfields.
            (maybe_rewrite_mem_ref_base): Likewise.

            * gfortran.dg/pr106934.f90: New testcase.

[Bug tree-optimization/106934] [10/11/12 Regression] ICE: verify_gimple failed since r9-5682-gef310a95a934d0f3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106934

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |13.0
           Priority|P3                          |P2
            Summary|[10/11/12/13 Regression]    |[10/11/12 Regression] ICE:
                   |ICE: verify_gimple failed   |verify_gimple failed since
                   |since                       |r9-5682-gef310a95a934d0f3
                   |r9-5682-gef310a95a934d0f3   |
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

[Bug tree-optimization/106934] [10/11/12 Regression] ICE: verify_gimple failed since r9-5682-gef310a95a934d0f3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106934

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:c3119f575a04845fbbebbf90b5cdea88d5d76156

commit r12-8821-gc3119f575a04845fbbebbf90b5cdea88d5d76156
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Sep 14 09:00:35 2022 +0200

    tree-optimization/106934 - avoid BIT_FIELD_REF of bitfields

    The following avoids creating BIT_FIELD_REF of bitfields in
    update-address-taken.  The patch doesn't implement punning to
    a full precision integer type but leaves a comment according to
    that.

            PR tree-optimization/106934
            * tree-ssa.cc (non_rewritable_mem_ref_base): Avoid BIT_FIELD_REFs
            of bitfields.
            (maybe_rewrite_mem_ref_base): Likewise.

            * gfortran.dg/pr106934.f90: New testcase.

    (cherry picked from commit 05f5c42cb42c5088187d44cc45a5f671d19ad8c5)

[Bug tree-optimization/106934] [10/11 Regression] ICE: verify_gimple failed since r9-5682-gef310a95a934d0f3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106934

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:2bb2560ae196df515cfea9161a27ee86a1594777

commit r11-10318-g2bb2560ae196df515cfea9161a27ee86a1594777
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Sep 14 09:00:35 2022 +0200

    tree-optimization/106934 - avoid BIT_FIELD_REF of bitfields

    The following avoids creating BIT_FIELD_REF of bitfields in
    update-address-taken.  The patch doesn't implement punning to
    a full precision integer type but leaves a comment according to
    that.

            PR tree-optimization/106934
            * tree-ssa.c (non_rewritable_mem_ref_base): Avoid BIT_FIELD_REFs
            of bitfields.
            (maybe_rewrite_mem_ref_base): Likewise.

            * gfortran.dg/pr106934.f90: New testcase.

    (cherry picked from commit 05f5c42cb42c5088187d44cc45a5f671d19ad8c5)

[Bug tree-optimization/106934] [10 Regression] ICE: verify_gimple failed since r9-5682-gef310a95a934d0f3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106934

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:d0a3e323a0c0e3db7dcd428587f0633209f9ceec

commit r10-11176-gd0a3e323a0c0e3db7dcd428587f0633209f9ceec
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Sep 14 09:00:35 2022 +0200

    tree-optimization/106934 - avoid BIT_FIELD_REF of bitfields

    The following avoids creating BIT_FIELD_REF of bitfields in
    update-address-taken.  The patch doesn't implement punning to
    a full precision integer type but leaves a comment according to
    that.

            PR tree-optimization/106934
            * tree-ssa.c (non_rewritable_mem_ref_base): Avoid BIT_FIELD_REFs
            of bitfields.
            (maybe_rewrite_mem_ref_base): Likewise.

            * gfortran.dg/pr106934.f90: New testcase.

    (cherry picked from commit 05f5c42cb42c5088187d44cc45a5f671d19ad8c5)

[Bug tree-optimization/106934] [10 Regression] ICE: verify_gimple failed since r9-5682-gef310a95a934d0f3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106934

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Known to fail|                            |10.4.0
             Status|ASSIGNED                    |RESOLVED
      Known to work|                            |10.4.1

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.