[Bug fortran/106999] New: [11/12/13 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[Bug fortran/106999] New: [11/12/13 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

            Bug ID: 106999
           Summary: [11/12/13 Regression] ICE tree check: expected
                    record_type or union_type or qual_union_type, have
                    function_type in gfc_class_data_get, at
                    fortran/trans-expr.cc:233
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started with r11 before 20200503 :


$ cat z1.f90
program p
   type t
      procedure(g), pointer :: f
   end type
   class(t), allocatable :: z
   call s(z%f)
contains
   subroutine g(x)
      class(t) :: x
   end
   subroutine s(x)
      class(*) :: x
   end
end


$ gfortran-13-20220918 -c z1.f90
$ gfortran-10 -c z1.f90
$ gfortran-10 -c z1.f90 -fcheck=all
$
$ gfortran-13-20220918 -c z1.f90 -fcheck=all
z1.f90:6:14:

    6 |    call s(z%f)
      |              1
internal compiler error: tree check: expected record_type or union_type or
qual_union_type, have function_type in gfc_class_data_get, at
fortran/trans-expr.cc:233
0x6c055a tree_check_failed(tree_node const*, char const*, int, char const*,
...)
        ../../gcc/tree.cc:8827
0x8ec48b tree_check3(tree_node*, char const*, int, char const*, tree_code,
tree_code, tree_code)
        ../../gcc/tree.h:3560
0x8ec48b gfc_class_data_get(tree_node*)
        ../../gcc/fortran/trans-expr.cc:233
0x8f6b46 gfc_conv_procedure_call(gfc_se*, gfc_symbol*, gfc_actual_arglist*,
gfc_expr*, vec<tree_node*, va_gc, vl_embed>*)
        ../../gcc/fortran/trans-expr.cc:7228
0x9580b0 gfc_trans_call(gfc_code*, bool, tree_node*, tree_node*, bool)
        ../../gcc/fortran/trans-stmt.cc:422
0x8b0aa6 trans_code
        ../../gcc/fortran/trans.cc:2018
0x8e8009 gfc_generate_function_code(gfc_namespace*)
        ../../gcc/fortran/trans-decl.cc:7654
0x859a2e translate_all_program_units
        ../../gcc/fortran/parse.cc:6671
0x859a2e gfc_parse_file()
        ../../gcc/fortran/parse.cc:6977
0x8a7ccf gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:229

[Bug fortran/106999] [11/12/13 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---

FYI, a directly matching variant compiles :

$ cat z2.f90
program p
   type t
      procedure(g), pointer :: f
   end type
   class(t), allocatable :: z
   call s(z%f)
contains
   subroutine g(x)
      class(t) :: x
   end
   subroutine s(x)
      procedure(g) :: x
   end
end

[Bug fortran/106999] [11/12/13 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |11.4

[Bug fortran/106999] [11/12/13 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Also GCC 4.8 ICEs.

[Bug fortran/106999] [11/12/13/14 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-04-17

--- Comment #3 from anlauf at gcc dot gnu.org ---
FWIW, it is -fcheck=pointer triggering the ICE.

[Bug fortran/106999] [11/12/13/14 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.4                        |11.5

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 11.4 is being released, retargeting bugs to GCC 11.5.

[Bug fortran/106999] [11/12/13/14 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |pault at gcc dot gnu.org

--- Comment #5 from Paul Thomas <pault at gcc dot gnu.org> ---
Created attachment 57838
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57838&action=edit
Fix for this PR

Thanks for the report. The attached does what is required, I believe. It is
regtesting as I write.

Paul

[Bug fortran/106999] [11/12/13/14 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:a7aa9455a8b9cb080649a7357b7360f2d99bcbf1

commit r14-9753-ga7aa9455a8b9cb080649a7357b7360f2d99bcbf1
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Tue Apr 2 15:53:29 2024 +0100

    Fortran: Add error for subroutine passed to a variable dummy [PR106999]

    2024-04-02  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran
            PR fortran/106999
            * interface.cc (gfc_compare_interfaces): Add error for a
            subroutine proc pointer passed to a variable formal.
            (compare_parameter): If a procedure pointer is being passed to
            a non-procedure formal arg, and there is an an interface, use
            gfc_compare_interfaces to check and provide a more useful error
            message.

    gcc/testsuite/
            PR fortran/106999
            * gfortran.dg/pr106999.f90: New test.

[Bug fortran/106999] [11/12/13 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12/13/14 Regression]    |[11/12/13 Regression] ICE
                   |ICE tree check: expected    |tree check: expected
                   |record_type or union_type   |record_type or union_type
                   |or qual_union_type, have    |or qual_union_type, have
                   |function_type in            |function_type in
                   |gfc_class_data_get, at      |gfc_class_data_get, at
                   |fortran/trans-expr.cc:233   |fortran/trans-expr.cc:233

--- Comment #7 from Paul Thomas <pault at gcc dot gnu.org> ---
Needs backporting. Changed summary.

[Bug fortran/106999] [11/12/13 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:429935510202c4efee933bf907fd9dff816193f2

commit r13-8692-g429935510202c4efee933bf907fd9dff816193f2
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Tue Apr 2 15:53:29 2024 +0100

    Fortran: Add error for subroutine passed to a variable dummy [PR106999]

    2024-04-02  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran
            PR fortran/106999
            * interface.cc (gfc_compare_interfaces): Add error for a
            subroutine proc pointer passed to a variable formal.
            (compare_parameter): If a procedure pointer is being passed to
            a non-procedure formal arg, and there is an an interface, use
            gfc_compare_interfaces to check and provide a more useful error
            message.

    gcc/testsuite/
            PR fortran/106999
            * gfortran.dg/pr106999.f90: New test.

    (cherry picked from commit a7aa9455a8b9cb080649a7357b7360f2d99bcbf1)

[Bug fortran/106999] [11/12/13 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:d72e9f90e370538b057690b16c1e65350dbbb75c

commit r12-10416-gd72e9f90e370538b057690b16c1e65350dbbb75c
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Tue Apr 2 15:53:29 2024 +0100

    Fortran: Add error for subroutine passed to a variable dummy [PR106999]

    2024-04-02  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran
            PR fortran/106999
            * interface.cc (gfc_compare_interfaces): Add error for a
            subroutine proc pointer passed to a variable formal.
            (compare_parameter): If a procedure pointer is being passed to
            a non-procedure formal arg, and there is an an interface, use
            gfc_compare_interfaces to check and provide a more useful error
            message.

    gcc/testsuite/
            PR fortran/106999
            * gfortran.dg/pr106999.f90: New test.

    (cherry picked from commit a7aa9455a8b9cb080649a7357b7360f2d99bcbf1)

[Bug fortran/106999] [11/12/13 Regression] ICE tree check: expected record_type or union_type or qual_union_type, have function_type in gfc_class_data_get, at fortran/trans-expr.cc:233

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106999

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #10 from Paul Thomas <pault at gcc dot gnu.org> ---
Fixed on 12-branch through to mainline. Thanks for the report.

Paul