[Bug libgcc/107026] New: gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[Bug libgcc/107026] New: gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

            Bug ID: 107026
           Summary: gcc_assert (in_shutdown || ob); build failure for
                    i586-msdosdjgpp target
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgcc
          Assignee: unassigned at gcc dot gnu.org
          Reporter: unlvsur at live dot com
  Target Milestone: ---

../../../../../../gcc/libgcc/unwind-dw2-fde.c:287:15: error: 'in_shutdown'
undeclared (first use in this function)
  287 |   gcc_assert (in_shutdown || ob);
      |               ^~~~~~~~~~~
../../../../../../gcc/libgcc/../gcc/tsystem.h:122:36: note: in definition of
macro 'gcc_assert'
  122 | #define gcc_assert(EXPR) ((void)(!(EXPR) ? abort (), 0 : 0))
      |                                    ^~~~
../../../../../../gcc/libgcc/unwind-dw2-fde.c:287:15: note: each undeclared
identifier is reported only once for each function it appears in
  287 |   gcc_assert (in_shutdown || ob);
      |               ^~~~~~~~~~~
../../../../../../gcc/libgcc/../gcc/tsystem.h:122:36: note: in definition of
macro 'gcc_assert'
  122 | #define gcc_assert(EXPR) ((void)(!(EXPR) ? abort (), 0 : 0))
      |                                    ^~~~
make[2]: *** [../../../../../../gcc/libgcc/static-object.mk:17:
unwind-dw2-fde.o] Error 1
make[2]: *** Waiting for unfinished jobs....

[Bug libgcc/107026] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

--- Comment #1 from cqwrteur <unlvsur at live dot com> ---
Created attachment 53623
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53623&action=edit
config.log

[Bug libgcc/107026] [13 Regression] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-09-24
           Keywords|                            |build
            Summary|gcc_assert (in_shutdown ||  |[13 Regression] gcc_assert
                   |ob); build failure for      |(in_shutdown || ob); build
                   |i586-msdosdjgpp target      |failure for i586-msdosdjgpp
                   |                            |target
   Target Milestone|---                         |13.0
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Introduced by r13-2801-g94ccaf62c378c3.


The use in_shutdown is not inside the #ifdef ATOMIC_FDE_FAST_PATH
 case.

[Bug libgcc/107026] [13 Regression] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

--- Comment #3 from cqwrteur <unlvsur at live dot com> ---
(In reply to Andrew Pinski from comment #2)
> Introduced by r13-2801-g94ccaf62c378c3.
> 
> 
> The use in_shutdown is not inside the #ifdef ATOMIC_FDE_FAST_PATH
>  case.

this also happens with x86_64-w64-mingw32 target

btw it is weird why --disable-sjlj-exceptions is not working any more for
x86_64-w64-mingw32 target

[Bug libgcc/107026] [13 Regression] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|i586-msdosdjgpp             |i586-msdosdjgpp,
                   |                            |aarch64-none-elf
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=107018
                 CC|                            |tnfchris at gcc dot gnu.org

--- Comment #4 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Also broken on AArch64

[Bug libgcc/107026] [13 Regression] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tneumann at users dot sourceforge.
                   |                            |net

--- Comment #5 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
CC'ing author.

[Bug libgcc/107026] [13 Regression] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[tneumann at users dot sourceforge.net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

--- Comment #6 from Thomas Neumann <tneumann at users dot sourceforge.net> ---
I have a patch ready, I am waiting for approval:

https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602130.html

When using the atomic fast path deregistering can fail during
program shutdown if the lookup structures are already destroyed.
The assert in __deregister_frame_info_bases takes that into
account. In the non-fast-path case however is not aware of
program shutdown, which caused a compiler error on such platforms.
We fix that by introducing a constant for in_shutdown in
non-fast-path builds.

libgcc/ChangeLog:
        * unwind-dw2-fde.c: Introduce a constant for in_shutdown
        for the non-fast-path case.
---
 libgcc/unwind-dw2-fde.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libgcc/unwind-dw2-fde.c b/libgcc/unwind-dw2-fde.c
index d237179f4ea..0bcd5061d76 100644
--- a/libgcc/unwind-dw2-fde.c
+++ b/libgcc/unwind-dw2-fde.c
@@ -67,6 +67,8 @@ static void
 init_object (struct object *ob);

 #else
+/* Without fast path frame deregistration must always succeed.  */
+static const int in_shutdown = 0;

 /* The unseen_objects list contains objects that have been registered
    but not yet categorized in any way.  The seen_objects list has had
-- 
2.34.1

[Bug libgcc/107026] [13 Regression] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dje at gcc dot gnu.org

--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
*** Bug 107018 has been marked as a duplicate of this bug. ***

[Bug libgcc/107026] [13 Regression] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tschwinge at gcc dot gnu.org
           See Also|                            |https://github.com/Rust-GCC
                   |                            |/gccrs/issues/1544
             Target|i586-msdosdjgpp,            |i586-msdosdjgpp,
                   |aarch64-none-elf            |aarch64-none-elf,
                   |                            |x86_64-apple-darwin20.6.0
           Assignee|unassigned at gcc dot gnu.org      |tneumann at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #8 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Thomas Neumann, I suppose this is fixed via your commit
r13-2870-g386ebf75f4c0342b1f823f4e4aba07abda3288d1 "fix assert in
__deregister_frame_info_bases"?

[Bug libgcc/107026] [13 Regression] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[tneumann at users dot sourceforge.net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

--- Comment #9 from Thomas Neumann <tneumann at users dot sourceforge.net> ---
Yes, commit 386ebf75f4c0342b1f823f4e4aba07abda3288d1 fixes the assert.

[Bug libgcc/107026] [13 Regression] gcc_assert (in_shutdown || ob); build failure for i586-msdosdjgpp target

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107026

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Thomas Neumann, cool, I'm thus setting this RESOLVED, FIXED.  (Everyone, please
re-open if in fact there still remains any breakage.)

In the future, please feel free to set ASSIGNED to yourself any PRs that you're
working on, and later RESOLVED, FIXED, etc.