public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/107363] New: Wrong caret location for "redundant move in return statement"
@ 2022-10-23 9:43 dani at danielbertalan dot dev
2022-10-23 15:52 ` [Bug c++/107363] Wrong caret location for "redundant move in return statement" and nvo pinskia at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: dani at danielbertalan dot dev @ 2022-10-23 9:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107363
Bug ID: 107363
Summary: Wrong caret location for "redundant move in return
statement"
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c++
Assignee: unassigned at gcc dot gnu.org
Reporter: dani at danielbertalan dot dev
Target Milestone: ---
The caret in the following "redundant move in return statement" warning does
not point to a return statement (https://godbolt.org/z/4v7Y9G9e3):
```
#include <utility>
template <typename T>
struct Optional {
T &value();
T release_value() {
T released_value = std::move(value());
return released_value;
}
};
struct Foo {};
void test(Optional<const Foo> o) { o.release_value(); }
```
<source>:7:7: warning: redundant move in return statement [-Wredundant-move]
7 | T released_value = std::move(value());
| ^~~~~~~~~~~~~~
<source>:7:7: note: remove 'std::move' call
As an aside, it's a bit annoying to have this warning when the moved type
depends on a template parameter in library code. We are forced to either
silence this warning with a #pragma, or use concepts to have a variant of the
release_value method that does not call std::move for const-qualified T.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/107363] Wrong caret location for "redundant move in return statement" and nvo
2022-10-23 9:43 [Bug c++/107363] New: Wrong caret location for "redundant move in return statement" dani at danielbertalan dot dev
@ 2022-10-23 15:52 ` pinskia at gcc dot gnu.org
2022-10-24 16:34 ` mpolacek at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-10-23 15:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107363
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The wrong caret comes from named return value optimization iirc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/107363] Wrong caret location for "redundant move in return statement" and nvo
2022-10-23 9:43 [Bug c++/107363] New: Wrong caret location for "redundant move in return statement" dani at danielbertalan dot dev
2022-10-23 15:52 ` [Bug c++/107363] Wrong caret location for "redundant move in return statement" and nvo pinskia at gcc dot gnu.org
@ 2022-10-24 16:34 ` mpolacek at gcc dot gnu.org
2022-11-09 2:37 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2022-10-24 16:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107363
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2022-10-24
Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org
Ever confirmed|0 |1
CC| |mpolacek at gcc dot gnu.org
Status|UNCONFIRMED |ASSIGNED
--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
(In reply to Daniel Bertalan from comment #0)
> As an aside, it's a bit annoying to have this warning when the moved type
> depends on a template parameter in library code. We are forced to either
> silence this warning with a #pragma, or use concepts to have a variant of
> the release_value method that does not call std::move for const-qualified T.
Understood, I thought I'd fixed cases like that in
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=6602a2b2dee16af6e2d451c704789356042b5881
Something's not right here. I need to take a closed look. Thanks for
reporting the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/107363] Wrong caret location for "redundant move in return statement" and nvo
2022-10-23 9:43 [Bug c++/107363] New: Wrong caret location for "redundant move in return statement" dani at danielbertalan dot dev
2022-10-23 15:52 ` [Bug c++/107363] Wrong caret location for "redundant move in return statement" and nvo pinskia at gcc dot gnu.org
2022-10-24 16:34 ` mpolacek at gcc dot gnu.org
@ 2022-11-09 2:37 ` cvs-commit at gcc dot gnu.org
2022-11-09 2:52 ` mpolacek at gcc dot gnu.org
2022-11-28 22:17 ` pinskia at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-11-09 2:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107363
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:
https://gcc.gnu.org/g:b305793b985f4d3e0032b04d446b8baabcb3e8b7
commit r13-3822-gb305793b985f4d3e0032b04d446b8baabcb3e8b7
Author: Marek Polacek <polacek@redhat.com>
Date: Fri Oct 28 13:39:40 2022 -0400
c++: Tweaks for -Wredundant-move [PR107363]
Two things here:
1) when we're pointing out that std::move on a constant object is
redundant, don't say "in return statement" when we aren't in a
return statement;
2) suppress the warning when the std::move call was dependent, because
removing the std::move may not be correct for a different
instantiation of the original template.
PR c++/107363
gcc/cp/ChangeLog:
* semantics.cc (finish_call_expr): Suppress OPT_Wpessimizing_move.
* typeck.cc (maybe_warn_pessimizing_move): Check
warn_redundant_move
and warning_suppressed_p. Adjust a message depending on return_p.
(check_return_expr): Don't suppress OPT_Wpessimizing_move here.
gcc/testsuite/ChangeLog:
* g++.dg/cpp0x/Wredundant-move13.C: New test.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/107363] Wrong caret location for "redundant move in return statement" and nvo
2022-10-23 9:43 [Bug c++/107363] New: Wrong caret location for "redundant move in return statement" dani at danielbertalan dot dev
` (2 preceding siblings ...)
2022-11-09 2:37 ` cvs-commit at gcc dot gnu.org
@ 2022-11-09 2:52 ` mpolacek at gcc dot gnu.org
2022-11-28 22:17 ` pinskia at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2022-11-09 2:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107363
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/107363] Wrong caret location for "redundant move in return statement" and nvo
2022-10-23 9:43 [Bug c++/107363] New: Wrong caret location for "redundant move in return statement" dani at danielbertalan dot dev
` (3 preceding siblings ...)
2022-11-09 2:52 ` mpolacek at gcc dot gnu.org
@ 2022-11-28 22:17 ` pinskia at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-28 22:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107363
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |13.0
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-28 22:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-23 9:43 [Bug c++/107363] New: Wrong caret location for "redundant move in return statement" dani at danielbertalan dot dev
2022-10-23 15:52 ` [Bug c++/107363] Wrong caret location for "redundant move in return statement" and nvo pinskia at gcc dot gnu.org
2022-10-24 16:34 ` mpolacek at gcc dot gnu.org
2022-11-09 2:37 ` cvs-commit at gcc dot gnu.org
2022-11-09 2:52 ` mpolacek at gcc dot gnu.org
2022-11-28 22:17 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).