[Bug fortran/107397] New: [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[Bug fortran/107397] New: [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

            Bug ID: 107397
           Summary: [10/11/12/13 Regression] ICE in gfc_arith_plus, at
                    fortran/arith.cc:654
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to r10, r9 gives an error.
Started between 20190630 and 20190728.


$ cat z1.f90
program p
   type t
      real :: a = 1.0
   end type
   type(t), parameter :: x = z'1'
   x%a = x%a + 2
   x%a = x%a - 2
   x%a = x%a * 2
   x%a = x%a / 2
   x%a = x%a ** 2
end


$ gfortran-13-20221023 -c z1.f90
f951: internal compiler error: Segmentation fault
0xf43b3f crash_signal
        ../../gcc/toplev.cc:314
0x7c25fb gfc_arith_plus
        ../../gcc/fortran/arith.cc:654
0x7c0ee3 reduce_binary
        ../../gcc/fortran/arith.cc:1514
0x7c1352 eval_intrinsic
        ../../gcc/fortran/arith.cc:1701
0x83418c match_level_2
        ../../gcc/fortran/matchexp.cc:524
0x8342c2 match_level_3
        ../../gcc/fortran/matchexp.cc:551
0x8343b4 match_level_4
        ../../gcc/fortran/matchexp.cc:599
0x8343b4 match_and_operand
        ../../gcc/fortran/matchexp.cc:693
0x8345a2 match_or_operand
        ../../gcc/fortran/matchexp.cc:722
0x834672 match_equiv_operand
        ../../gcc/fortran/matchexp.cc:765
0x834744 match_level_5
        ../../gcc/fortran/matchexp.cc:811
0x833b11 gfc_match_expr(gfc_expr**)
        ../../gcc/fortran/matchexp.cc:870
0x82b0f0 gfc_match(char const*, ...)
        ../../gcc/fortran/match.cc:1131
0x82ceb9 gfc_match_assignment()
        ../../gcc/fortran/match.cc:1330
0x858310 match_word
        ../../gcc/fortran/parse.cc:67
0x858310 decode_statement
        ../../gcc/fortran/parse.cc:363
0x859e0a next_free
        ../../gcc/fortran/parse.cc:1402
0x859e0a next_statement
        ../../gcc/fortran/parse.cc:1634
0x85b84b parse_spec
        ../../gcc/fortran/parse.cc:4190
0x85ea5c parse_progunit
        ../../gcc/fortran/parse.cc:6237

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-10-25

--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.

Slightly reduced testcase (w/o assignment):

program p
  type t
     real :: a = 1.0
  end type
  type(t), parameter :: x = z'1'
  print *, x%a + 2
! print *, x%a
end

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
All releases I have (4.9.0) are affected by the crash.

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #3 from kargl at gcc dot gnu.org ---
Interesting bug.  The BOZ on the rhs is eventually rejected,
but if any error/warning that might be queued is lost during
a pass through  add_init_expr_to_sym().  Eventually, the rhs
expr is freed and the pointer to the initializer is wrong.

This patch fixes the ICE and issues an error.  It has passed
regression testing.

diff --git a/gcc/fortran/decl.cc b/gcc/fortran/decl.cc
index 0f9b2ced4c2..1562dc22bc6 100644
--- a/gcc/fortran/decl.cc
+++ b/gcc/fortran/decl.cc
@@ -2221,6 +2221,14 @@ add_init_expr_to_sym (const char *name, gfc_expr
**initp, locus *var_locus)
            sym->ts.f90_type = init->ts.f90_type;
        }

+      /* Catch the case:  type(t), parameter :: x = z'1'.  */
+      if (sym->ts.type == BT_DERIVED && init->ts.type == BT_BOZ)
+       {
+         gfc_error ("Entity %qs at %L is incompatible with a BOZ "
+                    "literal constant", name, &sym->declared_at);
+         return false;
+       }
+
       /* Add initializer.  Make sure we keep the ranks sane.  */
       if (sym->attr.dimension && init->rank == 0)
        {

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.5

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #4 from anlauf at gcc dot gnu.org ---
(In reply to kargl from comment #3)
> This patch fixes the ICE and issues an error.  It has passed
> regression testing.

Great!

Do you plan to submit your patch?  (Hint: git gcc-commit-mklog).

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #5 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Fri, Oct 28, 2022 at 08:31:58PM +0000, anlauf at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397
> 
> --- Comment #4 from anlauf at gcc dot gnu.org ---
> (In reply to kargl from comment #3)
> > This patch fixes the ICE and issues an error.  It has passed
> > regression testing.
> 
> Great!
> 
> Do you plan to submit your patch?  (Hint: git gcc-commit-mklog).
> 

No.  I have no idea how to add a testcase to git.
Every time I've tried, I end up deleting my git 
repository and grabbing a new clone.  Not a pleasant
developer experience.

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #6 from anlauf at gcc dot gnu.org ---
(In reply to Steve Kargl from comment #5)
> No.  I have no idea how to add a testcase to git.
> Every time I've tried, I end up deleting my git 
> repository and grabbing a new clone.  Not a pleasant
> developer experience.

The workflow with git is really simple:

git add path/to/file
...
git commit

(git gcc-commit-mklog is a tailored version for working with the gcc repo.)

To create a patch for submitting,

git format-patch -1

(if you don't need fancy stuff like a patch series...)

With "git rebase" you can do really many useful things you would never dream
of with svn.

It's also easy to remove a commit from your local worktree or reorder commits
(using rebase), or resetting your worktree, ...

I really think you just need a good primer.

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #7 from anlauf at gcc dot gnu.org ---
Created attachment 53789
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53789&action=edit
Formatted patch

Here's the commands to generate the attached formatted patch,
assuming that decl.cc was clean before your fix:

git add gcc/fortran/decl.cc
git add gcc/testsuite/gfortran.dg/pr107397.f90

git diff --cached # to verify that you added what you wanted

git gcc-commit-mklog # you then edit the commit message ...

(afterwards I fixed the authorship of the commit using
"git commit --amend --author=kargl@...")

git format-patch -1 # this produces the attached file

Just try it yourself.  I leave it to you to submit the patch for review.

If you want to remove the commit (as long as it is not pushed), invoke:

git rebase --interactive

where you can select individual commits for deletion.

If you have multiple changes in a file and want to select a subset,
see "git help add" and look in particular at the option "-i".

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jerry DeLisle <jvdelisle@gcc.gnu.org>:

https://gcc.gnu.org/g:09710f9934969dcb07131e1ed78b72e648123a3a

commit r13-4764-g09710f9934969dcb07131e1ed78b72e648123a3a
Author: Steve Kargl <kargl@gcc.gnu.org>
Date:   Sat Dec 17 19:15:43 2022 -0800

    Add a check for invalid use of BOZ with a derived type.

            PR fortran/107397

    gcc/fortran/ChangeLog:

            * decl.cc (add_init_expr_to_sym): Add check with new error message.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/pr107397.f90: New test.

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[rimvydas.jas at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

Rimvydas (RJ) <rimvydas.jas at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rimvydas.jas at gmail dot com

--- Comment #9 from Rimvydas (RJ) <rimvydas.jas at gmail dot com> ---
Newly added testcase has few typos in dg-error directives and results in
testsuite failures (fixes are trivial):

Running target unix
FAIL: gfortran.dg/pr107397.f90   -O   (test for errors, line 7)
FAIL: gfortran.dg/pr107397.f90   -O  (test for excess errors)

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[rimvydas.jas at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #10 from Rimvydas (RJ) <rimvydas.jas at gmail dot com> ---
Created attachment 54121
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54121&action=edit
testcase fix

[Bug fortran/107397] [10/11/12/13 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:03fb35f8753d87148b29b3f34b6154abe7db4c41

commit r13-4775-g03fb35f8753d87148b29b3f34b6154abe7db4c41
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Dec 19 11:24:55 2022 +0100

    testsuite: Fix up pr107397.f90 test [PR107397]

    The pr107397.f90 test FAILs for me, one problem was that the
    added diagnostics has an indefinite article before BOZ, but
    the test dg-error didn't.  The other problem was that on the
    other dg-error there was no space between the string and closing
    }, so it was completely ignored and the error was an excess
    error.

    2022-12-19  Jakub Jelinek  <jakub@redhat.com>

            PR fortran/107397
            * gfortran.dg/pr107397.f90: Adjust expected diagnostic wording and
            add space between dg-error string and closing }.

[Bug fortran/107397] [10/11/12 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Summary|[10/11/12/13 Regression]    |[10/11/12 Regression] ICE
                   |ICE in gfc_arith_plus, at   |in gfc_arith_plus, at
                   |fortran/arith.cc:654        |fortran/arith.cc:654
           Assignee|unassigned at gcc dot gnu.org      |jvdelisle at gcc dot gnu.org

--- Comment #12 from anlauf at gcc dot gnu.org ---
Since mainline is fixed, adjusting summary.

Assigning to you, Jerry, for potential backports...

[Bug fortran/107397] [11/12 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.

[Bug fortran/107397] [11/12 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #14 from anlauf at gcc dot gnu.org ---
This PR is half a zombie.

Jerry, do you plan to backport the fixes in comment#8 and comment#11 so that
we can finally close this one?

[Bug fortran/107397] [11/12 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #15 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Working this now.

[Bug fortran/107397] [11/12 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jerry DeLisle
<jvdelisle@gcc.gnu.org>:

https://gcc.gnu.org/g:495332f16df1f73c185a02be428e227e20850752

commit r12-9801-g495332f16df1f73c185a02be428e227e20850752
Author: Steve Kargl <kargl@gcc.gnu.org>
Date:   Sat Dec 17 19:15:43 2022 -0800

    Add a check for invalid use of BOZ with a derived type.

            PR fortran/107397

    gcc/fortran/ChangeLog:

            * decl.cc (add_init_expr_to_sym): Add check with new error message.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/pr107397.f90: New test.

    (cherry picked from commit 09710f9934969dcb07131e1ed78b72e648123a3a)

[Bug fortran/107397] [11/12 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jerry DeLisle
<jvdelisle@gcc.gnu.org>:

https://gcc.gnu.org/g:a3931bf6093dbeda637601da07cdbbd07e57ccbd

commit r12-9802-ga3931bf6093dbeda637601da07cdbbd07e57ccbd
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Dec 19 11:24:55 2022 +0100

    testsuite: Fix up pr107397.f90 test [PR107397]

    The pr107397.f90 test FAILs for me, one problem was that the
    added diagnostics has an indefinite article before BOZ, but
    the test dg-error didn't.  The other problem was that on the
    other dg-error there was no space between the string and closing
    }, so it was completely ignored and the error was an excess
    error.

    2022-12-19  Jakub Jelinek  <jakub@redhat.com>

            PR fortran/107397
            * gfortran.dg/pr107397.f90: Adjust expected diagnostic wording and
            add space between dg-error string and closing }.

    (cherry picked from commit 03fb35f8753d87148b29b3f34b6154abe7db4c41)

[Bug fortran/107397] [11/12 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #18 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jerry DeLisle
<jvdelisle@gcc.gnu.org>:

https://gcc.gnu.org/g:276288556d6b4f535466ddbe560ede4c71b7fd2e

commit r11-10938-g276288556d6b4f535466ddbe560ede4c71b7fd2e
Author: Steve Kargl <kargl@gcc.gnu.org>
Date:   Sat Dec 17 19:15:43 2022 -0800

    Add a check for invalid use of BOZ with a derived type.

            PR fortran/107397

    gcc/fortran/ChangeLog:

            * decl.c (add_init_expr_to_sym): Add check with new error message.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/pr107397.f90: New test.

    (cherry picked from commit 09710f9934969dcb07131e1ed78b72e648123a3a)

[Bug fortran/107397] [11/12 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

--- Comment #19 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jerry DeLisle
<jvdelisle@gcc.gnu.org>:

https://gcc.gnu.org/g:088d907f69901f8d7e40ea099ccb5e42999c472c

commit r11-10939-g088d907f69901f8d7e40ea099ccb5e42999c472c
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Dec 19 11:24:55 2022 +0100

    testsuite: Fix up pr107397.f90 test [PR107397]

    The pr107397.f90 test FAILs for me, one problem was that the
    added diagnostics has an indefinite article before BOZ, but
    the test dg-error didn't.  The other problem was that on the
    other dg-error there was no space between the string and closing
    }, so it was completely ignored and the error was an excess
    error.

    2022-12-19  Jakub Jelinek  <jakub@redhat.com>

            PR fortran/107397
            * gfortran.dg/pr107397.f90: Adjust expected diagnostic wording and
            add space between dg-error string and closing }.

    (cherry picked from commit 03fb35f8753d87148b29b3f34b6154abe7db4c41)

[Bug fortran/107397] [11/12 Regression] ICE in gfc_arith_plus, at fortran/arith.cc:654

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107397

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #20 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Backports to 11 and 12 branches complete. Closing.