[Bug tree-optimization/107497] New: [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[Bug tree-optimization/107497] New: [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

            Bug ID: 107497
           Summary: [13 regression] ICE during bootstrap after
                    r13-3595-g7b1cdca6d6d594
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:7b1cdca6d6d594a8a9d88062252212e145f2f4eb, r13-3595-g7b1cdca6d6d594

This happens during stage 2 of a bootstrap build.

libtool: compile: 
/home/seurer/gcc/git/build/gcc-trunk-bootstrap/./prev-gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-trunk-bootstrap/./prev-gcc/
-B/home/seurer/gcc/git/install/gcc-trunk-bootstrap/powerpc64le-unknown-linux-gnu/bin/
-B/home/seurer/gcc/git/install/gcc-trunk-bootstrap/powerpc64le-unknown-linux-gnu/bin/
-B/home/seurer/gcc/git/install/gcc-trunk-bootstrap/powerpc64le-unknown-linux-gnu/lib/
-isystem
/home/seurer/gcc/git/install/gcc-trunk-bootstrap/powerpc64le-unknown-linux-gnu/include
-isystem
/home/seurer/gcc/git/install/gcc-trunk-bootstrap/powerpc64le-unknown-linux-gnu/sys-include
-fno-checking -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DLT_OBJDIR=\".libs/\"
-DHAVE_LITTLE_ENDIAN=1 -DHAVE_CLOCK_GETTIME=1 -DTIME_WITH_SYS_TIME=1
-DHAVE_LOCALE_H=1 -DHAVE_WCHAR_H=1 -DHAVE_STDARG=1 -DHAVE_SYS_TIME_H=1
-DHAVE_STRUCT_LCONV_DECIMAL_POINT=1 -DHAVE_STRUCT_LCONV_THOUSANDS_SEP=1
-DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -DHAVE_UINTPTR_T=1 -DHAVE_VA_COPY=1
-DHAVE_SETLOCALE=1 -DHAVE_GETTIMEOFDAY=1 -DHAVE_SIGNAL=1 -DHAVE_SIGACTION=1
-DHAVE_LONG_LONG=1 -DHAVE_INTMAX_T=1 -DMPFR_HAVE_INTMAX_MAX=1
-DMPFR_HAVE_NORETURN=1 -DMPFR_HAVE_BUILTIN_UNREACHABLE=1
-DMPFR_HAVE_CONSTRUCTOR_ATTR=1 -DMPFR_HAVE_FESETROUND=1 -DHAVE_SUBNORM_DBL=1
-DHAVE_SUBNORM_FLT=1 -DHAVE_SIGNEDZ=1 -DHAVE_ROUND=1 -DHAVE_TRUNC=1
-DHAVE_FLOOR=1 -DHAVE_CEIL=1 -DHAVE_NEARBYINT=1
-DHAVE_DOUBLE_IEEE_LITTLE_ENDIAN=1 -DHAVE_LDOUBLE_MAYBE_DOUBLE_DOUBLE=1
-DMPFR_USE_THREAD_SAFE=1 -DMPFR_USE_C11_THREAD_SAFE=1
-DMPFR_WANT_DECIMAL_FLOATS=1 -DDECIMAL_DPD_FORMAT=1 -DMPFR_WANT_FLOAT128=1
-DMPFR_USE_STATIC_ASSERT=1 -DHAVE_ATTRIBUTE_MODE=1 -DPRINTF_L=1 -DPRINTF_T=1
-DPRINTF_GROUPFLAG=1 -DHAVE___GMPN_SBPI1_DIVAPPR_Q=1 -DMPFR_LONG_WITHIN_LIMB=1
-DMPFR_INTMAX_WITHIN_LIMB=1 -DHAVE_GETRUSAGE=1 -I.
-I/home/seurer/gcc/git/gcc-trunk-bootstrap/mpfr/src
-I/home/seurer/gcc/git/build/gcc-trunk-bootstrap/gmp -DNO_ASM -g -O2
-fno-checking -gtoggle -MT rec_sqrt.lo -MD -MP -MF .deps/rec_sqrt.Tpo -c
/home/seurer/gcc/git/gcc-trunk-bootstrap/mpfr/src/rec_sqrt.c -o rec_sqrt.o
during GIMPLE pass: vrp
/home/seurer/gcc/git/gcc-trunk-bootstrap/mpfr/src/rec_sqrt.c: In function
'mpfr_mpn_rec_sqrt':
/home/seurer/gcc/git/gcc-trunk-bootstrap/mpfr/src/rec_sqrt.c:73:1: internal
compiler error: Segmentation fault
   73 | mpfr_mpn_rec_sqrt (mpfr_limb_ptr x, mpfr_prec_t p,
      | ^~~~~~~~~~~~~~~~~
0x113d0df7 crash_signal
        /home/seurer/gcc/git/gcc-trunk-bootstrap/gcc/toplev.cc:314
0x106c3994 tree_check(tree_node*, char const*, int, char const*, tree_code)
        /home/seurer/gcc/git/gcc-trunk-bootstrap/gcc/tree.h:3531
0x11978937 remove_unreachable::remove_and_update_globals(bool)
        /home/seurer/gcc/git/gcc-trunk-bootstrap/gcc/tree-vrp.cc:183
0x11989d8f execute_ranger_vrp(function*, bool, bool)
        /home/seurer/gcc/git/gcc-trunk-bootstrap/gcc/tree-vrp.cc:4536
0x1198a2a3 execute
        /home/seurer/gcc/git/gcc-trunk-bootstrap/gcc/tree-vrp.cc:4619


commit 7b1cdca6d6d594a8a9d88062252212e145f2f4eb (HEAD)
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Mon Oct 31 15:18:00 2022 -0400

    Remove builtin_unreachable in VRP

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0
           Keywords|                            |build

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-11-01
               Host|powerpc64-linux-gnu,        |powerpc64-linux-gnu,
                   |powerpc64le-linux-gnu       |powerpc64le-linux-gnu
                   |                            |x86_64-linux-gnu
             Target|powerpc64-linux-gnu,        |powerpc64-linux-gnu,
                   |powerpc64le-linux-gnu       |powerpc64le-linux-gnu
                   |                            |x86_64-linux-gnu
     Ever confirmed|0                           |1
              Build|powerpc64-linux-gnu,        |powerpc64-linux-gnu,
                   |powerpc64le-linux-gnu       |powerpc64le-linux-gnu
                   |                            |x86_64-linux-gnu
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Looks like it also fails on x86_64:
https://gcc.gnu.org/pipermail/gcc-testresults/2022-November/771026.html

https://gcc.gnu.org/pipermail/gcc-testresults/2022-November/771027.html

I suspect building with mpfr/mpc/gmp in the source tree is definitely a good
test of the compiler, especially with floating point too :).

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

--- Comment #2 from seurer at gcc dot gnu.org ---
Because of past issues I always use contrib/download_prerequisites

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Just hit this problem as well.

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |amacleod at redhat dot com

--- Comment #4 from Andrew Macleod <amacleod at redhat dot com> ---
Created attachment 53815
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53815&action=edit
patch in testing

Looks like an ssa-name was released between the start and finish of the pass,
probably should have had this check to start with.

Bootstrapping  now.

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:82b0345f6137b112728590d7c010dcd2cef08514

commit r13-3597-g82b0345f6137b112728590d7c010dcd2cef08514
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Tue Nov 1 13:18:33 2022 -0400

    Make sure ssa-name is valid.

            PR tree-optimization/107497
            * tree-vrp.cc (remove_unreachable::remove_and_update_globals):
            Check that ssa-name still exists before accessing it.

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[i.nixman at autistici dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

--- Comment #6 from niXman <i.nixman at autistici dot org> ---
just now faced with the bug as well on x86_64-w64-mingw32 target.

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

--- Comment #7 from Andrew Macleod <amacleod at redhat dot com> ---
(In reply to niXman from comment #6)
> just now faced with the bug as well on x86_64-w64-mingw32 target.

Does the committed patch not fix it?

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[i.nixman at autistici dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

--- Comment #8 from niXman <i.nixman at autistici dot org> ---
(In reply to Andrew Macleod from comment #7)
> (In reply to niXman from comment #6)
> > just now faced with the bug as well on x86_64-w64-mingw32 target.
> 
> Does the committed patch not fix it?

checking...

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

--- Comment #9 from seurer at gcc dot gnu.org ---
The patch works for powerpc64.  Thanks!

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[i.nixman at autistici dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

--- Comment #10 from niXman <i.nixman at autistici dot org> ---
(In reply to Andrew Macleod from comment #7)
> (In reply to niXman from comment #6)
> > just now faced with the bug as well on x86_64-w64-mingw32 target.
> 
> Does the committed patch not fix it?

fixed! thanks!

[Bug tree-optimization/107497] [13 regression] ICE during bootstrap after r13-3595-g7b1cdca6d6d594

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107497

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I think this is now fixed for everyone so closing as such.