public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/107562] [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE
Date: Mon, 07 Nov 2022 23:36:31 +0000	[thread overview]
Message-ID: <bug-107562-4-WL4SOak5m4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107562-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107562

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b457b779427b0f7b3fbac447811c9c52db5bc79e

commit r13-3763-gb457b779427b0f7b3fbac447811c9c52db5bc79e
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Nov 8 00:35:09 2022 +0100

    libstdc++: Fix up libstdc++ build against glibc 2.25 or older [PR107562]

    On Mon, Nov 07, 2022 at 05:48:42PM +0000, Jonathan Wakely wrote:
    > On Mon, 7 Nov 2022 at 16:11, Joseph Myers <joseph@codesourcery.com>
wrote:
    > >
    > > On Wed, 2 Nov 2022, Jakub Jelinek via Gcc-patches wrote:
    > >
    > > > APIs.  So that one can build gcc against older glibc and then compile
    > > > user programs on newer glibc, the patch uses weak references unless
    > > > gcc is compiled against glibc 2.26+.  strfromf128 unfortunately can't
    > >
    > > This support for older glibc doesn't actually seem to be working, on an
    > > older system with glibc 2.19 I'm seeing
    > >
    > >
/scratch/jmyers/fsf/gcc-mainline/libstdc++-v3/src/c++17/floating_to_chars.cc:52:3:
error: expected initializer before '__asm'
    > >    52 |   __asm ("strfromf128");
    > >       |   ^~~~~
    > >
    > > and a series of subsequent errors.
    >
    > This seems to "fix" it (not sure if it's right though):
    >
    > #ifndef _GLIBCXX_HAVE_FLOAT128_MATH
    > extern "C" _Float128 __strtof128(const char*, char**)
    >  __attribute__((__weak__));
    > #endif
    > extern "C" _Float128 __strtof128(const char*, char**)
    >  __asm ("strtof128");

    It is, but floating_from_chars.cc has the same problem,
    and I think we can avoid the duplication, like this:

    2022-11-08  Jakub Jelinek  <jakub@redhat.com>

            PR libstdc++/107562
            * src/c++17/floating_from_chars.cc (__strtof128): Put __asm before
            __attribute__.
            * src/c++17/floating_to_chars.cc (__strfromf128): Likewise.

  parent reply	other threads:[~2022-11-07 23:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07 22:50 [Bug libstdc++/107562] New: " seurer at gcc dot gnu.org
2022-11-07 23:00 ` [Bug libstdc++/107562] " pinskia at gcc dot gnu.org
2022-11-07 23:00 ` pinskia at gcc dot gnu.org
2022-11-07 23:36 ` cvs-commit at gcc dot gnu.org [this message]
2022-11-08  1:41 ` cvs-commit at gcc dot gnu.org
2022-11-08  9:35 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107562-4-WL4SOak5m4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).