public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/107562] New: [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE
@ 2022-11-07 22:50 seurer at gcc dot gnu.org
2022-11-07 23:00 ` [Bug libstdc++/107562] " pinskia at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: seurer at gcc dot gnu.org @ 2022-11-07 22:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107562
Bug ID: 107562
Summary: [13 regression] r13-3761-ga239a63f868e29 breaks build
on powerpc64 BE
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: seurer at gcc dot gnu.org
Target Milestone: ---
g:a239a63f868e29e9276088e7c0fb00804c2903ba, r13-3761-ga239a63f868e29
This breaks the build on powerpc64 BE. Just a simple build, not even
bootstrap.
make[5]: Entering directory
`/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/src/c++17'
/bin/sh ../../libtool --tag CXX --tag disable-shared --mode=compile
/home/seurer/gcc/git/build/gcc-test/./gcc/xgcc -shared-libgcc
-B/home/seurer/gcc/git/build/gcc-test/./gcc -nostdinc++
-L/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/src
-L/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/src/.libs
-L/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-B/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/bin/
-B/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/lib/
-isystem
/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/include
-isystem
/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/sys-include
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/../libgcc
-I/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/include/powerpc64-unknown-linux-gnu
-I/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/include
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/libsupc++ -std=gnu++17
-nostdinc++ -prefer-pic -D_GLIBCXX_SHARED -fno-implicit-templates -Wall
-Wextra -Wwrite-strings -Wcast-qual -Wabi=2 -fdiagnostics-show-location=once
-ffunction-sections -fdata-sections -frandom-seed=floating_from_chars.lo
-fimplicit-templates -g -O2 -D_GNU_SOURCE -c -o floating_from_chars.lo
/home/seurer/gcc/git/gcc-test/libstdc++-v3/src/c++17/floating_from_chars.cc
libtool: compile: /home/seurer/gcc/git/build/gcc-test/./gcc/xgcc
-shared-libgcc -B/home/seurer/gcc/git/build/gcc-test/./gcc -nostdinc++
-L/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/src
-L/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/src/.libs
-L/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-B/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/bin/
-B/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/lib/
-isystem
/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/include
-isystem
/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/sys-include
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/../libgcc
-I/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/include/powerpc64-unknown-linux-gnu
-I/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/include
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/libsupc++ -std=gnu++17 -nostdinc++
-D_GLIBCXX_SHARED -fno-implicit-templates -Wall -Wextra -Wwrite-strings
-Wcast-qual -Wabi=2 -fdiagnostics-show-location=once -ffunction-sections
-fdata-sections -frandom-seed=floating_from_chars.lo -fimplicit-templates -g
-O2 -D_GNU_SOURCE -c
/home/seurer/gcc/git/gcc-test/libstdc++-v3/src/c++17/floating_from_chars.cc
-fPIC -DPIC -D_GLIBCXX_SHARED -o floating_from_chars.o
/home/seurer/gcc/git/gcc-test/libstdc++-v3/src/c++17/floating_from_chars.cc:69:3:
error: expected initializer before '__asm'
69 | __asm ("strtof128");
| ^~~~~
/home/seurer/gcc/git/gcc-test/libstdc++-v3/src/c++17/floating_from_chars.cc: In
function 'std::ptrdiff_t std::{anonymous}::from_chars_impl(const char*, T&,
std::errc&)':
/home/seurer/gcc/git/gcc-test/libstdc++-v3/src/c++17/floating_from_chars.cc:633:18:
error: '__strtof128' was not declared in this scope
633 | if (&__strtof128 == nullptr)
| ^~~~~~~~~~~
/home/seurer/gcc/git/gcc-test/libstdc++-v3/src/c++17/floating_from_chars.cc:634:24:
error: expected primary-expression before '_Float128'
634 | tmpval = _Float128(std::strtold(str, &endptr);
| ^~~~~~~~~
make[5]: *** [floating_from_chars.lo] Error 1
commit e5bcbcd04cfcb2f8635ea8431f4e77065e44b0bd
Author: Jakub Jelinek <jakub@redhat.com>
Date: Mon Nov 7 15:15:50 2022 +0100
libstdc++: Add _Float128 to_chars/from_chars support for x86, ia64 and
ppc64le with glibc
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/107562] [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE
2022-11-07 22:50 [Bug libstdc++/107562] New: [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE seurer at gcc dot gnu.org
@ 2022-11-07 23:00 ` pinskia at gcc dot gnu.org
2022-11-07 23:00 ` pinskia at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-07 23:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107562
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605247.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/107562] [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE
2022-11-07 22:50 [Bug libstdc++/107562] New: [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE seurer at gcc dot gnu.org
2022-11-07 23:00 ` [Bug libstdc++/107562] " pinskia at gcc dot gnu.org
@ 2022-11-07 23:00 ` pinskia at gcc dot gnu.org
2022-11-07 23:36 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-07 23:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107562
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
That is:
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605251.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/107562] [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE
2022-11-07 22:50 [Bug libstdc++/107562] New: [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE seurer at gcc dot gnu.org
2022-11-07 23:00 ` [Bug libstdc++/107562] " pinskia at gcc dot gnu.org
2022-11-07 23:00 ` pinskia at gcc dot gnu.org
@ 2022-11-07 23:36 ` cvs-commit at gcc dot gnu.org
2022-11-08 1:41 ` cvs-commit at gcc dot gnu.org
2022-11-08 9:35 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-11-07 23:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107562
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:b457b779427b0f7b3fbac447811c9c52db5bc79e
commit r13-3763-gb457b779427b0f7b3fbac447811c9c52db5bc79e
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Nov 8 00:35:09 2022 +0100
libstdc++: Fix up libstdc++ build against glibc 2.25 or older [PR107562]
On Mon, Nov 07, 2022 at 05:48:42PM +0000, Jonathan Wakely wrote:
> On Mon, 7 Nov 2022 at 16:11, Joseph Myers <joseph@codesourcery.com>
wrote:
> >
> > On Wed, 2 Nov 2022, Jakub Jelinek via Gcc-patches wrote:
> >
> > > APIs. So that one can build gcc against older glibc and then compile
> > > user programs on newer glibc, the patch uses weak references unless
> > > gcc is compiled against glibc 2.26+. strfromf128 unfortunately can't
> >
> > This support for older glibc doesn't actually seem to be working, on an
> > older system with glibc 2.19 I'm seeing
> >
> >
/scratch/jmyers/fsf/gcc-mainline/libstdc++-v3/src/c++17/floating_to_chars.cc:52:3:
error: expected initializer before '__asm'
> > 52 | __asm ("strfromf128");
> > | ^~~~~
> >
> > and a series of subsequent errors.
>
> This seems to "fix" it (not sure if it's right though):
>
> #ifndef _GLIBCXX_HAVE_FLOAT128_MATH
> extern "C" _Float128 __strtof128(const char*, char**)
> __attribute__((__weak__));
> #endif
> extern "C" _Float128 __strtof128(const char*, char**)
> __asm ("strtof128");
It is, but floating_from_chars.cc has the same problem,
and I think we can avoid the duplication, like this:
2022-11-08 Jakub Jelinek <jakub@redhat.com>
PR libstdc++/107562
* src/c++17/floating_from_chars.cc (__strtof128): Put __asm before
__attribute__.
* src/c++17/floating_to_chars.cc (__strfromf128): Likewise.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/107562] [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE
2022-11-07 22:50 [Bug libstdc++/107562] New: [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE seurer at gcc dot gnu.org
` (2 preceding siblings ...)
2022-11-07 23:36 ` cvs-commit at gcc dot gnu.org
@ 2022-11-08 1:41 ` cvs-commit at gcc dot gnu.org
2022-11-08 9:35 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-11-08 1:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107562
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Joseph Myers <jsm28@gcc.gnu.org>:
https://gcc.gnu.org/g:8d0326943ee4eb87309faca28ee0ed13346dd70a
commit r13-3767-g8d0326943ee4eb87309faca28ee0ed13346dd70a
Author: Joseph Myers <joseph@codesourcery.com>
Date: Tue Nov 8 01:39:52 2022 +0000
libstdc++: Fix syntax error in old-glibc case in floating_from_chars.cc
[PR107562]
PR libstdc++/107562
* src/c++17/floating_from_chars.cc (from_chars_impl): Fix syntax
error.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/107562] [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE
2022-11-07 22:50 [Bug libstdc++/107562] New: [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE seurer at gcc dot gnu.org
` (3 preceding siblings ...)
2022-11-08 1:41 ` cvs-commit at gcc dot gnu.org
@ 2022-11-08 9:35 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-11-08 9:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107562
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |build
Target Milestone|--- |13.0
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-08 9:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 22:50 [Bug libstdc++/107562] New: [13 regression] r13-3761-ga239a63f868e29 breaks build on powerpc64 BE seurer at gcc dot gnu.org
2022-11-07 23:00 ` [Bug libstdc++/107562] " pinskia at gcc dot gnu.org
2022-11-07 23:00 ` pinskia at gcc dot gnu.org
2022-11-07 23:36 ` cvs-commit at gcc dot gnu.org
2022-11-08 1:41 ` cvs-commit at gcc dot gnu.org
2022-11-08 9:35 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).