public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "aldyh at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107569] [13 Regression] Failure to optimize std::isfinite since r13-3596
Date: Thu, 10 Nov 2022 17:50:12 +0000	[thread overview]
Message-ID: <bug-107569-4-TkAasZXXb7@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107569-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107569

--- Comment #32 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #31)
> Created attachment 53873 [details]
> gcc13-pr107569-div.patch
> 
> This is what I meant by complete nightmare - division.

Ugh, yeah.  That's pretty bad.  (Not your code, the inevitable special casing.)

Could you abstract out functionality into short inline functions to make it
more readable?  If it's too much hassle, or doesn't improve readability then
don't... after all, it's all compartmentalized in a function in
range-ops..which is the whole points of range-ops, being able to sand box all
this knowledge.

Out of curiosity, why is it so much more complex than the integer versions
which share a lot of code?

  parent reply	other threads:[~2022-11-10 17:50 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 12:09 [Bug tree-optimization/107569] New: " jakub at gcc dot gnu.org
2022-11-08 12:09 ` [Bug tree-optimization/107569] " jakub at gcc dot gnu.org
2022-11-08 12:59 ` pilarlatiesa at gmail dot com
2022-11-08 13:30 ` rguenth at gcc dot gnu.org
2022-11-08 13:34 ` jakub at gcc dot gnu.org
2022-11-08 14:46 ` amacleod at redhat dot com
2022-11-08 14:53 ` jakub at gcc dot gnu.org
2022-11-08 15:14 ` amacleod at redhat dot com
2022-11-08 15:34 ` jakub at gcc dot gnu.org
2022-11-08 15:53 ` amacleod at redhat dot com
2022-11-08 15:55 ` jakub at gcc dot gnu.org
2022-11-08 16:00 ` jakub at gcc dot gnu.org
2022-11-08 17:25 ` jakub at gcc dot gnu.org
2022-11-09 14:20 ` aldyh at gcc dot gnu.org
2022-11-09 14:27 ` aldyh at gcc dot gnu.org
2022-11-09 14:30 ` aldyh at gcc dot gnu.org
2022-11-09 15:01 ` pilarlatiesa at gmail dot com
2022-11-09 15:10 ` jakub at gcc dot gnu.org
2022-11-09 15:38 ` jakub at gcc dot gnu.org
2022-11-09 17:21 ` cvs-commit at gcc dot gnu.org
2022-11-09 18:21 ` jakub at gcc dot gnu.org
2022-11-10  9:32 ` aldyh at gcc dot gnu.org
2022-11-10  9:36 ` jakub at gcc dot gnu.org
2022-11-10 10:22 ` jakub at gcc dot gnu.org
2022-11-10 10:29 ` jakub at gcc dot gnu.org
2022-11-10 10:40 ` jakub at gcc dot gnu.org
2022-11-10 11:34 ` aldyh at gcc dot gnu.org
2022-11-10 11:34 ` aldyh at gcc dot gnu.org
2022-11-10 12:22 ` jakub at gcc dot gnu.org
2022-11-10 12:47 ` aldyh at gcc dot gnu.org
2022-11-10 12:54 ` jakub at gcc dot gnu.org
2022-11-10 13:19 ` aldyh at gcc dot gnu.org
2022-11-10 13:35 ` aldyh at gcc dot gnu.org
2022-11-10 16:12 ` jakub at gcc dot gnu.org
2022-11-10 17:50 ` aldyh at gcc dot gnu.org [this message]
2022-11-10 19:14 ` aldyh at gcc dot gnu.org
2022-11-10 19:29 ` jakub at gcc dot gnu.org
2022-11-11  7:15 ` aldyh at gcc dot gnu.org
2022-11-12  8:42 ` cvs-commit at gcc dot gnu.org
2022-11-12  8:42 ` cvs-commit at gcc dot gnu.org
2022-11-12  8:43 ` cvs-commit at gcc dot gnu.org
2022-11-30  1:43 ` romain.geissler at amadeus dot com
2022-12-08 16:24 ` jakub at gcc dot gnu.org
2022-12-08 16:32 ` jakub at gcc dot gnu.org
2022-12-08 16:37 ` jakub at gcc dot gnu.org
2022-12-09 15:34 ` amacleod at redhat dot com
2023-02-27 10:07 ` rguenth at gcc dot gnu.org
2023-03-22 15:26 ` jakub at gcc dot gnu.org
2023-03-22 16:07 ` jakub at gcc dot gnu.org
2023-03-23  8:38 ` jakub at gcc dot gnu.org
2023-03-23 13:47 ` rguenth at gcc dot gnu.org
2023-03-23 14:30 ` jakub at gcc dot gnu.org
2023-03-23 16:22 ` cvs-commit at gcc dot gnu.org
2023-03-23 16:22 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107569-4-TkAasZXXb7@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).