[Bug c++/107574] New: [10/11/12/13 Regression] ICE: tree check: expected record_type or union_type or qual_union_type, have integer_type in cp_fold_convert, at cp/cvt.cc:613

[Bug c++/107574] New: [10/11/12/13 Regression] ICE: tree check: expected record_type or union_type or qual_union_type, have integer_type in cp_fold_convert, at cp/cvt.cc:613

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

            Bug ID: 107574
           Summary: [10/11/12/13 Regression] ICE: tree check: expected
                    record_type or union_type or qual_union_type, have
                    integer_type in cp_fold_convert, at cp/cvt.cc:613
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to r9 :


$ cat z1.cc
struct A { int i; };
struct B:A { int j; };
struct C:B { int k; static_assert((int(B::*))&C::k, ""); };


$ g++-13-20221106 -c z1.cc
z1.cc:3:50: internal compiler error: tree check: expected record_type or
union_type or qual_union_type, have integer_type in cp_fold_convert, at
cp/cvt.cc:613
    3 | struct C:B { int k; static_assert((int(B::*))&C::k, ""); };
      |                                                  ^
0x70312c tree_check_failed(tree_node const*, char const*, int, char const*,
...)
        ../../gcc/tree.cc:8846
0x8af521 tree_check3(tree_node*, char const*, int, char const*, tree_code,
tree_code, tree_code)
        ../../gcc/tree.h:3572
0x8af521 cp_fold_convert(tree_node*, tree_node*)
        ../../gcc/cp/cvt.cc:612
0x8666a4 cxx_eval_constant_expression
        ../../gcc/cp/constexpr.cc:7602
0x8708fa cxx_eval_outermost_constant_expr
        ../../gcc/cp/constexpr.cc:8142
0x8757ea maybe_constant_value(tree_node*, tree_node*, bool)
        ../../gcc/cp/constexpr.cc:8412
0x8aa095 cp_fully_fold(tree_node*)
        ../../gcc/cp/cp-gimplify.cc:2370
0xb46c51 cp_build_binary_op(op_location_t const&, tree_code, tree_node*,
tree_node*, int)
        ../../gcc/cp/typeck.cc:6565
0xb4bb63 convert_ptrmem(tree_node*, tree_node*, bool, bool, int)
        ../../gcc/cp/typeck.cc:8171
0xb522f2 cp_build_c_cast(unsigned int, tree_node*, tree_node*, int)
        ../../gcc/cp/typeck.cc:9189
0xb528b1 build_c_cast(unsigned int, tree_node*, cp_expr)
        ../../gcc/cp/typeck.cc:9095
0x9f0682 cp_parser_cast_expression
        ../../gcc/cp/parser.cc:9978
0x9f0ccf cp_parser_binary_expression
        ../../gcc/cp/parser.cc:10091
0x9f1a74 cp_parser_assignment_expression
        ../../gcc/cp/parser.cc:10431
0x9f48a5 cp_parser_constant_expression
        ../../gcc/cp/parser.cc:10726
0x9f504e cp_parser_static_assert
        ../../gcc/cp/parser.cc:16280
0xa39204 cp_parser_member_declaration
        ../../gcc/cp/parser.cc:27068
0xa013b2 cp_parser_member_specification_opt
        ../../gcc/cp/parser.cc:26936
0xa013b2 cp_parser_class_specifier
        ../../gcc/cp/parser.cc:26011
0xa04240 cp_parser_type_specifier
        ../../gcc/cp/parser.cc:19387

[Bug c++/107574] [10/11/12/13 Regression] ICE: tree check: expected record_type or union_type or qual_union_type, have integer_type in cp_fold_convert, at cp/cvt.cc:613

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
   Last reconfirmed|                            |2022-11-08
     Ever confirmed|0                           |1
   Target Milestone|---                         |10.5
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.  Segfaults when checking is disabled.

[Bug c++/107574] [10/11/12/13 Regression] ICE: tree check in cp_fold_convert with ptr to member field cast inside a class not completed and inherent

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[10/11/12/13 Regression]    |[10/11/12/13 Regression]
                   |ICE: tree check: expected   |ICE: tree check in
                   |record_type or union_type   |cp_fold_convert with ptr to
                   |or qual_union_type, have    |member field cast inside a
                   |integer_type in             |class not completed and
                   |cp_fold_convert, at         |inherent
                   |cp/cvt.cc:613               |

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note moving the static_assert outside of the class does not cause a crash.

[Bug c++/107574] [10/11/12/13 Regression] ICE: tree check in cp_fold_convert with ptr to member field cast inside a class not completed and inherent

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |8.1.0
      Known to fail|                            |7.5.0, 9.1.0

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
In GCC 7 and before, GCC rejected the code:
<source>:5:1: error: non-constant condition for static assertion
 static_assert((int(B::*))&C::k, ""); };
 ^~~~~~~~~~~~~
<source>:5:15: error: a reinterpret_cast is not a constant expression
 static_assert((int(B::*))&C::k, ""); };
               ^~~~~~~~~~~~~

[Bug c++/107574] [10/11/12/13 Regression] ICE: tree check in cp_fold_convert with ptr to member field cast inside a class not completed and inherent

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-bisection
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=85437

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Most likely started to accept in GCC 8 by the patch for PR 85437.

[Bug c++/107574] [10/11/12/13 Regression] ICE: tree check in cp_fold_convert with ptr to member field cast inside a class not completed and inherent since r9-50-gd760b06868d660bc

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|needs-bisection             |
                 CC|                            |jason at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
            Summary|[10/11/12/13 Regression]    |[10/11/12/13 Regression]
                   |ICE: tree check in          |ICE: tree check in
                   |cp_fold_convert with ptr to |cp_fold_convert with ptr to
                   |member field cast inside a  |member field cast inside a
                   |class not completed and     |class not completed and
                   |inherent                    |inherent since
                   |                            |r9-50-gd760b06868d660bc

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r9-50-gd760b06868d660bc.

[Bug c++/107574] [10/11/12/13 Regression] ICE: tree check in cp_fold_convert with ptr to member field cast inside a class not completed and inherent since r9-50-gd760b06868d660bc

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Are we sure we want to accept this?  I know we did, but that seems like an
accident (cp_fold_convert wasn't checking same_type_p).

Essentially it comes down to the fact that we're attempting to evaluate a
PTRMEM_CST in a class that hasn't been completed yet, but that doesn't work:

        /* We can't lower this until the class is complete.  */
        if (!COMPLETE_TYPE_P (DECL_CONTEXT (member)))
          return cst;

and then this unlowered PTRMEM_CST is used as EXPR in

    tree op1 = build_nop (ptrdiff_type_node, expr);

and we crash in cp_fold_convert which gets type=ptrdiff_type_node,
expr=PTRMEM_CST and does

  else if (TREE_CODE (expr) == PTRMEM_CST
           && same_type_p (TYPE_PTRMEM_CLASS_TYPE (type),
                           PTRMEM_CST_CLASS (expr)))

where TYPE_PTRMEM_CLASS_TYPE (type) is going to crash.  We could just add a
TYPE_PTRMEM_P check and go back to the GCC 7 error.

[Bug c++/107574] [10/11/12/13 Regression] ICE: tree check in cp_fold_convert with ptr to member field cast inside a class not completed and inherent since r9-50-gd760b06868d660bc

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org

[Bug c++/107574] [10/11/12/13 Regression] ICE: tree check in cp_fold_convert with ptr to member field cast inside a class not completed and inherent since r9-50-gd760b06868d660bc

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:de81e06273c613d7e06cbe2c8d9e72826c638056

commit r13-6400-gde81e06273c613d7e06cbe2c8d9e72826c638056
Author: Marek Polacek <polacek@redhat.com>
Date:   Thu Feb 2 18:15:37 2023 -0500

    c++: can't eval PTRMEM_CST in incomplete class [PR107574]

    Here we're attempting to evaluate a PTRMEM_CST in a class that hasn't
    been completed yet, but that doesn't work:

            /* We can't lower this until the class is complete.  */
            if (!COMPLETE_TYPE_P (DECL_CONTEXT (member)))
              return cst;

    and then this unlowered PTRMEM_CST is used as EXPR in

        tree op1 = build_nop (ptrdiff_type_node, expr);

    and we crash in a subsequent cp_fold_convert which gets
type=ptrdiff_type_node,
    expr=PTRMEM_CST and does

      else if (TREE_CODE (expr) == PTRMEM_CST
               && same_type_p (TYPE_PTRMEM_CLASS_TYPE (type),
                               PTRMEM_CST_CLASS (expr)))

    where TYPE_PTRMEM_CLASS_TYPE (type) is going to crash since the type
    is ptrdiff_type_node.  We could just add a TYPE_PTRMEM_P check before
    accessing TYPE_PTRMEM_CLASS_TYPE but I think it's nicer to explain why
    we couldn't evaluate the expression.

            PR c++/107574

    gcc/cp/ChangeLog:

            * constexpr.cc (cxx_eval_constant_expression): Emit an error when
            a PTRMEM_CST cannot be evaluated.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/ptrmem-cst1.C: New test.

[Bug c++/107574] [10/11/12 Regression] ICE: tree check in cp_fold_convert with ptr to member field cast inside a class not completed and inherent since r9-50-gd760b06868d660bc

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[10/11/12/13 Regression]    |[10/11/12 Regression] ICE:
                   |ICE: tree check in          |tree check in
                   |cp_fold_convert with ptr to |cp_fold_convert with ptr to
                   |member field cast inside a  |member field cast inside a
                   |class not completed and     |class not completed and
                   |inherent since              |inherent since
                   |r9-50-gd760b06868d660bc     |r9-50-gd760b06868d660bc

--- Comment #8 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed on trunk so far.

[Bug c++/107574] [10/11/12 Regression] ICE: tree check in cp_fold_convert with ptr to member field cast inside a class not completed and inherent since r9-50-gd760b06868d660bc

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Marek Polacek
<mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:b7b50918fe52206e188c8c60c60e0d6a516e8572

commit r12-9216-gb7b50918fe52206e188c8c60c60e0d6a516e8572
Author: Marek Polacek <polacek@redhat.com>
Date:   Thu Feb 2 18:15:37 2023 -0500

    c++: can't eval PTRMEM_CST in incomplete class [PR107574]

    Here we're attempting to evaluate a PTRMEM_CST in a class that hasn't
    been completed yet, but that doesn't work:

            /* We can't lower this until the class is complete.  */
            if (!COMPLETE_TYPE_P (DECL_CONTEXT (member)))
              return cst;

    and then this unlowered PTRMEM_CST is used as EXPR in

        tree op1 = build_nop (ptrdiff_type_node, expr);

    and we crash in a subsequent cp_fold_convert which gets
type=ptrdiff_type_node,
    expr=PTRMEM_CST and does

      else if (TREE_CODE (expr) == PTRMEM_CST
               && same_type_p (TYPE_PTRMEM_CLASS_TYPE (type),
                               PTRMEM_CST_CLASS (expr)))

    where TYPE_PTRMEM_CLASS_TYPE (type) is going to crash since the type
    is ptrdiff_type_node.  We could just add a TYPE_PTRMEM_P check before
    accessing TYPE_PTRMEM_CLASS_TYPE but I think it's nicer to explain why
    we couldn't evaluate the expression.

            PR c++/107574

    gcc/cp/ChangeLog:

            * constexpr.cc (cxx_eval_constant_expression): Emit an error when
            a PTRMEM_CST cannot be evaluated.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/ptrmem-cst1.C: New test.

    (cherry picked from commit de81e06273c613d7e06cbe2c8d9e72826c638056)

[Bug c++/107574] [10/11 Regression] ICE: tree check in cp_fold_convert with ptr to member field cast inside a class not completed and inherent since r9-50-gd760b06868d660bc

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107574

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
            Summary|[10/11/12 Regression] ICE:  |[10/11 Regression] ICE:
                   |tree check in               |tree check in
                   |cp_fold_convert with ptr to |cp_fold_convert with ptr to
                   |member field cast inside a  |member field cast inside a
                   |class not completed and     |class not completed and
                   |inherent since              |inherent since
                   |r9-50-gd760b06868d660bc     |r9-50-gd760b06868d660bc

--- Comment #10 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.