public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/107792] New: Output of default contract violation handler could be improved
@ 2022-11-21 11:43 redi at gcc dot gnu.org
2022-11-21 13:40 ` [Bug libstdc++/107792] " redi at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2022-11-21 11:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107792
Bug ID: 107792
Summary: Output of default contract violation handler could be
improved
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Keywords: diagnostic
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: redi at gcc dot gnu.org
Target Milestone: ---
int f(int x) [[pre: x > 0]] [[post r: r > 0]]
{
return -5;
}
int main()
{
f(42);
}
default std::handle_contract_violation called:
fail.cc 1 f r > 0 default default 0
terminate called without an active exception
Aborted (core dumped)
We should label the fields so that "fail.cc 1 f r > 0 default default 0" makes
sense.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/107792] Output of default contract violation handler could be improved
2022-11-21 11:43 [Bug libstdc++/107792] New: Output of default contract violation handler could be improved redi at gcc dot gnu.org
@ 2022-11-21 13:40 ` redi at gcc dot gnu.org
2022-11-21 17:30 ` pinskia at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2022-11-21 13:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107792
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #0)
> default std::handle_contract_violation called:
N.B. The function is not in namespace std.
This seems better:
default handle_contract_violation called [default:default:NEVER]
in function f at fail.cc:1: r > 0
terminate called without an active exception
Aborted (core dumped)
We could say "[level:default role:default continue:NEVER]" instead if the
shorter form is too obscure.
Maybe instead of saying the default handler was called, we should just say a
contract was violated. That's what users actually care about, not the handler
itself:
contract violation in function f at fail.cc:1: r > 0
[level:default, role:default, continuation mode:never]
terminate called without an active exception
Aborted (core dumped)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/107792] Output of default contract violation handler could be improved
2022-11-21 11:43 [Bug libstdc++/107792] New: Output of default contract violation handler could be improved redi at gcc dot gnu.org
2022-11-21 13:40 ` [Bug libstdc++/107792] " redi at gcc dot gnu.org
@ 2022-11-21 17:30 ` pinskia at gcc dot gnu.org
2022-11-21 17:32 ` redi at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-21 17:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107792
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
Last reconfirmed| |2022-11-21
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/107792] Output of default contract violation handler could be improved
2022-11-21 11:43 [Bug libstdc++/107792] New: Output of default contract violation handler could be improved redi at gcc dot gnu.org
2022-11-21 13:40 ` [Bug libstdc++/107792] " redi at gcc dot gnu.org
2022-11-21 17:30 ` pinskia at gcc dot gnu.org
@ 2022-11-21 17:32 ` redi at gcc dot gnu.org
2022-12-23 0:51 ` cvs-commit at gcc dot gnu.org
2023-01-25 13:29 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2022-11-21 17:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107792
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Target Milestone|--- |13.0
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/107792] Output of default contract violation handler could be improved
2022-11-21 11:43 [Bug libstdc++/107792] New: Output of default contract violation handler could be improved redi at gcc dot gnu.org
` (2 preceding siblings ...)
2022-11-21 17:32 ` redi at gcc dot gnu.org
@ 2022-12-23 0:51 ` cvs-commit at gcc dot gnu.org
2023-01-25 13:29 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-12-23 0:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107792
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:
https://gcc.gnu.org/g:8ec5fcb6fc79e5bcca23c3fecbaf09d4566cb1d5
commit r13-4861-g8ec5fcb6fc79e5bcca23c3fecbaf09d4566cb1d5
Author: Arsen ArsenoviÄ <arsen@aarsen.me>
Date: Thu Dec 22 12:03:06 2022 +0100
libstdc++: Improve output of default contract violation handler [PR107792]
Make the output more readable. Don't output anything unless verbose
termination is enabled at configure-time.
The testsuite change was almost entirely mechanical. Save for two files
which had very short matches, these changes were produced by two seds and a
Perl script, for the more involved cases. The latter will be added in a
subsequent commit. The former are as follows:
sed -E -i "/dg-output/s/default std::handle_contract_violation called:
\
(\S+) (\S+) (\S+(<[A-Za-z0-9, ]*)?>?)\
/contract violation in function \3 at \1:\2: /" *.C
sed -i '/dg-output/s/ */ /g'
Whichever files remained failing after the above changes were checked-out,
re-ran, with output extracted, and ran through dg-out-generator.pl.
Co-Authored-By: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
PR libstdc++/107792
PR libstdc++/107778
* src/experimental/contract.cc (handle_contract_violation): Make
output more readable.
gcc/testsuite/ChangeLog:
* g++.dg/contracts/contracts-access1.C: Convert to new default
violation handler.
* g++.dg/contracts/contracts-assume2.C: Ditto.
* g++.dg/contracts/contracts-config1.C: Ditto.
* g++.dg/contracts/contracts-constexpr1.C: Ditto.
* g++.dg/contracts/contracts-ctor-dtor1.C: Ditto.
* g++.dg/contracts/contracts-deduced2.C: Ditto.
* g++.dg/contracts/contracts-friend1.C: Ditto.
* g++.dg/contracts/contracts-multiline1.C: Ditto.
* g++.dg/contracts/contracts-post3.C: Ditto.
* g++.dg/contracts/contracts-pre10.C: Ditto.
* g++.dg/contracts/contracts-pre2.C: Ditto.
* g++.dg/contracts/contracts-pre2a2.C: Ditto.
* g++.dg/contracts/contracts-pre3.C: Ditto.
* g++.dg/contracts/contracts-pre4.C: Ditto.
* g++.dg/contracts/contracts-pre5.C: Ditto.
* g++.dg/contracts/contracts-pre7.C: Ditto.
* g++.dg/contracts/contracts-pre9.C: Ditto.
* g++.dg/contracts/contracts-redecl3.C: Ditto.
* g++.dg/contracts/contracts-redecl4.C: Ditto.
* g++.dg/contracts/contracts-redecl6.C: Ditto.
* g++.dg/contracts/contracts-redecl7.C: Ditto.
* g++.dg/contracts/contracts-tmpl-spec1.C: Ditto.
* g++.dg/contracts/contracts-tmpl-spec2.C: Ditto.
* g++.dg/contracts/contracts-tmpl-spec3.C: Ditto.
* g++.dg/contracts/contracts10.C: Ditto.
* g++.dg/contracts/contracts14.C: Ditto.
* g++.dg/contracts/contracts15.C: Ditto.
* g++.dg/contracts/contracts16.C: Ditto.
* g++.dg/contracts/contracts17.C: Ditto.
* g++.dg/contracts/contracts19.C: Ditto.
* g++.dg/contracts/contracts25.C: Ditto.
* g++.dg/contracts/contracts3.C: Ditto.
* g++.dg/contracts/contracts35.C: Ditto.
* g++.dg/contracts/contracts5.C: Ditto.
* g++.dg/contracts/contracts7.C: Ditto.
* g++.dg/contracts/contracts9.C: Ditto.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/107792] Output of default contract violation handler could be improved
2022-11-21 11:43 [Bug libstdc++/107792] New: Output of default contract violation handler could be improved redi at gcc dot gnu.org
` (3 preceding siblings ...)
2022-12-23 0:51 ` cvs-commit at gcc dot gnu.org
@ 2023-01-25 13:29 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2023-01-25 13:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107792
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Done
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-25 13:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 11:43 [Bug libstdc++/107792] New: Output of default contract violation handler could be improved redi at gcc dot gnu.org
2022-11-21 13:40 ` [Bug libstdc++/107792] " redi at gcc dot gnu.org
2022-11-21 17:30 ` pinskia at gcc dot gnu.org
2022-11-21 17:32 ` redi at gcc dot gnu.org
2022-12-23 0:51 ` cvs-commit at gcc dot gnu.org
2023-01-25 13:29 ` redi at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).