[Bug libstdc++/107814] New: [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[Bug libstdc++/107814] New: [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

            Bug ID: 107814
           Summary: [13 regression]
                    experimental/filesystem/iterators/error_reporting.cc
                    FAILs
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: i386-pc-solaris2.11, amd64-pc-solaris2.11

Since 20221114, experimental/filesystem/iterators/error_reporting.cc FAILs on
Solaris/x86 only, 32 and 64-bit, while SPARC is fine:

FAIL: experimental/filesystem/iterators/error_reporting.cc execution test

/vol/gcc/src/hg/master/local/libstdc++-v3/testsuite/experimental/filesystem/iterators/error_reporting.cc:112:
void test02(): Assertion 'ec.value() == EIO' failed.

Running the test under truss on i386 vs. sparc shows:

* i386:

380:    mkdirat(AT_FDCWD,
"filesystem-test.error_reporting.4042030604.aA7VId/subdir", 0777) = 0
380:    openat64(AT_FDCWD, "filesystem-test.error_reporting.4042030604.aA7VId",
O_RDONLY|O_CLOEXEC|O_DIRECTORY) = 3
380:    fcntl(3, F_GETFL)                               = 8192
                FOFFMAX
380:    fstatat64(3, NULL, 0xFEFFD8C0, 0)               = 0
380:        d=0x04390012 i=2368576 m=0042755 l=3  u=2110  g=4620  sz=3
380:            at = Nov 22 14:15:46 MET 2022  [ 1669122946.599365773 ]
380:            mt = Nov 22 14:15:46 MET 2022  [ 1669122946.599784611 ]
380:            ct = Nov 22 14:15:46 MET 2022  [ 1669122946.599784611 ]
380:        bsz=131072 blks=1     fs=zfs
380:    llseek(3, 0, SEEK_CUR)                          = 0
380:    fcntl(3, F_SETFD, 0x00000001)                   = 0
380:    fstatat64(AT_FDCWD,
"filesystem-test.error_reporting.4042030604.aA7VId/su\x01", 0xFEFFD8D0,
AT_SYMLINK_NOFOLLOW) Err#2 ENOENT

* sparc:

14724:  mkdirat(AT_FDCWD,
"filesystem-test.error_reporting.2190730903.bVmlIc/subdir", 0777) = 0
14724:  openat64(AT_FDCWD, "filesystem-test.error_reporting.2190730903.bVmlIc",
O_RDONLY|O_CLOEXEC|O_DIRECTORY) = 3
14724:  fcntl(3, F_GETFL)                               = 8192
                FOFFMAX
14724:  fstatat64(3, NULL, 0xFFBFE738, 0)               = 0
14724:      d=0x04190013 i=5268679 m=0042755 l=3  u=2110  g=4620  sz=3
14724:          at = Nov 22 14:27:21 MET 2022  [ 1669123641.516468740 ]
14724:          mt = Nov 22 14:27:21 MET 2022  [ 1669123641.516614735 ]
14724:          ct = Nov 22 14:27:21 MET 2022  [ 1669123641.516614735 ]
14724:      bsz=131072 blks=1     fs=zfs
14724:  llseek(3, 0, SEEK_CUR)                          = 0
14724:  fcntl(3, F_SETFD, 0x00000001)                   = 0
14724:  fstatat64(AT_FDCWD,
"filesystem-test.error_reporting.2190730903.bVmlIc/subdir", 0xFFBFE728,
AT_SYMLINK_NOFOLLOW) = 0

I.e. the pathname is somehow corrupted.

[Bug libstdc++/107814] [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug libstdc++/107814] [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-11-22
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Are you sure this is a regression? Isn't it the same case as PR104731, but that
was only fixed for 27_io/filesystem/iterators/error_reporting.cc and not
experimental/filesystem/iterators/error_reporting.cc ?

[Bug libstdc++/107814] [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Created attachment 53949
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53949&action=edit
Fix unsafe use of dirent::d_name

I'm unable to access the Solaris/x86 host in the compile farm (gcc210) so I
can't test if this fixes it. It passes on Solaris/sparc.

[Bug libstdc++/107814] [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

--- Comment #3 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
> Are you sure this is a regression? Isn't it the same case as PR104731, but that
> was only fixed for 27_io/filesystem/iterators/error_reporting.cc and not
> experimental/filesystem/iterators/error_reporting.cc ?

I'd only checked the sparc and x86 results for the current gcc-12 branch
where the test PASSes on both.  However, the fact that the test on trunk
FAILs on x86, but PASSes on sparc seems to show that the results are
pretty unreliable.

So yea, very much looks like PR104731.

[Bug libstdc++/107814] [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I think I'll push the patch in comment 2 and we can see if it helps :-)

[Bug libstdc++/107814] [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

--- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
> I think I'll push the patch in comment 2 and we can see if it helps :-)

I've just tried it on sparc and x86, 32 and 64-bit: the test PASSes
everywhere now.  Thanks a lot.

[Bug libstdc++/107814] [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

--- Comment #6 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
> I'm unable to access the Solaris/x86 host in the compile farm (gcc210) so I
> can't test if this fixes it. It passes on Solaris/sparc.

According to https://cfarm.tetaneutral.net/machines/list/, gcc210 is a
Solaris 10/SPARC system, so useless for trunk testing.  AFAIK we still
don't have a Solaris 11/x86 system in the cfarm, which is a shame.  I
tried to provide one myself, but failed for various administrative
reasons ;-(

[Bug libstdc++/107814] [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #6)
> According to https://cfarm.tetaneutral.net/machines/list/, gcc210 is a
> Solaris 10/SPARC system, so useless for trunk testing.

Oh right, yes. For some reason I misremembered that gcc210 was Solaris 11 x86
and gcc211 was Solaris 11 sparc, but of course gcc210 is 10 and gcc211 is 11
... that should be easy to remember!

[Bug libstdc++/107814] [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:1cac00d013856fea4cee0f13c4959c8e21afd2d9

commit r13-4262-g1cac00d013856fea4cee0f13c4959c8e21afd2d9
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Nov 22 19:15:53 2022 +0000

    libstdc++: Fix unsafe use of dirent::d_name [PR107814]

    Copy the fix for PR 104731 to the equivalent experimental::filesystem
    test.

    libstdc++-v3/ChangeLog:

            PR libstdc++/107814
            * testsuite/experimental/filesystem/iterators/error_reporting.cc:
            Use a static buffer with space after it.

[Bug libstdc++/107814] [13 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.0                        |10.5

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Thanks for testing the patch. It's pushed to trunk now. I'll backport it as
well, because causing a buffer overflow in those filesystem calls isn't a good
idea.

[Bug libstdc++/107814] [10/11/12 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |13.0
           Priority|P3                          |P2
            Summary|[13 regression]             |[10/11/12 regression]
                   |experimental/filesystem/ite |experimental/filesystem/ite
                   |rators/error_reporting.cc   |rators/error_reporting.cc
                   |FAILs                       |FAILs

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
marking trunk as fixed but to be backported.

[Bug libstdc++/107814] [10/11/12 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:52daccd82cd71bd065826784ebb6eb04fa9b42af

commit r12-9005-g52daccd82cd71bd065826784ebb6eb04fa9b42af
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Nov 22 19:15:53 2022 +0000

    libstdc++: Fix unsafe use of dirent::d_name [PR107814]

    Copy the fix for PR 104731 to the equivalent experimental::filesystem
    test.

    libstdc++-v3/ChangeLog:

            PR libstdc++/107814
            * testsuite/experimental/filesystem/iterators/error_reporting.cc:
            Use a static buffer with space after it.

    (cherry picked from commit 1cac00d013856fea4cee0f13c4959c8e21afd2d9)

[Bug libstdc++/107814] [10/11 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:d176d5b3e734cac0ab1e613c3f1bbe48c0bab81a

commit r11-10434-gd176d5b3e734cac0ab1e613c3f1bbe48c0bab81a
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Nov 22 19:15:53 2022 +0000

    libstdc++: Fix unsafe use of dirent::d_name [PR107814]

    Copy the fix for PR 104731 to the equivalent experimental::filesystem
    test.

    libstdc++-v3/ChangeLog:

            PR libstdc++/107814
            * testsuite/experimental/filesystem/iterators/error_reporting.cc:
            Use a static buffer with space after it.

    (cherry picked from commit 1cac00d013856fea4cee0f13c4959c8e21afd2d9)

[Bug libstdc++/107814] [10 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:5d572ffe2e05dbe44edaf19fa10ef2ca3ae8227c

commit r10-11315-g5d572ffe2e05dbe44edaf19fa10ef2ca3ae8227c
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Nov 22 19:15:53 2022 +0000

    libstdc++: Fix unsafe use of dirent::d_name [PR107814]

    Copy the fix for PR 104731 to the equivalent experimental::filesystem
    test.

    libstdc++-v3/ChangeLog:

            PR libstdc++/107814
            * testsuite/experimental/filesystem/iterators/error_reporting.cc:
            Use a static buffer with space after it.

    (cherry picked from commit 1cac00d013856fea4cee0f13c4959c8e21afd2d9)

[Bug libstdc++/107814] [10 regression] experimental/filesystem/iterators/error_reporting.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107814

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #14 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 13.1, 12.3, 11.4 and 10.5