[Bug target/107988] New: [13 Regression] ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) on aarch64-unknown-linux-gnu

[Bug target/107988] New: [13 Regression] ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) on aarch64-unknown-linux-gnu

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107988

            Bug ID: 107988
           Summary: [13 Regression] ICE: in extract_insn, at recog.cc:2791
                    (unrecognizable insn) on aarch64-unknown-linux-gnu
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: aarch64-unknown-linux-gnu

Created attachment 54026
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54026&action=edit
reduced testcase

Compiler output:
$ aarch64-unknown-linux-gnu-gcc testcase.c 
testcase.c: In function 'foo':
testcase.c:10:1: error: unrecognizable insn:
   10 | }
      | ^
(insn 7 6 8 2 (set (reg:V16QI 97)
        (vec_concat:V16QI (unspec:V8QI [
                    (mem/c:V8HI (plus:DI (reg/f:DI 87 virtual-stack-vars)
                            (const_int -16 [0xfffffffffffffff0])) [1 v+0 S16
A128])
                    (reg:V8HI 94)
                ] UNSPEC_ADDHN)
            (const_vector:V8QI [
                    (const_int 0 [0]) repeated x8
                ]))) "testcase.c":8:5 -1
     (nil))
during RTL pass: vregs
testcase.c:10:1: internal compiler error: in extract_insn, at recog.cc:2791
0x7bdb48 _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        /repo/gcc-trunk/gcc/rtl-error.cc:108
0x7bdbc4 _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
        /repo/gcc-trunk/gcc/rtl-error.cc:116
0x7ae76c extract_insn(rtx_insn*)
        /repo/gcc-trunk/gcc/recog.cc:2791
0xddd657 instantiate_virtual_regs_in_insn
        /repo/gcc-trunk/gcc/function.cc:1611
0xddd657 instantiate_virtual_regs
        /repo/gcc-trunk/gcc/function.cc:1985
0xddd657 execute
        /repo/gcc-trunk/gcc/function.cc:2034
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ aarch64-unknown-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-aarch64/bin/aarch64-unknown-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r13-4497-20221206065114-g769370f3e2e-checking-yes-rtl-df-extra-aarch64/bin/../libexec/gcc/aarch64-unknown-linux-gnu/13.0.0/lto-wrapper
Target: aarch64-unknown-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl
--with-sysroot=/usr/aarch64-unknown-linux-gnu --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=aarch64-unknown-linux-gnu
--with-ld=/usr/bin/aarch64-unknown-linux-gnu-ld
--with-as=/usr/bin/aarch64-unknown-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r13-4497-20221206065114-g769370f3e2e-checking-yes-rtl-df-extra-aarch64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.0.0 20221206 (experimental) (GCC)

[Bug target/107988] [13 Regression] ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) on aarch64-unknown-linux-gnu

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107988

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-12-06
     Ever confirmed|0                           |1
                 CC|                            |ktkachov at gcc dot gnu.org,
                   |                            |tnfchris at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from ktkachov at gcc dot gnu.org ---
Confirmed. Looks related to the recent div-by-special-constant changes but ICEs
only at -O0

[Bug target/107988] [13 Regression] ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) on aarch64-unknown-linux-gnu

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107988

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |tnfchris at gcc dot gnu.org

--- Comment #2 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
how did a mem get in there..

[Bug target/107988] [13 Regression] ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) on aarch64-unknown-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107988

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug target/107988] [13 Regression] ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) on aarch64-unknown-linux-gnu

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107988

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:8c2451ba4601739654e2ea4907d6fa2a00d660aa

commit r13-4699-g8c2451ba4601739654e2ea4907d6fa2a00d660aa
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Wed Dec 14 13:54:28 2022 +0000

    AArch64: div-by-255, ensure that arguments are registers. [PR107988]

    At -O0 (as opposed to e.g. volatile) we can get into the situation where
the
    in0 and result RTL arguments passed to the division function are memory
    locations instead of registers.  I think we could reject these early on by
    checking that the gimple values are GIMPLE registers, but I think it's
better to
    handle it.

    As such I force them to registers and emit a move to the memory locations
and
    leave it up to reload to handle.  This fixes the ICE and still allows the
    optimization in these cases,  which improves the code quality a lot.

    gcc/ChangeLog:

            PR target/107988
            * config/aarch64/aarch64.cc
            (aarch64_vectorize_can_special_div_by_constant): Ensure input and
output
            RTL are registers.

    gcc/testsuite/ChangeLog:

            PR target/107988
            * gcc.target/aarch64/pr107988-1.c: New test.

[Bug target/107988] [13 Regression] ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) on aarch64-unknown-linux-gnu

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107988

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Fixed, thanks for the report.