* [Bug tree-optimization/107997] [13 Regression] fd8dd6c03849691 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
@ 2022-12-07 0:08 ` pinskia at gcc dot gnu.org
2022-12-08 17:41 ` [Bug tree-optimization/107997] [13 Regression] r13-4389-gfd8dd6c0384969 " jakub at gcc dot gnu.org
` (17 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-12-07 0:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |ice-on-valid-code
Component|regression |tree-optimization
Summary|fd8dd6c03849691 probably |[13 Regression]
|uncovered an issue building |fd8dd6c03849691 probably
|the Linux kernel |uncovered an issue building
| |the Linux kernel
Target Milestone|--- |13.0
Target| |powerpc64-linux
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
2022-12-07 0:08 ` [Bug tree-optimization/107997] [13 Regression] " pinskia at gcc dot gnu.org
@ 2022-12-08 17:41 ` jakub at gcc dot gnu.org
2022-12-08 18:07 ` jbglaw@lug-owl.de
` (16 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-08 17:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Jan-Benedict Glaw from comment #0)
> I'll add the preprocessed sources.
Could you please? Without it there isn't much that can be done.
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
2022-12-07 0:08 ` [Bug tree-optimization/107997] [13 Regression] " pinskia at gcc dot gnu.org
2022-12-08 17:41 ` [Bug tree-optimization/107997] [13 Regression] r13-4389-gfd8dd6c0384969 " jakub at gcc dot gnu.org
@ 2022-12-08 18:07 ` jbglaw@lug-owl.de
2022-12-08 18:47 ` jbglaw@lug-owl.de
` (15 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jbglaw@lug-owl.de @ 2022-12-08 18:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #2 from Jan-Benedict Glaw <jbglaw@lug-owl.de> ---
(In reply to Jakub Jelinek from comment #1)
> (In reply to Jan-Benedict Glaw from comment #0)
> > I'll add the preprocessed sources.
>
> Could you please? Without it there isn't much that can be done.
At it right now, throwing it at cvise.
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (2 preceding siblings ...)
2022-12-08 18:07 ` jbglaw@lug-owl.de
@ 2022-12-08 18:47 ` jbglaw@lug-owl.de
2022-12-08 18:47 ` jbglaw@lug-owl.de
` (14 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jbglaw@lug-owl.de @ 2022-12-08 18:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #3 from Jan-Benedict Glaw <jbglaw@lug-owl.de> ---
Created attachment 54048
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54048&action=edit
Original preprocessed source
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (3 preceding siblings ...)
2022-12-08 18:47 ` jbglaw@lug-owl.de
@ 2022-12-08 18:47 ` jbglaw@lug-owl.de
2022-12-08 18:55 ` jakub at gcc dot gnu.org
` (13 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jbglaw@lug-owl.de @ 2022-12-08 18:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #4 from Jan-Benedict Glaw <jbglaw@lug-owl.de> ---
Created attachment 54049
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54049&action=edit
Reduced testcase (cvise)
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (4 preceding siblings ...)
2022-12-08 18:47 ` jbglaw@lug-owl.de
@ 2022-12-08 18:55 ` jakub at gcc dot gnu.org
2022-12-08 19:18 ` jakub at gcc dot gnu.org
` (12 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-08 18:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2022-12-08
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Cleaned up, just -Os is needed:
int a, b;
void bar (int);
int baz (void);
void *
foo (int x, void *y)
{
asm goto ("" : : "r" (x || !a) : : l);
l:
if (y)
return 0;
bar (b ? b : x);
while (x--)
{
if (!baz ())
baz ();
asm goto ("" : : : : l2);
l2:
}
return y;
}
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (5 preceding siblings ...)
2022-12-08 18:55 ` jakub at gcc dot gnu.org
@ 2022-12-08 19:18 ` jakub at gcc dot gnu.org
2022-12-08 19:22 ` [Bug tree-optimization/107997] [10/11/12/13 " pinskia at gcc dot gnu.org
` (11 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-08 19:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
create_new_iv is called with cand->pos being IP_END, where the last stmt of the
body is asm goto.
__asm__ __volatile__ goto("" : : : : "l2" l2);
;; succ: 13
;; basic block 13, loop depth 1
;; pred: 9
;; 12
# x_4 = PHI <x_10(D)(9), x_14(12)>
l2:
As the label is in the same bb as fallthrough, the bb which ends with asm goto
has just a single succ edge, but in order to insert something at the end of the
latch bb,
we would need to create a new bb, move the label to it and insert the iv there.
I guess gsi_insert_on_edge_immediate should be able to handle that case, or
perhaps just detect when gsi_last_bb (ip_end_pos (data->current_loop))
is GIMPLE_ASM or better yet stmt_ends_bb_p and split_edge in that case?
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (6 preceding siblings ...)
2022-12-08 19:18 ` jakub at gcc dot gnu.org
@ 2022-12-08 19:22 ` pinskia at gcc dot gnu.org
2022-12-08 19:50 ` jakub at gcc dot gnu.org
` (10 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-12-08 19:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to fail| |10.1.0, 11.1.0, 12.2.0
Known to work| |9.1.0
Keywords| |ice-checking
Target|powerpc64-linux |x86_64-linux-gnu
| |powerpc64-linux
Summary|[13 Regression] |[10/11/12/13 Regression]
|r13-4389-gfd8dd6c0384969 |r13-4389-gfd8dd6c0384969
|probably uncovered an issue |probably uncovered an issue
|building the Linux kernel |building the Linux kernel
Target Milestone|13.0 |10.5
--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
With the reduced testcase in comment #5 (with a `;` add after `l2:` to allow
compiling with older gcc), the ICE is there for GCC 10+ (with -fchecking).
GCC 9 didn't ICE nor did it place gimple after the `asm goto`.
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (7 preceding siblings ...)
2022-12-08 19:22 ` [Bug tree-optimization/107997] [10/11/12/13 " pinskia at gcc dot gnu.org
@ 2022-12-08 19:50 ` jakub at gcc dot gnu.org
2022-12-09 13:49 ` jakub at gcc dot gnu.org
` (9 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-08 19:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Indeed, and it started with r10-5288-g52dc9c32311e8ea4833b8865c0d3121cad03937d
but guess it has been latent before.
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (8 preceding siblings ...)
2022-12-08 19:50 ` jakub at gcc dot gnu.org
@ 2022-12-09 13:49 ` jakub at gcc dot gnu.org
2022-12-09 18:27 ` jbglaw@lug-owl.de
` (8 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-09 13:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 54053
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54053&action=edit
gcc13-pr107997.patch
Untested fix.
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (9 preceding siblings ...)
2022-12-09 13:49 ` jakub at gcc dot gnu.org
@ 2022-12-09 18:27 ` jbglaw@lug-owl.de
2022-12-10 15:51 ` cvs-commit at gcc dot gnu.org
` (7 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jbglaw@lug-owl.de @ 2022-12-09 18:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #10 from Jan-Benedict Glaw <jbglaw@lug-owl.de> ---
I gave that patch a try: GCC build is successful, as is the Linux build
afterwards using that toolchain. (Cannot test the resulting kernel of
course---I don't have the hardware.)
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (10 preceding siblings ...)
2022-12-09 18:27 ` jbglaw@lug-owl.de
@ 2022-12-10 15:51 ` cvs-commit at gcc dot gnu.org
2022-12-14 10:33 ` jbglaw@lug-owl.de
` (6 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-12-10 15:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:7676235f690e624b7ed41a22b22ce8ccfac1492f
commit r13-4594-g7676235f690e624b7ed41a22b22ce8ccfac1492f
Author: Jakub Jelinek <jakub@redhat.com>
Date: Sat Dec 10 16:50:39 2022 +0100
ivopts: Fix IP_END handling for asm goto [PR107997]
The following testcase ICEs, because the latch bb ends with
asm goto which has both fallthrough to the header and one or more labels
in the header too. In that case there is just a single edge out of the
latch block, but still the asm goto is stmt_ends_bb_p statement, yet
ivopts decides to emit an IV bump at the IP_END position and inserts
it into the same bb as the asm goto after it, which then fails verification
(control flow in the middle of bb).
The following patch fixes it by splitting the latch -> header edge in that
case and inserting into the newly created bb, where split_edge ->
redirect_edge_and_branch is able to deal with this case correctly.
2022-12-10 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/107997
* tree-ssa-loop-ivopts.cc: Include cfganal.h.
(create_new_iv) <case IP_END>: If ip_end_pos bb is non-empty and
ends
with a stmt which ends bb, instead of adding iv update after it
split
the latch edge and insert iterator into the new latch bb.
* gcc.c-torture/compile/pr107997.c: New test.
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (11 preceding siblings ...)
2022-12-10 15:51 ` cvs-commit at gcc dot gnu.org
@ 2022-12-14 10:33 ` jbglaw@lug-owl.de
2023-02-10 17:44 ` cvs-commit at gcc dot gnu.org
` (5 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jbglaw@lug-owl.de @ 2022-12-14 10:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
Jan-Benedict Glaw <jbglaw@lug-owl.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #12 from Jan-Benedict Glaw <jbglaw@lug-owl.de> ---
Fixed with that commit. There is a similar unrelated (PR108095), but that's got
its own ticket.
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (12 preceding siblings ...)
2022-12-14 10:33 ` jbglaw@lug-owl.de
@ 2023-02-10 17:44 ` cvs-commit at gcc dot gnu.org
2023-02-10 17:58 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-02-10 17:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:89daf0dd6f1748077c03fbeb27ca5980a0b9abd5
commit r12-9125-g89daf0dd6f1748077c03fbeb27ca5980a0b9abd5
Author: Jakub Jelinek <jakub@redhat.com>
Date: Sat Dec 10 16:50:39 2022 +0100
ivopts: Fix IP_END handling for asm goto [PR107997]
The following testcase ICEs, because the latch bb ends with
asm goto which has both fallthrough to the header and one or more labels
in the header too. In that case there is just a single edge out of the
latch block, but still the asm goto is stmt_ends_bb_p statement, yet
ivopts decides to emit an IV bump at the IP_END position and inserts
it into the same bb as the asm goto after it, which then fails verification
(control flow in the middle of bb).
The following patch fixes it by splitting the latch -> header edge in that
case and inserting into the newly created bb, where split_edge ->
redirect_edge_and_branch is able to deal with this case correctly.
2022-12-10 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/107997
* tree-ssa-loop-ivopts.cc: Include cfganal.h.
(create_new_iv) <case IP_END>: If ip_end_pos bb is non-empty and
ends
with a stmt which ends bb, instead of adding iv update after it
split
the latch edge and insert iterator into the new latch bb.
* gcc.c-torture/compile/pr107997.c: New test.
(cherry picked from commit 7676235f690e624b7ed41a22b22ce8ccfac1492f)
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (13 preceding siblings ...)
2023-02-10 17:44 ` cvs-commit at gcc dot gnu.org
@ 2023-02-10 17:58 ` jakub at gcc dot gnu.org
2023-05-02 20:12 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-02-10 17:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for gcc 12.3 too.
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (14 preceding siblings ...)
2023-02-10 17:58 ` jakub at gcc dot gnu.org
@ 2023-05-02 20:12 ` cvs-commit at gcc dot gnu.org
2023-05-03 9:33 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-05-02 20:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:5a0fd69bb3aa1709f0bea5d6b91fb30ca226c1ed
commit r11-10687-g5a0fd69bb3aa1709f0bea5d6b91fb30ca226c1ed
Author: Jakub Jelinek <jakub@redhat.com>
Date: Sat Dec 10 16:50:39 2022 +0100
ivopts: Fix IP_END handling for asm goto [PR107997]
The following testcase ICEs, because the latch bb ends with
asm goto which has both fallthrough to the header and one or more labels
in the header too. In that case there is just a single edge out of the
latch block, but still the asm goto is stmt_ends_bb_p statement, yet
ivopts decides to emit an IV bump at the IP_END position and inserts
it into the same bb as the asm goto after it, which then fails verification
(control flow in the middle of bb).
The following patch fixes it by splitting the latch -> header edge in that
case and inserting into the newly created bb, where split_edge ->
redirect_edge_and_branch is able to deal with this case correctly.
2022-12-10 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/107997
* tree-ssa-loop-ivopts.c: Include cfganal.h.
(create_new_iv) <case IP_END>: If ip_end_pos bb is non-empty and
ends
with a stmt which ends bb, instead of adding iv update after it
split
the latch edge and insert iterator into the new latch bb.
* gcc.c-torture/compile/pr107997.c: New test.
(cherry picked from commit 7676235f690e624b7ed41a22b22ce8ccfac1492f)
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (15 preceding siblings ...)
2023-05-02 20:12 ` cvs-commit at gcc dot gnu.org
@ 2023-05-03 9:33 ` jakub at gcc dot gnu.org
2023-05-03 15:19 ` cvs-commit at gcc dot gnu.org
2023-05-04 7:22 ` jakub at gcc dot gnu.org
18 siblings, 0 replies; 20+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-05-03 9:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #16 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.4 as well.
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (16 preceding siblings ...)
2023-05-03 9:33 ` jakub at gcc dot gnu.org
@ 2023-05-03 15:19 ` cvs-commit at gcc dot gnu.org
2023-05-04 7:22 ` jakub at gcc dot gnu.org
18 siblings, 0 replies; 20+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-05-03 15:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:5589bb8d1fd3d4ecfb71e764d54bf931a743b85d
commit r10-11346-g5589bb8d1fd3d4ecfb71e764d54bf931a743b85d
Author: Jakub Jelinek <jakub@redhat.com>
Date: Sat Dec 10 16:50:39 2022 +0100
ivopts: Fix IP_END handling for asm goto [PR107997]
The following testcase ICEs, because the latch bb ends with
asm goto which has both fallthrough to the header and one or more labels
in the header too. In that case there is just a single edge out of the
latch block, but still the asm goto is stmt_ends_bb_p statement, yet
ivopts decides to emit an IV bump at the IP_END position and inserts
it into the same bb as the asm goto after it, which then fails verification
(control flow in the middle of bb).
The following patch fixes it by splitting the latch -> header edge in that
case and inserting into the newly created bb, where split_edge ->
redirect_edge_and_branch is able to deal with this case correctly.
2022-12-10 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/107997
* tree-ssa-loop-ivopts.c: Include cfganal.h.
(create_new_iv) <case IP_END>: If ip_end_pos bb is non-empty and
ends
with a stmt which ends bb, instead of adding iv update after it
split
the latch edge and insert iterator into the new latch bb.
* gcc.c-torture/compile/pr107997.c: New test.
(cherry picked from commit 7676235f690e624b7ed41a22b22ce8ccfac1492f)
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug tree-optimization/107997] [10/11/12/13 Regression] r13-4389-gfd8dd6c0384969 probably uncovered an issue building the Linux kernel
2022-12-06 22:24 [Bug regression/107997] New: fd8dd6c03849691 probably uncovered an issue building the Linux kernel jbglaw@lug-owl.de
` (17 preceding siblings ...)
2023-05-03 15:19 ` cvs-commit at gcc dot gnu.org
@ 2023-05-04 7:22 ` jakub at gcc dot gnu.org
18 siblings, 0 replies; 20+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-05-04 7:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107997
--- Comment #18 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 10.5 too.
^ permalink raw reply [flat|nested] 20+ messages in thread