public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/108933] New: [10/11/12/13 Regression] Missing bswap detection
@ 2023-02-25 19:50 pinskia at gcc dot gnu.org
  2023-02-25 19:51 ` [Bug target/108933] " pinskia at gcc dot gnu.org
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-02-25 19:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108933

            Bug ID: 108933
           Summary: [10/11/12/13 Regression] Missing bswap detection
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
                CC: ktkachov at gcc dot gnu.org, unassigned at gcc dot gnu.org
        Depends on: 108874
            Blocks: 94094
  Target Milestone: ---
            Target: arm

This is the arm version of this bug.


+++ This bug was initially created as a clone of Bug #108874 +++


If we look at the arm testcases in gcc.target/arm/rev16.c
typedef unsigned int __u32;

__u32
__rev16_32_alt (__u32 x)
{
  return (((__u32)(x) & (__u32)0xff00ff00UL) >> 8)
         | (((__u32)(x) & (__u32)0x00ff00ffUL) << 8);
}

__u32
__rev16_32 (__u32 x)
{
  return (((__u32)(x) & (__u32)0x00ff00ffUL) << 8)
         | (((__u32)(x) & (__u32)0xff00ff00UL) >> 8);
}

we should be able to generate rev16 instructions for aarch64 (and arm) i.e.
recognise a __builtin_bswap16 essentially.
GCC fails to do so and generates:
__rev16_32_alt:
        lsr     w1, w0, 8
        lsl     w0, w0, 8
        and     w1, w1, 16711935
        and     w0, w0, -16711936
        orr     w0, w1, w0
        ret
__rev16_32:
        lsl     w1, w0, 8
        lsr     w0, w0, 8
        and     w1, w1, -16711936
        and     w0, w0, 16711935
        orr     w0, w1, w0
        ret

whereas clang manages to recognise it all into:
__rev16_32_alt:                         // @__rev16_32_alt
        rev16   w0, w0
        ret
__rev16_32:                             // @__rev16_32
        rev16   w0, w0
        ret

does the bswap pass need some tweaking perhaps?

Looks like this worked fine with GCC 5 but broke in the GCC 6 timeframe so
marking as a regression


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94094
[Bug 94094] [meta-bug] store-merging and/or bswap load/store-merging missed
optimizations
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108874
[Bug 108874] [10/11/12/13 Regression] Missing bswap detection

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-01-29 16:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-25 19:50 [Bug target/108933] New: [10/11/12/13 Regression] Missing bswap detection pinskia at gcc dot gnu.org
2023-02-25 19:51 ` [Bug target/108933] " pinskia at gcc dot gnu.org
2023-03-10 17:54 ` pinskia at gcc dot gnu.org
2023-03-15 11:44 ` jakub at gcc dot gnu.org
2023-03-15 22:09 ` [Bug target/108933] [10/11/12/13 Regression] Missing rev16 detection pinskia at gcc dot gnu.org
2023-03-15 22:10 ` pinskia at gcc dot gnu.org
2023-03-27 10:56 ` rguenth at gcc dot gnu.org
2023-07-07 10:44 ` [Bug target/108933] [11/12/13/14 " rguenth at gcc dot gnu.org
2024-01-29 15:58 ` cvs-commit at gcc dot gnu.org
2024-01-29 16:01 ` [Bug target/108933] [11/12/13 " rearnsha at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).