[Bug c++/108980] New: Warning text missing the warning itself (GCC 13)

[Bug c++/108980] New: Warning text missing the warning itself (GCC 13)

[thiago at kde dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

            Bug ID: 108980
           Summary: Warning text missing the warning itself (GCC 13)
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: thiago at kde dot org
  Target Milestone: ---

Warning options:
-Wall -Wextra -fno-exceptions -mno-direct-extern-access -Werror -Wno-error=cpp
-Wno-error=deprecated-declarations -Wno-error=strict-overflow
-Wno-error=implicit-fallthrough -Wno-error=deprecated-copy
-Wno-error=redundant-move -Wno-error=init-list-lifetime
-Wno-error=format-overflow -Wno-error=stringop-overflow
-Wno-error=deprecated-enum-enum-conversion
-Wno-error=deprecated-enum-float-conversion -Wsuggest-override

Printed:

In file included from
/home/tjmaciei/src/qt/qt6-release/qtdeclarative/src/qmlmodels/qqmllistcompositor.cpp:4:
/home/tjmaciei/src/qt/qt6-release/qtdeclarative/src/qmlmodels/qqmllistcompositor_p.h:
In member function ‘void QQmlListCompositor::move(Group, int, Group, int, int,
Group, QVector<Remove>*, QVector<Insert>*)’:
/home/tjmaciei/src/qt/qt6-release/qtdeclarative/src/qmlmodels/qqmllistcompositor_p.h:115:13:
note: while referencing ‘QQmlListCompositor::iterator::index’
  115 |         int index[MaximumGroupCount] = { 0 };
      |             ^~~~~
/home/tjmaciei/src/qt/qt6-release/qtdeclarative/src/qmlmodels/qqmllistcompositor_p.h:115:13:
note: while referencing ‘QQmlListCompositor::iterator::index’

How can I help find out what the issue here is?

[Bug c++/108980] Warning text missing the warning itself (GCC 13)

[thiago at kde dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

--- Comment #1 from Thiago Macieira <thiago at kde dot org> ---
GCC 13 (trunk) built today.

[Bug tree-optimization/108980] Warning text missing the warning itself (GCC 13)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The problem is obviously in array_bounds_checker::check_array_ref .

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Warning text missing the    |[13 Regression] Warning
                   |warning itself (GCC 13)     |text missing the warning
                   |                            |itself (GCC 13)

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The logic is:
  if (warned || out_of_bound)
    {

      if ((out_of_bound && warn_strict_flex_arrays)
          && (((sam == special_array_member::trail_0)
                || (sam == special_array_member::trail_1)
                || (sam == special_array_member::trail_n))
              && DECL_NOT_FLEXARRAY (afield_decl)))
              warned = warning_at (location, 
...
      if (DECL_P (ref))
        inform (DECL_SOURCE_LOCATION (ref), "while referencing %qD", ref);
      if (rec && DECL_P (rec))
        inform (DECL_SOURCE_LOCATION (rec), "defined here %qD", rec);


The checks before calling inform should include a check for warned .

Started with r13-4748-g2a27ae32fabf85 .

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Target Milestone|---                         |13.0
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-03-01

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 54562
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54562&action=edit
Patch which I think is correct but not 100% sure

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #4)
> Created attachment 54562 [details]
> Patch which I think is correct but not 100% sure

LGTM.  Please test & post.

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[thiago at kde dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

--- Comment #6 from Thiago Macieira <thiago at kde dot org> ---
Testing.

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[thiago at kde dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

--- Comment #7 from Thiago Macieira <thiago at kde dot org> ---
The duplicate "note:" disappeared. But now there's no warning at all on the
same file, with the same options. Was that intended?

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Thiago Macieira from comment #7)
> The duplicate "note:" disappeared. But now there's no warning at all on the
> same file, with the same options. Was that intended?

Yes that was the intent of the patch. There is not supposed to be any warning
here at all. It was a mistake that an note (inform call) was emitted in the
first place.

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[thiago at kde dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

--- Comment #9 from Thiago Macieira <thiago at kde dot org> ---
Ah, got it. That also explains why I couldn't find anything wrong with my code,
and nothing I did that could likely be it made the warning go away.

Thanks for the quick turnaround.

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Mine, the patch which I am testing (and will be submitting) is different from
the attached one because there could be a case were the inner warning could
return false but we still want to emit the note as we did a warning before
hand.

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2023-March/6
                   |                            |13130.html

--- Comment #11 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Patch submitted:
https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613130.html

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://gcc.gnu.org/piperma |https://gcc.gnu.org/piperma
                   |il/gcc-patches/2023-March/6 |il/gcc-patches/2023-March/6
                   |13130.html                  |13662.html

--- Comment #12 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Updated patch for Jakub's comments:
https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613662.html

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:c6232ba229a4fcd453b50f11351fcbd35296809c

commit r13-6559-gc6232ba229a4fcd453b50f11351fcbd35296809c
Author: Andrew Pinski <apinski@marvell.com>
Date:   Wed Mar 1 11:13:21 2023 -0800

    Fix PR 108980: note without warning due to array bounds check

    The problem here is after r13-4748-g2a27ae32fabf85, in some
    cases we were calling inform without a corresponding warning.
    This changes the logic such that we only cause that to happen
    if there was a warning happened before hand.

    Changes since
    * v1: Fix formating and dump message as suggested by Jakub.

    OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.

    gcc/ChangeLog:

            PR tree-optimization/108980
            * gimple-array-bounds.cc (array_bounds_checker::check_array_ref):
            Reorgnize the call to warning for not strict flexible arrays
            to be before the check of warned.

[Bug tree-optimization/108980] [13 Regression] Warning text missing the warning itself (GCC 13)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108980

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #14 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.