[Bug c++/109309] New: Untranslated text in diagnostic

[Bug c++/109309] New: Untranslated text in diagnostic

[roland.illig at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109309

            Bug ID: 109309
           Summary: Untranslated text in diagnostic
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: roland.illig at gmx dot de
  Target Milestone: ---

In cp/contracts.cc, check_postcondition_result says:
> error_at (loc, "%s does not return a value to test", what);

At that point, 'what' contains either 'constructor', 'destructor' or
'function'. These words may require different grammatical forms in non-English
languages.

To fix this, the variable 'what' should be inlined into the 3 diagnostics.

[Bug c++/109309] Untranslated text in diagnostic

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109309

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-03-28
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
           Keywords|                            |translation

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

[Bug c++/109309] Untranslated text in diagnostic

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109309

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Target Milestone|---                         |13.0
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org

[Bug c++/109309] Untranslated text in diagnostic

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109309

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:af45b17d0a8fe3e7ae08662008a1f41e48a4a3eb

commit r13-6911-gaf45b17d0a8fe3e7ae08662008a1f41e48a4a3eb
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Mar 28 17:49:23 2023 +0200

    c++: Allow translations of check_postcondition_result messages [PR109309]

    As mentioned in the PR, constructing a message from two parts by
    concatenating them prevents translations, unless one of the parts
    is a keyword which should be never translated.

    The following patch fixes that.

    2023-03-28  Jakub Jelinek  <jakub@redhat.com>

            PR c++/109309
            * contracts.cc: Include intl.h.
            (check_postcondition_result): Don't form diagnostics from two
halves
            of an English message to allow translations.

[Bug c++/109309] Untranslated text in diagnostic

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109309

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Should be fixed now.