public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug libstdc++/109525] New: typo in views::as_const::operator()
@ 2023-04-15 15:41 hewillk at gmail dot com
2023-04-15 15:41 ` [Bug libstdc++/109525] " hewillk at gmail dot com
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: hewillk at gmail dot com @ 2023-04-15 15:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525
Bug ID: 109525
Summary: typo in views::as_const::operator()
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: hewillk at gmail dot com
Target Milestone: ---
ranges#L9027:
else if constexpr (is_lvalue_reference_v<_Range>
&& constant_range<_Tp>
&& !view<_Tp>)
return ref_view(static_cast<const _Tp&>(__r));
According to [range.as.const.overview-2.5], the second condition should be
constant_range<const _Tp>, I think?
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libstdc++/109525] typo in views::as_const::operator() 2023-04-15 15:41 [Bug libstdc++/109525] New: typo in views::as_const::operator() hewillk at gmail dot com @ 2023-04-15 15:41 ` hewillk at gmail dot com 2023-04-16 17:16 ` ppalka at gcc dot gnu.org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: hewillk at gmail dot com @ 2023-04-15 15:41 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525 --- Comment #1 from 康桓瑋 <hewillk at gmail dot com> --- testcase: #include <ranges> #include <vector> std::vector<int> v; std::same_as<std::ranges::ref_view<const std::vector<int>>> auto r = std::views::as_const(v); ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/109525] typo in views::as_const::operator() 2023-04-15 15:41 [Bug libstdc++/109525] New: typo in views::as_const::operator() hewillk at gmail dot com 2023-04-15 15:41 ` [Bug libstdc++/109525] " hewillk at gmail dot com @ 2023-04-16 17:16 ` ppalka at gcc dot gnu.org 2023-04-18 11:23 ` cvs-commit at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: ppalka at gcc dot gnu.org @ 2023-04-16 17:16 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525 Patrick Palka <ppalka at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Assignee|unassigned at gcc dot gnu.org |ppalka at gcc dot gnu.org Status|UNCONFIRMED |ASSIGNED Last reconfirmed| |2023-04-16 CC| |ppalka at gcc dot gnu.org ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/109525] typo in views::as_const::operator() 2023-04-15 15:41 [Bug libstdc++/109525] New: typo in views::as_const::operator() hewillk at gmail dot com 2023-04-15 15:41 ` [Bug libstdc++/109525] " hewillk at gmail dot com 2023-04-16 17:16 ` ppalka at gcc dot gnu.org @ 2023-04-18 11:23 ` cvs-commit at gcc dot gnu.org 2023-04-18 11:28 ` cvs-commit at gcc dot gnu.org 2023-04-18 12:03 ` ppalka at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2023-04-18 11:23 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>: https://gcc.gnu.org/g:4ec4ceafcc04ec7bafb1857cf6d491030440a765 commit r14-27-g4ec4ceafcc04ec7bafb1857cf6d491030440a765 Author: Patrick Palka <ppalka@redhat.com> Date: Tue Apr 18 07:21:07 2023 -0400 libstdc++: Fix typo in views::as_const's operator() [PR109525] PR libstdc++/109525 libstdc++-v3/ChangeLog: * include/std/ranges (views::_AsConst::operator()): Add missing const to constant_range test. * testsuite/std/ranges/adaptors/as_const/1.cc (test02): Improve formatting. Adjust expected type of v2. (test03): New test. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/109525] typo in views::as_const::operator() 2023-04-15 15:41 [Bug libstdc++/109525] New: typo in views::as_const::operator() hewillk at gmail dot com ` (2 preceding siblings ...) 2023-04-18 11:23 ` cvs-commit at gcc dot gnu.org @ 2023-04-18 11:28 ` cvs-commit at gcc dot gnu.org 2023-04-18 12:03 ` ppalka at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2023-04-18 11:28 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525 --- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-13 branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>: https://gcc.gnu.org/g:4dc8c0b62d91d239b88cc81bbb8f4fbde317fde6 commit r13-7212-g4dc8c0b62d91d239b88cc81bbb8f4fbde317fde6 Author: Patrick Palka <ppalka@redhat.com> Date: Tue Apr 18 07:21:07 2023 -0400 libstdc++: Fix typo in views::as_const's operator() [PR109525] PR libstdc++/109525 libstdc++-v3/ChangeLog: * include/std/ranges (views::_AsConst::operator()): Add missing const to constant_range test. * testsuite/std/ranges/adaptors/as_const/1.cc (test02): Improve formatting. Adjust expected type of v2. (test03): New test. (cherry picked from commit 4ec4ceafcc04ec7bafb1857cf6d491030440a765) ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/109525] typo in views::as_const::operator() 2023-04-15 15:41 [Bug libstdc++/109525] New: typo in views::as_const::operator() hewillk at gmail dot com ` (3 preceding siblings ...) 2023-04-18 11:28 ` cvs-commit at gcc dot gnu.org @ 2023-04-18 12:03 ` ppalka at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: ppalka at gcc dot gnu.org @ 2023-04-18 12:03 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525 Patrick Palka <ppalka at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED Target Milestone|--- |13.0 --- Comment #4 from Patrick Palka <ppalka at gcc dot gnu.org> --- Fixed for GCC 13, thanks! ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-18 12:03 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-04-15 15:41 [Bug libstdc++/109525] New: typo in views::as_const::operator() hewillk at gmail dot com 2023-04-15 15:41 ` [Bug libstdc++/109525] " hewillk at gmail dot com 2023-04-16 17:16 ` ppalka at gcc dot gnu.org 2023-04-18 11:23 ` cvs-commit at gcc dot gnu.org 2023-04-18 11:28 ` cvs-commit at gcc dot gnu.org 2023-04-18 12:03 ` ppalka at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).