[Bug libstdc++/109525] New: typo in views::as_const::operator()

[Bug libstdc++/109525] New: typo in views::as_const::operator()

[hewillk at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525

            Bug ID: 109525
           Summary: typo in views::as_const::operator()
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hewillk at gmail dot com
  Target Milestone: ---

ranges#L9027:

        else if constexpr (is_lvalue_reference_v<_Range>
                           && constant_range<_Tp>
                           && !view<_Tp>)
          return ref_view(static_cast<const _Tp&>(__r));


According to [range.as.const.overview-2.5], the second condition should be
constant_range<const _Tp>, I think?

[Bug libstdc++/109525] typo in views::as_const::operator()

[hewillk at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525

--- Comment #1 from 康桓瑋 <hewillk at gmail dot com> ---
testcase:

#include <ranges>
#include <vector>

std::vector<int> v;
std::same_as<std::ranges::ref_view<const std::vector<int>>> 
  auto r = std::views::as_const(v);

[Bug libstdc++/109525] typo in views::as_const::operator()

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |ppalka at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-04-16
                 CC|                            |ppalka at gcc dot gnu.org

[Bug libstdc++/109525] typo in views::as_const::operator()

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:4ec4ceafcc04ec7bafb1857cf6d491030440a765

commit r14-27-g4ec4ceafcc04ec7bafb1857cf6d491030440a765
Author: Patrick Palka <ppalka@redhat.com>
Date:   Tue Apr 18 07:21:07 2023 -0400

    libstdc++: Fix typo in views::as_const's operator() [PR109525]

            PR libstdc++/109525

    libstdc++-v3/ChangeLog:

            * include/std/ranges (views::_AsConst::operator()): Add
            missing const to constant_range test.
            * testsuite/std/ranges/adaptors/as_const/1.cc (test02):
            Improve formatting.  Adjust expected type of v2.
            (test03): New test.

[Bug libstdc++/109525] typo in views::as_const::operator()

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:4dc8c0b62d91d239b88cc81bbb8f4fbde317fde6

commit r13-7212-g4dc8c0b62d91d239b88cc81bbb8f4fbde317fde6
Author: Patrick Palka <ppalka@redhat.com>
Date:   Tue Apr 18 07:21:07 2023 -0400

    libstdc++: Fix typo in views::as_const's operator() [PR109525]

            PR libstdc++/109525

    libstdc++-v3/ChangeLog:

            * include/std/ranges (views::_AsConst::operator()): Add
            missing const to constant_range test.
            * testsuite/std/ranges/adaptors/as_const/1.cc (test02):
            Improve formatting.  Adjust expected type of v2.
            (test03): New test.

    (cherry picked from commit 4ec4ceafcc04ec7bafb1857cf6d491030440a765)

[Bug libstdc++/109525] typo in views::as_const::operator()

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109525

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |13.0

--- Comment #4 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed for GCC 13, thanks!