[Bug c++/109899] New: ICE in check_noexcept_r, at cp/except.cc:1065

[Bug c++/109899] New: ICE in check_noexcept_r, at cp/except.cc:1065

[jeanmichael.celerier at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

            Bug ID: 109899
           Summary: ICE in check_noexcept_r, at cp/except.cc:1065
           Product: gcc
           Version: 13.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jeanmichael.celerier at gmail dot com
  Target Milestone: ---

Created attachment 55106
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55106&action=edit
Preprocessed source causing the bug

Repro: 

    #include <array>
    #include <string>
    #include <boost/pfr.hpp>
    struct T {
      struct {
        // Works fine for value == std::array<int, 5> or std::string directly
        std::array<std::string, 5> value;
      } X;
    };

    int main() {
      boost::pfr::detail::fields_count<T>();
    }

On godbolt: https://gcc.godbolt.org/z/xd48obMTv

Preprocessed source attached.

g++ 13.1.1 up-to-date in Arch Linux as of today, and it fails on any Boost
version that has <boost/pfr.hpp> (from 1.75 to 1.82+).

[Bug c++/109899] ICE in check_noexcept_r, at cp/except.cc:1065

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reducing ...

[Bug c++/109899] [12/13/14 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-05-17
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |12.4
      Known to work|                            |11.3.0
            Summary|ICE in check_noexcept_r, at |[12/13/14 Regression] ICE
                   |cp/except.cc:1065           |in check_noexcept_r, at
                   |                            |cp/except.cc:1065
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
      Known to fail|                            |12.1.0

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced testcase to this valid testcase:
```
class class0 {
  ~class0() noexcept {}
  friend class class1;
};
struct class1 {
  class0 field0;
  class1();
  ~class1();
};
template <typename T> using array = T[1]; 
template <int N>
auto f1() noexcept
  -> decltype(sizeof(array<class1>{}));

```

[Bug c++/109899] [12/13/14 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
A little further reduced:
```
struct class1 {
  class1();
  ~class1();
};
template <typename T> using array = T[1]; 
template <int N>
auto f1() -> decltype(sizeof(array<class1>{}));
```

[Bug c++/109899] [12/13/14 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug c++/109899] [12/13/14 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu.org,
                   |                            |mpolacek at gcc dot gnu.org
           Keywords|needs-bisection             |

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Seems to have started with r12-7069:

commit 119cea98f664764cce04963243c39c8f6d797d33
Author: Jason Merrill <jason@redhat.com>
Date:   Wed Feb 2 18:36:41 2022 -0500

    c++: assignment, aggregate, array [PR104300]

[Bug c++/109899] [12/13/14 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

--- Comment #5 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
(gdb) up
#1  0x0000000000e5de6f in check_noexcept_r (tp=0x7fffffffa0a8,
walk_subtrees=0x7fffffff9f94)
    at /home/mpolacek/src/gcc/gcc/cp/except.cc:1065
1065          gcc_assert (INDIRECT_TYPE_P (type));
(gdb) p type
$1 = <method_type 0x7fffea3c4dc8>
(gdb) pge
void class1::<T40f> (struct class1 *)

[Bug c++/109899] [12/13/14 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cuzdav at gmail dot com

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 110810 has been marked as a duplicate of this bug. ***

[Bug c++/109899] [12/13/14 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced further (which shows PR 110810 is the same here):
```
struct class1 {
  class1();
  ~class1();
};
using array = class1[1]; 
template <int N>
void f()
{
  array{};
}
```

[Bug c++/109899] [12/13/14 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[lozko.roma at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

Roman Lozko <lozko.roma at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lozko.roma at gmail dot com

--- Comment #8 from Roman Lozko <lozko.roma at gmail dot com> ---
Found this issue after reducing my example with GCC 13.2 to be an exact copy of
previous comment. Dunno how to help so just notifying that the bug still
exists, I guess.

[Bug c++/109899] [12/13/14 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:d33c3b5ac9b9b3e314ae9118d483ade7e91a80a5

commit r14-7260-gd33c3b5ac9b9b3e314ae9118d483ade7e91a80a5
Author: Patrick Palka <ppalka@redhat.com>
Date:   Mon Jan 15 16:49:19 2024 -0500

    c++: non-dep array list-init w/ non-triv dtor [PR109899]

    The get_target_expr call added in r12-7069-g119cea98f66476 causes us
    for the below testcase to call build_vec_delete in a template context,
    which builds a templated destructor call and checks expr_noexcept_p for
    it, which ICEs because the call has templated form.

    Much of the work of build_vec_delete however is code generation and thus
    will just get discarded in a template context, and that includes the
    code guarded by expr_noexcept_p.  So this patch narrowly fixes this ICE
    by eliding the expr_noexcept_p call when in a template context.

            PR c++/109899

    gcc/cp/ChangeLog:

            * init.cc (build_vec_delete_1): Assume expr_noexcept_p returns
            false in a template context.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/initlist-array21.C: New test.

    Reviewed-by: Jason Merrill <jason@redhat.com>

[Bug c++/109899] [12/13 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12/13/14 Regression] ICE   |[12/13 Regression] ICE in
                   |in check_noexcept_r, at     |check_noexcept_r, at
                   |cp/except.cc:1065           |cp/except.cc:1065
                 CC|                            |ppalka at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |ppalka at gcc dot gnu.org

--- Comment #10 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed on trunk so far.

[Bug c++/109899] [12/13 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug c++/109899] [12/13 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:766ea9da8ccff3786ec5df414046f6b1640e7e01

commit r13-8224-g766ea9da8ccff3786ec5df414046f6b1640e7e01
Author: Patrick Palka <ppalka@redhat.com>
Date:   Mon Jan 15 16:49:19 2024 -0500

    c++: non-dep array list-init w/ non-triv dtor [PR109899]

    The get_target_expr call added in r12-7069-g119cea98f66476 causes us
    for the below testcase to call build_vec_delete in a template context,
    which builds a templated destructor call and checks expr_noexcept_p for
    it, which ICEs because the call has templated form.

    Much of the work of build_vec_delete however is code generation and thus
    will just get discarded in a template context, and that includes the
    code guarded by expr_noexcept_p.  So this patch narrowly fixes this ICE
    by eliding the expr_noexcept_p call when in a template context.

            PR c++/109899

    gcc/cp/ChangeLog:

            * init.cc (build_vec_delete_1): Assume expr_noexcept_p returns
            false in a template context.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/initlist-array21.C: New test.

    Reviewed-by: Jason Merrill <jason@redhat.com>
    (cherry picked from commit d33c3b5ac9b9b3e314ae9118d483ade7e91a80a5)

[Bug c++/109899] [12/13 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

--- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:6477b3b9c3e5be5dfe549dcb7b3cef2b49e3690c

commit r12-10098-g6477b3b9c3e5be5dfe549dcb7b3cef2b49e3690c
Author: Patrick Palka <ppalka@redhat.com>
Date:   Mon Jan 15 16:49:19 2024 -0500

    c++: non-dep array list-init w/ non-triv dtor [PR109899]

    The get_target_expr call added in r12-7069-g119cea98f66476 causes us
    for the below testcase to call build_vec_delete in a template context,
    which builds a templated destructor call and checks expr_noexcept_p for
    it, which ICEs because the call has templated form.

    Much of the work of build_vec_delete however is code generation and thus
    will just get discarded in a template context, and that includes the
    code guarded by expr_noexcept_p.  So this patch narrowly fixes this ICE
    by eliding the expr_noexcept_p call when in a template context.

            PR c++/109899

    gcc/cp/ChangeLog:

            * init.cc (build_vec_delete_1): Assume expr_noexcept_p returns
            false in a template context.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/initlist-array21.C: New test.

    Reviewed-by: Jason Merrill <jason@redhat.com>
    (cherry picked from commit d33c3b5ac9b9b3e314ae9118d483ade7e91a80a5)

[Bug c++/109899] [12/13 Regression] ICE in check_noexcept_r, at cp/except.cc:1065

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109899

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #13 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed for GCC 12.4 / 13.3 / 14, thanks for the bug report.