public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/110758] New: 8% hmmer regression on zen1 and zen3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56) and g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24)
@ 2023-07-20 22:02 hubicka at gcc dot gnu.org
2023-07-20 22:12 ` [Bug target/110758] [14 Regression] 8% hmmer regression on zen1/3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56); " pinskia at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: hubicka at gcc dot gnu.org @ 2023-07-20 22:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110758
Bug ID: 110758
Summary: 8% hmmer regression on zen1 and zen3 with -Ofast
-march=native -flto between g:8377cf1bf41a0a9d
(2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06
16:56) and g:d76d19c9bc5ef113 (2023-07-16 00:16) and
g:a5088dc3f5ef73c8 (2023-07-17 03:24)
Product: gcc
Version: 13.1.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: hubicka at gcc dot gnu.org
Target Milestone: ---
https://lnt.opensuse.org/db_default/v4/SPEC/graph?plot.0=476.180.0
the earlier jump looks like random code layout change.
Later jump is also seen with PGO
https://lnt.opensuse.org/db_default/v4/SPEC/graph?plot.0=474.180.0
and -O2
https://lnt.opensuse.org/db_default/v4/SPEC/graph?plot.0=469.180.0
zen1 machine
https://lnt.opensuse.org/db_default/v4/SPEC/graph?plot.0=289.180.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/110758] [14 Regression] 8% hmmer regression on zen1/3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56); g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24)
2023-07-20 22:02 [Bug target/110758] New: 8% hmmer regression on zen1 and zen3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56) and g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24) hubicka at gcc dot gnu.org
@ 2023-07-20 22:12 ` pinskia at gcc dot gnu.org
2023-07-20 22:13 ` pinskia at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-20 22:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110758
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |26163
Version|13.1.0 |14.0
Keywords| |missed-optimization
Target Milestone|--- |14.0
Summary|8% hmmer regression on zen1 |[14 Regression] 8% hmmer
|and zen3 with -Ofast |regression on zen1/3 with
|-march=native -flto between |-Ofast -march=native -flto
|g:8377cf1bf41a0a9d |between g:8377cf1bf41a0a9d
|(2023-07-05 01:46) and |(2023-07-05 01:46) and
|g:3a61ca1b9256535e |g:3a61ca1b9256535e
|(2023-07-06 16:56) and |(2023-07-06 16:56);
|g:d76d19c9bc5ef113 |g:d76d19c9bc5ef113
|(2023-07-16 00:16) and |(2023-07-16 00:16) and
|g:a5088dc3f5ef73c8 |g:a5088dc3f5ef73c8
|(2023-07-17 03:24) |(2023-07-17 03:24)
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=26163
[Bug 26163] [meta-bug] missed optimization in SPEC (2k17, 2k and 2k6 and 95)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/110758] [14 Regression] 8% hmmer regression on zen1/3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56); g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24)
2023-07-20 22:02 [Bug target/110758] New: 8% hmmer regression on zen1 and zen3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56) and g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24) hubicka at gcc dot gnu.org
2023-07-20 22:12 ` [Bug target/110758] [14 Regression] 8% hmmer regression on zen1/3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56); " pinskia at gcc dot gnu.org
@ 2023-07-20 22:13 ` pinskia at gcc dot gnu.org
2023-07-21 17:13 ` Jan Hubicka
2023-07-21 17:13 ` hubicka at ucw dot cz
` (2 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-20 22:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110758
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I suspect this is most likely the profile updates changes ...
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Bug target/110758] [14 Regression] 8% hmmer regression on zen1/3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56); g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24)
2023-07-20 22:13 ` pinskia at gcc dot gnu.org
@ 2023-07-21 17:13 ` Jan Hubicka
0 siblings, 0 replies; 7+ messages in thread
From: Jan Hubicka @ 2023-07-21 17:13 UTC (permalink / raw)
To: pinskia at gcc dot gnu.org; +Cc: gcc-bugs
> I suspect this is most likely the profile updates changes ...
Quite possibly. The goal of this excercise is to figure out if there are
some bugs in profile estimate or whether passes somehow preffer broken
profile or if it is just back luck.
Looking at sphinx and fatigue it seems that LRA really may preffer
increased profile counts in peeled vectorized loop since it does not
understand the fact that putting spill on critical path through the
dependnecy graph of the code is not good for out of order execution.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/110758] [14 Regression] 8% hmmer regression on zen1/3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56); g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24)
2023-07-20 22:02 [Bug target/110758] New: 8% hmmer regression on zen1 and zen3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56) and g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24) hubicka at gcc dot gnu.org
2023-07-20 22:12 ` [Bug target/110758] [14 Regression] 8% hmmer regression on zen1/3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56); " pinskia at gcc dot gnu.org
2023-07-20 22:13 ` pinskia at gcc dot gnu.org
@ 2023-07-21 17:13 ` hubicka at ucw dot cz
2023-07-26 12:19 ` hubicka at gcc dot gnu.org
2023-07-31 7:39 ` hubicka at gcc dot gnu.org
4 siblings, 0 replies; 7+ messages in thread
From: hubicka at ucw dot cz @ 2023-07-21 17:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110758
--- Comment #2 from Jan Hubicka <hubicka at ucw dot cz> ---
> I suspect this is most likely the profile updates changes ...
Quite possibly. The goal of this excercise is to figure out if there are
some bugs in profile estimate or whether passes somehow preffer broken
profile or if it is just back luck.
Looking at sphinx and fatigue it seems that LRA really may preffer
increased profile counts in peeled vectorized loop since it does not
understand the fact that putting spill on critical path through the
dependnecy graph of the code is not good for out of order execution.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/110758] [14 Regression] 8% hmmer regression on zen1/3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56); g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24)
2023-07-20 22:02 [Bug target/110758] New: 8% hmmer regression on zen1 and zen3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56) and g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24) hubicka at gcc dot gnu.org
` (2 preceding siblings ...)
2023-07-21 17:13 ` hubicka at ucw dot cz
@ 2023-07-26 12:19 ` hubicka at gcc dot gnu.org
2023-07-31 7:39 ` hubicka at gcc dot gnu.org
4 siblings, 0 replies; 7+ messages in thread
From: hubicka at gcc dot gnu.org @ 2023-07-26 12:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110758
Jan Hubicka <hubicka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2023-07-26
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Regression between
g:d76d19c9bc5ef113 (2023-07-16 00:16) and
g:a5088dc3f5ef73c8 (2023-07-17 03:24)
seems to be gone.
The range is:
1c6231c05bdccab3 (2023-07-21 03:06) and
f33fdf9e7c038639 (2023-07-23 00:17)
Looking at the patches in range, it is likely the flat profile detection in
vectorizer:
Author: Jan Hubicka <jh@suse.cz>
Date: Fri Jul 21 19:38:26 2023 +0200
Avoid scaling flat loop profiles of vectorized loops
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/110758] [14 Regression] 8% hmmer regression on zen1/3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56); g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24)
2023-07-20 22:02 [Bug target/110758] New: 8% hmmer regression on zen1 and zen3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56) and g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24) hubicka at gcc dot gnu.org
` (3 preceding siblings ...)
2023-07-26 12:19 ` hubicka at gcc dot gnu.org
@ 2023-07-31 7:39 ` hubicka at gcc dot gnu.org
4 siblings, 0 replies; 7+ messages in thread
From: hubicka at gcc dot gnu.org @ 2023-07-31 7:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110758
Jan Hubicka <hubicka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixing profile update in loop distribution fixed the regression and we get
better result than before. The first tester still shows regression compared to
July last year, but we have PR106293 to track this.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-07-31 7:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-20 22:02 [Bug target/110758] New: 8% hmmer regression on zen1 and zen3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56) and g:d76d19c9bc5ef113 (2023-07-16 00:16) and g:a5088dc3f5ef73c8 (2023-07-17 03:24) hubicka at gcc dot gnu.org
2023-07-20 22:12 ` [Bug target/110758] [14 Regression] 8% hmmer regression on zen1/3 with -Ofast -march=native -flto between g:8377cf1bf41a0a9d (2023-07-05 01:46) and g:3a61ca1b9256535e (2023-07-06 16:56); " pinskia at gcc dot gnu.org
2023-07-20 22:13 ` pinskia at gcc dot gnu.org
2023-07-21 17:13 ` Jan Hubicka
2023-07-21 17:13 ` hubicka at ucw dot cz
2023-07-26 12:19 ` hubicka at gcc dot gnu.org
2023-07-31 7:39 ` hubicka at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).