[Bug libgcc/110775] New: arm-openwrt-linux-uclibcgnueabi bug

[Bug libgcc/110775] New: arm-openwrt-linux-uclibcgnueabi bug

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110775

            Bug ID: 110775
           Summary: arm-openwrt-linux-uclibcgnueabi bug
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgcc
          Assignee: unassigned at gcc dot gnu.org
          Reporter: unlvsur at live dot com
  Target Milestone: ---

In file included from
/home/cqwrteur/toolchains/x86_64-pc-linux-gnu/arm-openwrt-linux-uclibcgnueabi/arm-openwrt-linux-uclibcgnueabi/include/bits/sched.h:117,
                 from
/home/cqwrteur/toolchains/x86_64-pc-linux-gnu/arm-openwrt-linux-uclibcgnueabi/arm-openwrt-linux-uclibcgnueabi/include/sched.h:34,
                 from
/home/cqwrteur/toolchains/x86_64-pc-linux-gnu/arm-openwrt-linux-uclibcgnueabi/arm-openwrt-linux-uclibcgnueabi/include/pthread.h:24,
                 from ./gthr-default.h:35,
                 from /home/cqwrteur/toolchains_build/gcc/libgcc/gthr.h:148,
                 from /home/cqwrteur/toolchains_build/gcc/libgcc/emutls.c:31:
/home/cqwrteur/toolchains/x86_64-pc-linux-gnu/arm-openwrt-linux-uclibcgnueabi/arm-openwrt-linux-uclibcgnueabi/include/stdlib.h:498:24:
error: macro "abort" passed 1 arguments, but takes just 0
  498 | extern void abort (void) __THROW __attribute__ ((__noreturn__));
      |                        ^
In file included from /home/cqwrteur/toolchains_build/gcc/libgcc/emutls.c:27:
/home/cqwrteur/toolchains_build/gcc/libgcc/../gcc/tsystem.h:62:9: note: macro
"abort" defined here
   62 | #define abort() __builtin_trap ()
      |         ^~~~~
make[2]: *** [Makefile:928: _gcov_execlp.o] Error 1
make[2]: *** [/home/cqwrteur/toolchains_build/gcc/libgcc/shared-object.mk:14:
emutls.o] Error 1
make[2]: Leaving directory
'/home/cqwrteur/toolchains_build/gcc_build/native/arm-openwrt-linux-uclibcgnueabi/artifacts/targetbuild/arm-openwrt-linux-uclibcgnueabi/gcc/arm-openwrt-linux-uclibcgnueabi/libgcc'
make[1]: *** [Makefile:16036: all-target-libgcc] Error 2
make[1]: Leaving directory
'/home/cqwrteur/toolchains_build/gcc_build/native/arm-openwrt-linux-uclibcgnueabi/artifacts/targetbuild/arm-openwrt-linux-uclibcgnueabi/gcc'
make: *** [Makefile:1055: all] Error 2

[Bug libgcc/110775] [12/13/14 Regression] abort define causing issues in tsystem.h

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110775

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-07-22
            Summary|arm-openwrt-linux-uclibcgnu |[12/13/14 Regression] abort
                   |eabi bug                    |define causing issues in
                   |                            |tsystem.h
             Status|UNCONFIRMED                 |NEW
   Target Milestone|---                         |12.4
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This was broken by r12-3220-gcaf81d3b57501b1f .

Though it is interesting that uclibc is causing to use emutls.c here ...

[Bug libgcc/110775] [12/13/14 Regression] abort define causing issues in tsystem.h

[sebastian.huber@embedded-brains.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110775

Sebastian Huber <sebastian.huber@embedded-brains.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebastian.huber@embedded-br
                   |                            |ains.de

--- Comment #2 from Sebastian Huber <sebastian.huber@embedded-brains.de> ---
In tsystem.h we have:

#ifdef inhibit_libc

...

#ifndef abort
#define abort() __builtin_trap ()
#endif

Does it make sense to define inhibit_libc and then later use <stdlib.h> and
<pthread.h>?

[Bug libgcc/110775] [12/13/14 Regression] abort define causing issues in tsystem.h

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110775

--- Comment #3 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
Perhaps we could use 

#define abort __builtin_trap

?

A quick check seems to suggest this will work ok.

[Bug libgcc/110775] [12/13/14/15 Regression] abort define causing issues in tsystem.h

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110775

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
No, we don't want people to redeclare __builtin_* functions.

[Bug libgcc/110775] [12/13/14/15 Regression] abort define causing issues in tsystem.h

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110775

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
What could work (but still hacky) would be
#define abort(...) gcc_target_abort ()
extern inline __attribute__((__always_inline__)) void
gcc_target_abort (void)
{
  __builtin_abort ();
}