[Bug target/111001] New: SH: ICE during RTL pass: sh_treg_combine2

[Bug target/111001] New: SH: ICE during RTL pass: sh_treg_combine2

[wbx at openadk dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

            Bug ID: 111001
           Summary: SH: ICE during RTL pass: sh_treg_combine2
           Product: gcc
           Version: 13.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: wbx at openadk dot org
  Target Milestone: ---

Created attachment 55731
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55731&action=edit
preprocessed source code of rw_bitmaps.c

Hi,

following compile error occurs for Buildroot targeting sh4-linux-gnu for the
e2fsprogs package:
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
during RTL pass: sh_treg_combine2
rw_bitmaps.c: In function ‘read_bitmaps_range_start’:
rw_bitmaps.c:447:1: internal compiler error: Aborted
  447 | }
      | ^
0x7fe95c926f8f ???
        ./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0x7fe95c975ccc __pthread_kill_implementation
        ./nptl/pthread_kill.c:44
0x7fe95c926ef1 __GI_raise
        ../sysdeps/posix/raise.c:26
0x7fe95c911471 __GI_abort
        ./stdlib/abort.c:79
0x7fe95c912189 __libc_start_call_main
        ../sysdeps/nptl/libc_start_call_main.h:58
0x7fe95c912244 __libc_start_main_impl
        ../csu/libc-start.c:381
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.

Attached is the preprocessed rw_bitmaps.c file.
The problem exist only for -O1/-O2/-O3, using -Os/O0 does not trigger the ICE.
And it is an new issue in gcc 13.2.0, it does not happen for 12.3.0. 

Do you need more information, do not hesitate to ask.
 best regards
  Waldemar

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[wbx at openadk dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #1 from Waldemar Brodkorb <wbx at openadk dot org> ---
/home/browa22-ext/e2fsprogs/output/host/bin/sh4-buildroot-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/home/browa22-ext/e2fsprogs/output/host/bin/sh4-buildroot-linux-gnu-gcc.br_real
COLLECT_LTO_WRAPPER=/home/browa22-ext/e2fsprogs/output/host/libexec/gcc/sh4-buildroot-linux-gnu/13.2.0/lto-wrapper
Target: sh4-buildroot-linux-gnu
Configured with: ./configure --prefix=/home/browa22-ext/e2fsprogs/output/host
--sysconfdir=/home/browa22-ext/e2fsprogs/output/host/etc --enable-static
--target=sh4-buildroot-linux-gnu
--with-sysroot=/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot
--enable-__cxa_atexit --with-gnu-ld --disable-libssp --disable-multilib
--disable-decimal-float --enable-plugins --enable-lto
--with-gmp=/home/browa22-ext/e2fsprogs/output/host
--with-mpc=/home/browa22-ext/e2fsprogs/output/host
--with-mpfr=/home/browa22-ext/e2fsprogs/output/host
--with-pkgversion='Buildroot 2023.08-rc1-68-g27dc493780-dirty'
--with-bugurl=http://bugs.buildroot.net/ --without-zstd --disable-libquadmath
--disable-libquadmath-support --enable-tls --enable-threads --without-isl
--without-cloog --enable-languages=c
--with-build-time-tools=/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/bin
--with-multilib-list=m4,m4-nofpu --enable-shared --disable-libgomp
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 13.2.0 (Buildroot 2023.08-rc1-68-g27dc493780-dirty) 
COMPILER_PATH=/home/browa22-ext/e2fsprogs/output/host/libexec/gcc/sh4-buildroot-linux-gnu/13.2.0/:/home/browa22-ext/e2fsprogs/output/host/libexec/gcc/sh4-buildroot-linux-gnu/13.2.0/:/home/browa22-ext/e2fsprogs/output/host/libexec/gcc/sh4-buildroot-linux-gnu/:/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/:/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/:/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/../../../../sh4-buildroot-linux-gnu/bin/
LIBRARY_PATH=/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/:/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/../../../../sh4-buildroot-linux-gnu/lib/!m4/:/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/../../../../sh4-buildroot-linux-gnu/lib/:/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot/lib/:/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot/usr/lib/
COLLECT_GCC_OPTIONS='--sysroot=/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot'
'-fstack-protector-strong' '-fPIE' '-pie' '-v' '-dumpdir' 'a.'

/home/browa22-ext/e2fsprogs/output/host/libexec/gcc/sh4-buildroot-linux-gnu/13.2.0/collect2
-plugin
/home/browa22-ext/e2fsprogs/output/host/libexec/gcc/sh4-buildroot-linux-gnu/13.2.0/liblto_plugin.so
-plugin-opt=/home/browa22-ext/e2fsprogs/output/host/libexec/gcc/sh4-buildroot-linux-gnu/13.2.0/lto-wrapper
-plugin-opt=-fresolution=/tmp/ccQ7cSBB.res -plugin-opt=-pass-through=-lgcc
-plugin-opt=-pass-through=-lgcc_s -plugin-opt=-pass-through=-lc
-plugin-opt=-pass-through=-lgcc -plugin-opt=-pass-through=-lgcc_s
--sysroot=/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot
--eh-frame-hdr -m shlelf_linux -dynamic-linker /lib/ld-linux.so.2 -pie
/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot/usr/lib/Scrt1.o
/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot/usr/lib/crti.o
/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/crtbeginS.o
-L/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0
-L/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/../../../../sh4-buildroot-linux-gnu/lib/!m4
-L/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/../../../../sh4-buildroot-linux-gnu/lib
-L/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot/lib
-L/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot/usr/lib
-z now -z relro -lgcc --push-state --as-needed -lgcc_s --pop-state -lc -lgcc
--push-state --as-needed -lgcc_s --pop-state
/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/crtendS.o
/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot/usr/lib/crtn.o
/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/../../../../sh4-buildroot-linux-gnu/bin/ld:
/home/browa22-ext/e2fsprogs/output/host/sh4-buildroot-linux-gnu/sysroot/usr/lib/Scrt1.o:
in function `L_main':
start.os:(.text+0x1c): undefined reference to `main'
/home/browa22-ext/e2fsprogs/output/host/lib/gcc/sh4-buildroot-linux-gnu/13.2.0/../../../../sh4-buildroot-linux-gnu/bin/ld:
BFD (GNU Binutils) 2.40 assertion fail elf32-sh.c:3924
collect2: error: ld returned 1 exit status
browa22-ext@lxwbrodk:~$
/home/browa22-ext/e2fsprogs/output/host/bin/sh4-buildroot-linux-gnu-ld -v
GNU ld (GNU Binutils) 2.40

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

Oleg Endo <olegendo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-10-13
     Ever confirmed|0                           |1
                 CC|                            |olegendo at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Oleg Endo <olegendo at gcc dot gnu.org> ---
I've briefly tried on a local gcc version 13.1.1 20230714 

While it doesn't crash, the sh_treg_combine2 pass seems to be stuck in an
infinite loop.  It produces a log file > 200 MByte.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #3 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to Oleg Endo from comment #2)
> I've briefly tried on a local gcc version 13.1.1 20230714 
> 
> While it doesn't crash, the sh_treg_combine2 pass seems to be stuck in an
> infinite loop.  It produces a log file > 200 MByte.

It trips on the following insn:

(insn 1431 1430 179 19 (set (reg/v:DI 264 [ blk_cnt ])
        (reg/v:DI 264 [ blk_cnt ])) "rw_bitmaps.c":341:11 -1
     (nil))

... which is a reg-reg move on itself (i.e. a nop).  For some reason this insn
is emitted by the split1 pass, which runs before sh_treg_combine2.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #4 from Oleg Endo <olegendo at gcc dot gnu.org> ---
Created attachment 56164
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56164&action=edit
sh_pr11001_fix.patch

Can you please try this patch?  It should solve the problem, but not sure if
there could be any unexpected side effects.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[glaubitz at physik dot fu-berlin.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #5 from John Paul Adrian Glaubitz <glaubitz at physik dot fu-berlin.de> ---
(In reply to Oleg Endo from comment #4)
> Created attachment 56164 [details]
> sh_pr11001_fix.patch
> 
> Can you please try this patch?  It should solve the problem, but not sure if
> there could be any unexpected side effects.

I can confirm that this patch fixes the build of e2fsprogs with gcc-13 for me.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[glaubitz at physik dot fu-berlin.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #6 from John Paul Adrian Glaubitz <glaubitz at physik dot fu-berlin.de> ---
*** Bug 111892 has been marked as a duplicate of this bug. ***

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #7 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to John Paul Adrian Glaubitz from comment #5)
> 
> I can confirm that this patch fixes the build of e2fsprogs with gcc-13 for
> me.

Great, thanks!  Do you have an option to run a compiler bootstrap or other
runtime test on sh4-linux with this?

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[glaubitz at physik dot fu-berlin.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #8 from John Paul Adrian Glaubitz <glaubitz at physik dot fu-berlin.de> ---
(In reply to Oleg Endo from comment #7)
> (In reply to John Paul Adrian Glaubitz from comment #5)
> > 
> > I can confirm that this patch fixes the build of e2fsprogs with gcc-13 for
> > me.
> 
> Great, thanks!  Do you have an option to run a compiler bootstrap or other
> runtime test on sh4-linux with this?

I built gcc-13 natively with the patch applied with a full bootstrap including
stage2 and stage3. Full build log available in [1].

> [1] https://people.debian.org/~glaubitz/gcc-13_13.2.0-2+sh4_sh4.build.gz

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #9 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to John Paul Adrian Glaubitz from comment #8)
> 
> I built gcc-13 natively with the patch applied with a full bootstrap
> including stage2 and stage3. Full build log available in [1].
> 
> > [1] https://people.debian.org/~glaubitz/gcc-13_13.2.0-2+sh4_sh4.build.gz

Perfect! Thanks!

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[glaubitz at physik dot fu-berlin.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #10 from John Paul Adrian Glaubitz <glaubitz at physik dot fu-berlin.de> ---
(In reply to Oleg Endo from comment #9)
> (In reply to John Paul Adrian Glaubitz from comment #8)
> > 
> > I built gcc-13 natively with the patch applied with a full bootstrap
> > including stage2 and stage3. Full build log available in [1].
> > 
> > > [1] https://people.debian.org/~glaubitz/gcc-13_13.2.0-2+sh4_sh4.build.gz
> 
> Perfect! Thanks!

Do we need anything else before the fix can be merged?

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Oleg Endo <olegendo@gcc.gnu.org>:

https://gcc.gnu.org/g:267e369afbb963d8d84d7a9f0cb9fb18672d99a8

commit r14-4862-g267e369afbb963d8d84d7a9f0cb9fb18672d99a8
Author: Oleg Endo <olegendo@gcc.gnu.org>
Date:   Mon Oct 23 22:08:37 2023 +0900

    SH: Fix PR 111001

    gcc/ChangeLog:

            PR target/111001
            * config/sh/sh_treg_combine.cc
(sh_treg_combine::record_set_of_reg):
            Skip over nop move insns.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Oleg Endo
<olegendo@gcc.gnu.org>:

https://gcc.gnu.org/g:4e1320e4af413b7126f3b998096f60f8b7d5cb32

commit r13-7976-g4e1320e4af413b7126f3b998096f60f8b7d5cb32
Author: Oleg Endo <olegendo@gcc.gnu.org>
Date:   Mon Oct 23 22:08:37 2023 +0900

    SH: Fix PR 111001

    gcc/ChangeLog:

            PR target/111001
            * config/sh/sh_treg_combine.cc
(sh_treg_combine::record_set_of_reg):
            Skip over nop move insns.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Oleg Endo
<olegendo@gcc.gnu.org>:

https://gcc.gnu.org/g:4414818f4e5de54ea3c353e2ebb2e79a89ae211b

commit r12-9938-g4414818f4e5de54ea3c353e2ebb2e79a89ae211b
Author: Oleg Endo <olegendo@gcc.gnu.org>
Date:   Mon Oct 23 22:08:37 2023 +0900

    SH: Fix PR 111001

    gcc/ChangeLog:

            PR target/111001
            * config/sh/sh_treg_combine.cc
(sh_treg_combine::record_set_of_reg):
            Skip over nop move insns.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Oleg Endo
<olegendo@gcc.gnu.org>:

https://gcc.gnu.org/g:626bb2e165daa88f5c7cd66b9db49f03921474a9

commit r11-11075-g626bb2e165daa88f5c7cd66b9db49f03921474a9
Author: Oleg Endo <olegendo@gcc.gnu.org>
Date:   Mon Oct 23 22:08:37 2023 +0900

    SH: Fix PR 111001

    gcc/ChangeLog:

            PR target/111001
            * config/sh/sh_treg_combine.cc
(sh_treg_combine::record_set_of_reg):
            Skip over nop move insns.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #15 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to John Paul Adrian Glaubitz from comment #10)
> 
> Do we need anything else before the fix can be merged?

No, should be fine.  I'll leave this PR open for a while in case anything else
related pops up.  Thanks for testing.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[glaubitz at physik dot fu-berlin.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #16 from John Paul Adrian Glaubitz <glaubitz at physik dot fu-berlin.de> ---
(In reply to Oleg Endo from comment #15)
> (In reply to John Paul Adrian Glaubitz from comment #10)
> > 
> > Do we need anything else before the fix can be merged?
> 
> No, should be fine.  I'll leave this PR open for a while in case anything
> else related pops up.  Thanks for testing.

Just saw the branch updates, thanks! FWIW, I did observe this issue in gcc-13
only but not gcc-11 or gcc-12. But that might be owed to the fact that Debian's
gcc-11 and gcc-12 packages had not received the latest branch updates yet.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

--- Comment #17 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to John Paul Adrian Glaubitz from comment #16)

> Just saw the branch updates, thanks! FWIW, I did observe this issue in
> gcc-13 only but not gcc-11 or gcc-12. But that might be owed to the fact
> that Debian's gcc-11 and gcc-12 packages had not received the latest branch
> updates yet.

Yes, I know it has been observed on the latest GCC-13 only.  It was an
oversight in the code from the beginning, which got triggered by another change
in the compiler.  I haven't checked which change exactly, but I guess it must
have been some backported change. So if the same/similar thing gets backported
to GCC-11 or GCC-12 it might trigger this bug there, too.  Hence the preventive
measure.  It's a rather obvious bug/fix, so should be safe.

[Bug target/111001] SH: ICE during RTL pass: sh_treg_combine2

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111001

Oleg Endo <olegendo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #18 from Oleg Endo <olegendo at gcc dot gnu.org> ---
Should be fixed.