[Bug target/111170] New: Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library)

[Bug target/111170] New: Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library)

[jdx at o2 dot pl]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

            Bug ID: 111170
           Summary: Malformed manifest does not allow to run gcc on
                    Windows XP (Accessing a corrupted shared library)
           Product: gcc
           Version: 13.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jdx at o2 dot pl
                CC: costas.argyris at gmail dot com
  Target Milestone: ---
            Target: i686-w64-mingw32 @ Windows XP
             Build: i686-w64-mingw32 @ Windows 10

I wanted to build gcc 13.2 with intention to run it on an old Windows
XP/Pentium-M machine. My build environment is MSYS2/MinGW32 @ Windows 10.
Everything went fine and I could run resulting binaries on the build machine
under MinGW32 terminal. However when I tried to run them on the target machine,
I got "bash: ./mingw-gcc/bin/gcc: Accessing a corrupted shared library". After
a few days of heavy fight I found out that this is due to malformed manifest
embedded in some (not all!) gcc executables. Newer version of Windows are more
forgiving and can tolerate malformed manifests while Windows XP is not; that's
why I could run freshly built gcc on my Windows 10 box. Using a resource editor
I have replaced malformed manifests with a default one (taken from
https://packages.msys2.org/base/mingw-w64-windows-default-manifest) and now
everything runs fine on XP.

The malformed manifest comes from
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=d11e088210a551235d3937f867ee1c8b19d02290
related to PR108865. I think the proper solution is to merge default manifest
from MSYS and the one mentioned in the diff above.

[Bug target/111170] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library)

[costas.argyris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

Costas Argyris <costas.argyris at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lh_mouse at 126 dot com

--- Comment #1 from Costas Argyris <costas.argyris at gmail dot com> ---
Looks like '... @ Windows XP' is the Host, not the Target, in the PR.    Target
seems irrelevant here.

LH, is this the issue you originally mentioned about my change inadvertently
replacing the default MSYS2 manifest?

[Bug target/111170] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library)

[lh_mouse at 126 dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #2 from LIU Hao <lh_mouse at 126 dot com> ---
(In reply to Costas Argyris from comment #1)
> Looks like '... @ Windows XP' is the Host, not the Target, in the PR.   
> Target seems irrelevant here.
> 
> LH, is this the issue you originally mentioned about my change inadvertently
> replacing the default MSYS2 manifest?

It looks like that the current GCC manifest contains values that their host
does not support. In theory it should be ignored; however if it causes errors,
it might be worth looking into.

The MSYS2 manifest contains a `compatibility` section that is not supported by
XP and Vista and is ignored [1], so it has no effect.


[1]
https://learn.microsoft.com/en-us/windows/win32/win7appqual/compatibility---application-manifest#manifestation-of-change

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[lh_mouse at 126 dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #3 from LIU Hao <lh_mouse at 126 dot com> ---
Costas, would you like to provide a configure option to exclude that manifest?

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[costas.argyris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #4 from Costas Argyris <costas.argyris at gmail dot com> ---
A couple of comments:

1) Isn't Windows XP officially not supported any more?    If that is the case,
does it make sense to introduce a new configure option solely to deal with an
unsupported host?    I'm not even sure why this is called a regression, given
that it breaks something that is not officially supported.

2) Would it be easier if, instead of excluding the manifest via a new configure
option, we somehow made the manifest file itself smart enough to ignore itself
when running on Windows XP?

Based on your comment above about the compatibility section in the MSYS2
manifest, it sounds like the GCC manifest could get a similar compatibility
section that basically says "ignore this manifest when running on XP (or
earlier)" such that it doesn't break in these old Windows versions.

I searched for the MSYS2 manifest and I think it sources it from cygwin:

https://sourceware.org/git/?p=cygwin-apps/windows-default-manifest.git;a=blob;f=default-manifest.rc;h=2c4ddf4783b953afaf7df9473450bf95842d1911;hb=HEAD

which has separate entries for all the Windows versions, marking them as
'supportedOS'.

Would it be possible to do this in the GCC manifest and solve this problem, or
did I misunderstand how the compatibility section works?

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[lh_mouse at 126 dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #5 from LIU Hao <lh_mouse at 126 dot com> ---
(In reply to Costas Argyris from comment #4)
> A couple of comments:
> 
> 1) Isn't Windows XP officially not supported any more?    If that is the
> case, does it make sense to introduce a new configure option solely to deal
> with an unsupported host?    I'm not even sure why this is called a
> regression, given that it breaks something that is not officially supported.

I don't think we have declared Windows XP unsupported. There was even an
attempt to maintain Windows 98:
https://www.mail-archive.com/mingw-w64-public@lists.sourceforge.net/msg21399.html

I think the decision is probably we have default as Windows 10 but don't break
old systems by intention, so when someone requests it they get it.


> 2) Would it be easier if, instead of excluding the manifest via a new
> configure option, we somehow made the manifest file itself smart enough to
> ignore itself when running on Windows XP?

https://learn.microsoft.com/en-us/windows/win32/win7appqual/compatibility---application-manifest#manifestation-of-change

```
Applications without a Compatibility section in their manifest will receive
Windows Vista behavior by default on Windows 7 and future Windows versions.
Note that Windows XP and Windows Vista ignore this manifest section and it has
no impact on them.
```

But Microsoft documentation sometimes lies. If Windows XP does not ignore the
manifest and fails instead, we will need a solution.


> which has separate entries for all the Windows versions, marking them as
> 'supportedOS'.
> 
> Would it be possible to do this in the GCC manifest and solve this problem,
> or did I misunderstand how the compatibility section works?

XP was not assigned a UUID because it (2001) predated this manifest thing (2004
or 2005 I guess? since MSVCR80).

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[costas.argyris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #6 from Costas Argyris <costas.argyris at gmail dot com> ---
I see.

I can try to come up with a patch to add a windows-host-specific configure
option to exclude the utf8 manifest on demand, but I won't be able to work on
this for a while...

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[costas.argyris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #7 from Costas Argyris <costas.argyris at gmail dot com> ---
Some ideas on how this could be implemented in case someone wants to try and
fix this sooner than me:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108865#c42

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[costas.argyris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #8 from Costas Argyris <costas.argyris at gmail dot com> ---
(In reply to LIU Hao from comment #3)
> Costas, would you like to provide a configure option to exclude that
> manifest?

I created a patch for that and attached it here:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108865#c45

I have built it natively on x86_64-w64-mingw32 but without bootstrap yet (not
sure if that would add anything in this particular case) and no i[34567]86 yet.

It would be nice if you could also give it a go in your builds.

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[lh_mouse at 126 dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #9 from LIU Hao <lh_mouse at 126 dot com> ---
(In reply to Costas Argyris from comment #8)
> (In reply to LIU Hao from comment #3)
> > Costas, would you like to provide a configure option to exclude that
> > manifest?
> 
> I created a patch for that and attached it here:
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108865#c45
> 
> I have built it natively on x86_64-w64-mingw32 but without bootstrap yet
> (not sure if that would add anything in this particular case) and no
> i[34567]86 yet.
> 
> It would be nice if you could also give it a go in your builds.

I suspect there should be an `AC_ARG_ENABLE` in configure.ac?

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[costas.argyris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #10 from Costas Argyris <costas.argyris at gmail dot com> ---
> I suspect there should be an `AC_ARG_ENABLE` in configure.ac?

It doesn't appear to be necessary to me.    It also wasn't part of the advice
of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108865#c44 as far as I can
tell.

From the two examples given there, with_avrlibc is used just through its shell
variable without any corresponding AC_ARG_WITH (couldn't find any with git grep
avrlibc anyway).

It also worked in my builds which were picking up the new
--disable-win32-utf8-manifest option (or its absence), so it doesn't seem to be
necessary to make any other changes.

Did you get any failures and suspect it's due to AC_ARG_ENABLE missing?

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Yong <jyong@gcc.gnu.org>:

https://gcc.gnu.org/g:4f1ebd54380e16927cd0085be939165870354eac

commit r14-5768-g4f1ebd54380e16927cd0085be939165870354eac
Author: Costas Argyris <costas.argyris@gmail.com>
Date:   Mon Nov 20 17:58:16 2023 +0000

    mingw: Exclude utf8 manifest [PR111170, PR108865]

    Make the utf8 manifest optional (on by default and
    explicitly off with --disable-win32-utf8-manifest)
    in the mingw hosts.

    Also eliminate duplication between the 32-bit and
    64-bit mingw hosts by putting them both in the
    same branch and special-case only the 64-bit long
    long setting.

    PR mingw/111170
    PR mingw/108865

    Signed-off-by: Costas Argyris <costas.argyris@gmail.com>
    Signed-off-by: Jonathan Yong <10walls@gmail.com>

    gcc/Changelog:

            * configure.ac: Handle new --enable-win32-utf8-manifest
            option.
            * config.host: allow win32 utf8 manifest to be disabled
            by user.
            * configure: Regenerate.

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[costas.argyris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #12 from Costas Argyris <costas.argyris at gmail dot com> ---
I think this can be considered as fixed now, since the new
--disable-win32-utf8-manifest configure option leaves out the utf8 manifest and
you shouldn't have a problem running gcc even on XP if you configure with that.

However, you do need to build using the latest sources to use that option,
since the patch was pushed to the master branch just earlier today.

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-11-28
                 CC|                            |ebotcazou at gcc dot gnu.org

--- Comment #13 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Thanks for the fix.  Now it needs to be backported onto the 13 branch.

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[costas.argyris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #14 from Costas Argyris <costas.argyris at gmail dot com> ---
(In reply to Eric Botcazou from comment #13)
> Thanks for the fix.  Now it needs to be backported onto the 13 branch.

Just sent email about it.

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

--- Comment #15 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jonathan Yong
<jyong@gcc.gnu.org>:

https://gcc.gnu.org/g:19da6d2d0048eb6a260a5cf8af707cb455848bfb

commit r13-8107-g19da6d2d0048eb6a260a5cf8af707cb455848bfb
Author: Costas Argyris <costas.argyris@gmail.com>
Date:   Mon Nov 20 17:58:16 2023 +0000

    mingw: Exclude utf8 manifest [PR111170, PR108865]

    Make the utf8 manifest optional (on by default and
    explicitly off with --disable-win32-utf8-manifest)
    in the mingw hosts.

    Also eliminate duplication between the 32-bit and
    64-bit mingw hosts by putting them both in the
    same branch and special-case only the 64-bit long
    long setting.

    PR mingw/111170
    PR mingw/108865

    Signed-off-by: Costas Argyris <costas.argyris@gmail.com>
    Signed-off-by: Jonathan Yong <10walls@gmail.com>

    gcc/Changelog:

            * configure.ac: Handle new --enable-win32-utf8-manifest
            option.
            * config.host: allow win32 utf8 manifest to be disabled
            by user.
            * configure: Regenerate.

    (cherry picked from commit 4f1ebd54380e16927cd0085be939165870354eac)

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.3

[Bug target/111170] [13/14 regression] Malformed manifest does not allow to run gcc on Windows XP (Accessing a corrupted shared library) since r13-6552-gd11e088210a551

[law at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111170

Jeffrey A. Law <law at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at gcc dot gnu.org
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #16 from Jeffrey A. Law <law at gcc dot gnu.org> ---
Fixed and backported.