public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/111216] New: [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716
@ 2023-08-28 18:32 seurer at gcc dot gnu.org
2023-08-28 20:03 ` [Bug testsuite/111216] " pinskia at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: seurer at gcc dot gnu.org @ 2023-08-28 18:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111216
Bug ID: 111216
Summary: [14 regression] instructions counts for vector tests
change after r14-3258-ge7a36e4715c716
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: testsuite
Assignee: unassigned at gcc dot gnu.org
Reporter: seurer at gcc dot gnu.org
Target Milestone: ---
g:e7a36e4715c7162ccfd7cd32da985d629bbd9c61, r14-3258-ge7a36e4715c716
FAIL: gcc.target/powerpc/fold-vec-logical-ors-char.c scan-assembler-times
\\mxxlnor\\M 1
FAIL: gcc.target/powerpc/fold-vec-logical-ors-char.c scan-assembler-times
\\mxxlor\\M 7
FAIL: gcc.target/powerpc/fold-vec-logical-ors-int.c scan-assembler-times
\\mxxlnor\\M 1
FAIL: gcc.target/powerpc/fold-vec-logical-ors-int.c scan-assembler-times
\\mxxlor\\M 7
FAIL: gcc.target/powerpc/fold-vec-logical-ors-longlong.c scan-assembler-times
\\mxxlnor\\M 3
FAIL: gcc.target/powerpc/fold-vec-logical-ors-longlong.c scan-assembler-times
\\mxxlor\\M 9
FAIL: gcc.target/powerpc/fold-vec-logical-ors-short.c scan-assembler-times
\\mxxlnor\\M 1
FAIL: gcc.target/powerpc/fold-vec-logical-ors-short.c scan-assembler-times
\\mxxlor\\M 7
FAIL: gcc.target/powerpc/fold-vec-logical-other-char.c scan-assembler-times
\\mxxlnand\\M 3
FAIL: gcc.target/powerpc/fold-vec-logical-other-int.c scan-assembler-times
\\mxxlnand\\M 3
FAIL: gcc.target/powerpc/fold-vec-logical-other-longlong.c scan-assembler-times
\\mxxlnand\\M 3
FAIL: gcc.target/powerpc/fold-vec-logical-other-short.c scan-assembler-times
\\mxxlnand\\M 3
These are all just instruction count tests so the changes may not matter.
commit e7a36e4715c7162ccfd7cd32da985d629bbd9c61 (HEAD)
Author: Yanzhang Wang <yanzhang.wang@intel.com>
Date: Wed Aug 16 22:28:50 2023 -0600
[PATCH] RISC-V: Support simplify (-1-x) for vector.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/111216] [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716
2023-08-28 18:32 [Bug testsuite/111216] New: [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716 seurer at gcc dot gnu.org
@ 2023-08-28 20:03 ` pinskia at gcc dot gnu.org
2023-08-28 21:26 ` bergner at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-08-28 20:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111216
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2023-08-28
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
test6_nor in fold-vec-logical-ors-char.c
Trying 10, 9 -> 11:
10: r127:V16QI=const_vector // (-1)
9: r125:V16QI=r126:V16QI-r124:V16QI
REG_DEAD r126:V16QI
REG_DEAD r124:V16QI
11: r121:V16QI=r125:V16QI+r127:V16QI
REG_DEAD r127:V16QI
REG_DEAD r125:V16QI
REG_EQUAL r125:V16QI+const_vector
Failed to match this instruction:
(set (reg:V16QI 121 [ <retval> ])
(plus:V16QI (not:V16QI (reg:V16QI 124))
(reg:V16QI 126 [ *foo_4(D) ])))
Successfully matched this instruction:
(set (reg:V16QI 127)
(not:V16QI (reg:V16QI 124)))
Successfully matched this instruction:
(set (reg:V16QI 121 [ <retval> ])
(plus:V16QI (reg:V16QI 127)
(reg:V16QI 126 [ *foo_4(D) ])))
allowing combination of insns 9, 10 and 11
original costs 4 + 20 + 4 = 28
replacement costs 4 + 4 = 8
deferring deletion of insn with uid = 9.
modifying insn i2 10: r127:V16QI=~r124:V16QI
REG_DEAD r124:V16QI
deferring rescan insn with uid = 10.
modifying insn i3 11: r121:V16QI=r127:V16QI+r126:V16QI
REG_DEAD r126:V16QI
REG_DEAD r127:V16QI
deferring rescan insn with uid = 11.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/111216] [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716
2023-08-28 18:32 [Bug testsuite/111216] New: [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716 seurer at gcc dot gnu.org
2023-08-28 20:03 ` [Bug testsuite/111216] " pinskia at gcc dot gnu.org
@ 2023-08-28 21:26 ` bergner at gcc dot gnu.org
2023-08-29 8:13 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: bergner at gcc dot gnu.org @ 2023-08-28 21:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111216
Peter Bergner <bergner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |linkw at gcc dot gnu.org,
| |meissner at gcc dot gnu.org
--- Comment #2 from Peter Bergner <bergner at gcc dot gnu.org> ---
The code change that led to this looks correct to me. Are we possibly just
folding more than we used to (a good thing), and that is changing our numbers?
What are the actual and expected counts?
I'm sorry for repeating myself, but I really really dislike counting xxlor
insns, since they're mostly used for register copies and the number of those
can easily change with the phase of the moon, day of the week, etc. etc.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/111216] [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716
2023-08-28 18:32 [Bug testsuite/111216] New: [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716 seurer at gcc dot gnu.org
2023-08-28 20:03 ` [Bug testsuite/111216] " pinskia at gcc dot gnu.org
2023-08-28 21:26 ` bergner at gcc dot gnu.org
@ 2023-08-29 8:13 ` rguenth at gcc dot gnu.org
2023-08-30 21:25 ` bergner at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-08-29 8:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111216
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |testsuite-fail
Target Milestone|--- |14.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/111216] [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716
2023-08-28 18:32 [Bug testsuite/111216] New: [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716 seurer at gcc dot gnu.org
` (2 preceding siblings ...)
2023-08-29 8:13 ` rguenth at gcc dot gnu.org
@ 2023-08-30 21:25 ` bergner at gcc dot gnu.org
2023-08-30 22:43 ` bergner at gcc dot gnu.org
2023-08-31 14:31 ` bergner at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: bergner at gcc dot gnu.org @ 2023-08-30 21:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111216
--- Comment #3 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #2)
> The code change that led to this looks correct to me. Are we possibly just
> folding more than we used to (a good thing), and that is changing our
> numbers? What are the actual and expected counts?
So looking at the differences between "before" and "after", we're seeing:
test6_nor:
.LFB13:
.cfi_startproc
- xxlor 34,34,35
li 9,0
lvx 0,0,9
addi 10,1,-16
xxpermdi 32,32,32,2
stxvd2x 32,0,10
xxpermdi 32,32,32,2
- vsububm 2,0,2
- vspltisw 0,-1
+ xxlnor 34,34,35
vaddubm 2,2,0
stvx 2,0,9
blr
...so yes, we are getting more folding than before and the generated code is
better, so we should update the expected counts. It seems to be the same issue
in all of the tests.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/111216] [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716
2023-08-28 18:32 [Bug testsuite/111216] New: [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716 seurer at gcc dot gnu.org
` (3 preceding siblings ...)
2023-08-30 21:25 ` bergner at gcc dot gnu.org
@ 2023-08-30 22:43 ` bergner at gcc dot gnu.org
2023-08-31 14:31 ` bergner at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: bergner at gcc dot gnu.org @ 2023-08-30 22:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111216
Peter Bergner <bergner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |bergner at gcc dot gnu.org
Status|NEW |ASSIGNED
URL| |https://gcc.gnu.org/piperma
| |il/gcc-patches/2023-August/
| |628871.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/111216] [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716
2023-08-28 18:32 [Bug testsuite/111216] New: [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716 seurer at gcc dot gnu.org
` (4 preceding siblings ...)
2023-08-30 22:43 ` bergner at gcc dot gnu.org
@ 2023-08-31 14:31 ` bergner at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: bergner at gcc dot gnu.org @ 2023-08-31 14:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111216
Peter Bergner <bergner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Peter Bergner <bergner at gcc dot gnu.org> ---
Fixed on trunk.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-08-31 14:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-28 18:32 [Bug testsuite/111216] New: [14 regression] instructions counts for vector tests change after r14-3258-ge7a36e4715c716 seurer at gcc dot gnu.org
2023-08-28 20:03 ` [Bug testsuite/111216] " pinskia at gcc dot gnu.org
2023-08-28 21:26 ` bergner at gcc dot gnu.org
2023-08-29 8:13 ` rguenth at gcc dot gnu.org
2023-08-30 21:25 ` bergner at gcc dot gnu.org
2023-08-30 22:43 ` bergner at gcc dot gnu.org
2023-08-31 14:31 ` bergner at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).