[Bug ada/111283] New: gnat bootstrap broken on trunk 20230902 on 32bit targets

[Bug ada/111283] New: gnat bootstrap broken on trunk 20230902 on 32bit targets

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

            Bug ID: 111283
           Summary: gnat bootstrap broken on trunk 20230902 on 32bit
                    targets
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org
                CC: dkm at gcc dot gnu.org
  Target Milestone: ---

seen with trunk 20230902 on at least arm-linux-gnueabihf, i686-linux-gnu and
powerpc-linux-gnu:

/<<PKGBUILDDIR>>/build/./prev-gcc/xgcc -B/<<PKGBUILDDIR>>/build/./prev-gcc/
-B/usr/lib/gcc-snapshot/arm-linux-gnueabihf/bin/
-B/usr/lib/gcc-snapshot/arm-linux-gnueabihf/bin/
-B/usr/lib/gcc-snapshot/arm-linux-gnueabihf/lib/ -isystem
/usr/lib/gcc-snapshot/arm-linux-gnueabihf/include -isystem
/usr/lib/gcc-snapshot/arm-linux-gnueabihf/sys-include    -c -g -O2
-fprofile-use -fprofile-reproducible=parallel-runs  -gnatpg -gnata -W -Wall
-fno-PIE -nostdinc -I- -I. -Iada/generated -Iada -I../../src/gcc/ada
-Iada/libgnat -I../../src/gcc/ada/libgnat -Iada/gcc-interface
-I../../src/gcc/ada/gcc-interface ../../src/gcc/ada/nlists.adb -o ada/nlists.o
../../src/gcc/ada/nlists.adb: In function 'Nlists.New_List':
../../src/gcc/ada/nlists.adb:787:4: error: probability of edge 15->16 not
initialized
during IPA pass: inline
+===========================GNAT BUG DETECTED==============================+
| 14.0.0 20230902 (experimental) [master r14-3635-g4e2d53c9434]
(arm-linux-gnueabihf) GCC error:|
| verify_flow_info failed                                                  |
| Error detected around ../../src/gcc/ada/nlists.adb:787:4                 |
| Compiling ../../src/gcc/ada/nlists.adb                                   |
| Please submit a bug report; see https://gcc.gnu.org/bugs/ .              |
| Use a subject line meaningful to you and us to track the bug.            |
| Include the entire contents of this bug box in the report.               |
| Include the exact command that you entered.                              |
| Also include sources listed below.                                       |
+==========================================================================+

Please include these source files with error report
Note that list may not be accurate in some cases,
so please double check that the problem can still
be reproduced with the set of files listed.
Consider also -gnatd.n switch (see debug.adb).

../../src/gcc/ada/gcc-interface/system.ads
../../src/gcc/ada/nlists.adb
../../src/gcc/ada/nlists.ads
../../src/gcc/ada/types.ads
../../src/gcc/ada/libgnat/ada.ads
../../src/gcc/ada/libgnat/a-unccon.ads
../../src/gcc/ada/libgnat/a-uncdea.ads
../../src/gcc/ada/alloc.ads
../../src/gcc/ada/atree.ads
../../src/gcc/ada/sinfo.ads
../../src/gcc/ada/namet.ads
../../src/gcc/ada/hostparm.ads
../../src/gcc/ada/table.ads
../../src/gcc/ada/uintp.ads
../../src/gcc/ada/urealp.ads
ada/sinfo-nodes.ads
ada/seinfo.ads
../../src/gcc/ada/output.ads
../../src/gcc/ada/libgnat/s-os_lib.ads
../../src/gcc/ada/libgnat/s-string.ads
../../src/gcc/ada/einfo.ads
ada/snames.ads
../../src/gcc/ada/stand.ads
ada/einfo-entities.ads
../../src/gcc/ada/einfo-utils.ads
../../src/gcc/ada/debug.ads
../../src/gcc/ada/libgnat/s-exctab.ads
../../src/gcc/ada/libgnat/s-stalib.ads
../../src/gcc/ada/libgnat/s-unstyp.ads
../../src/gcc/ada/libgnat/s-conca2.ads
../../src/gcc/ada/libgnat/s-assert.ads
../../src/gcc/ada/libgnat/a-assert.ads
../../src/gcc/ada/table.adb
../../src/gcc/ada/opt.ads
../../src/gcc/ada/libgnat/s-wchcon.ads
../../src/gcc/ada/libgnat/s-memory.ads
../../src/gcc/ada/libgnat/a-except.ads
../../src/gcc/ada/libgnat/s-parame.ads
../../src/gcc/ada/libgnat/s-traent.ads


raised TYPES.UNRECOVERABLE_ERROR : comperr.adb:412

[Bug ada/111283] gnat bootstrap broken on trunk 20230902 on 32bit targets

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

--- Comment #1 from Matthias Klose <doko at gcc dot gnu.org> ---
Configured with: -v
         --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2
         --with-gcc-major-version-only
         --program-prefix=
         --enable-shared
         --enable-linker-build-id
         --disable-nls
         --enable-bootstrap
         --enable-clocale=gnu
         --enable-libstdcxx-debug
         --enable-libstdcxx-time=yes
         --with-default-libstdcxx-abi=new
         --enable-gnu-unique-object
         --disable-libitm
         --disable-libquadmath
         --disable-libquadmath-support
         --enable-plugin
         --with-system-zlib
         --enable-libphobos-checking=release
         --with-target-system-zlib=auto
         --enable-objc-gc=auto
         --enable-multiarch
         --disable-sjlj-exceptions
         --with-arch=armv7-a+fp
         --with-float=hard
         --with-mode=thumb
         --disable-werror
         --enable-checking=yes

make profiledbootstrap-lean

[Bug ipa/111283] [14 Regression] gnat bootstrap broken on trunk 20230902 on 32bit targets

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ada                         |ipa
                 CC|                            |hubicka at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
   Target Milestone|---                         |14.0
            Summary|gnat bootstrap broken on    |[14 Regression] gnat
                   |trunk 20230902 on 32bit     |bootstrap broken on trunk
                   |targets                     |20230902 on 32bit targets

[Bug ipa/111283] [14 Regression] gnat bootstrap broken on trunk 20230902 on 32bit targets

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
It works on x86_64. I wonder if those targets being ILP32 make it fail for some
heurstics differences ...

[Bug ipa/111283] [14 Regression] gnat profilebootstrap broken on trunk 20230902 on 32bit targets

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[14 Regression] gnat        |[14 Regression] gnat
                   |bootstrap broken on trunk   |profilebootstrap broken on
                   |20230902 on 32bit targets   |trunk 20230902 on 32bit
                   |                            |targets

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Oh wait this is profile bootstrap:
-fprofile-use

[Bug ipa/111283] [14 Regression] gnat profilebootstrap broken on trunk 20230902 on 32bit targets

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

--- Comment #4 from Andreas Schwab <schwab@linux-m68k.org> ---
Doesn't fail here, but it uses release checking:

https://build.opensuse.org/package/live_build_log/devel:gcc:next/gcc14/openSUSE_Tumbleweed/i586

[Bug ipa/111283] [14 Regression] gnat profilebootstrap broken on trunk 20230902 on 32bit targets

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

--- Comment #5 from Matthias Klose <doko at gcc dot gnu.org> ---
a normal bootstrap (at least on i686-linux-gnu) succeeds

[Bug ipa/111283] [14 Regression] gnat profilebootstrap broken on trunk 20230902 on 32bit targets

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

--- Comment #6 from Matthias Klose <doko at gcc dot gnu.org> ---
last known successful profiled bootstrap with trunk 20230811

[Bug ipa/111283] [14 Regression] gnat profilebootstrap broken on trunk 20230902 on 32bit targets

[sirl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

Franz Sirl <sirl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sirl at gcc dot gnu.org

--- Comment #7 from Franz Sirl <sirl at gcc dot gnu.org> ---
Created attachment 55901
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55901&action=edit
Output of -freport-bug

[Bug ipa/111283] [14 Regression] gnat profilebootstrap broken on trunk 20230902 on 32bit targets

[sirl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

--- Comment #8 from Franz Sirl <sirl at gcc dot gnu.org> ---
I see a similar profiledbootstrap failing with x86_64-linux-gnu:

/home/fsirl/rpmbuild/BUILD/gcc-14.0.0+gitr14+3924/obj-x86_64-suse-linux/./prev-gcc/xg++
-B/home/fsirl/rpmbuild/BUILD/gcc-14.0.0+gitr14+3924/obj-x86_64-suse-linux/./prev-gcc/
-B/usr/x86_64-suse-linux/b
in/ -nostdinc++
-B/home/fsirl/rpmbuild/BUILD/gcc-14.0.0+gitr14+3924/obj-x86_64-suse-linux/prev-x86_64-suse-linux/libstdc++-v3/src/.libs
-B/home/fsirl/rpmbuild/BUILD/gcc-14.0.0+gitr14+3924/obj-x86_64-s
use-linux/prev-x86_64-suse-linux/libstdc++-v3/libsupc++/.libs 
-I/home/fsirl/rpmbuild/BUILD/gcc-14.0.0+gitr14+3924/obj-x86_64-suse-linux/prev-x86_64-suse-linux/libstdc++-v3/include/x86_64-suse-linux 
-I/home/fsirl/rpmbuild/BUILD/gcc-14.0.0+gitr14+3924/obj-x86_64-suse-linux/prev-x86_64-suse-linux/libstdc++-v3/include
 -I/home/fsirl/rpmbuild/BUILD/gcc-14.0.0+gitr14+3924/libstdc++-v3/libsupc++
-L/hom
e/fsirl/rpmbuild/BUILD/gcc-14.0.0+gitr14+3924/obj-x86_64-suse-linux/prev-x86_64-suse-linux/libstdc++-v3/src/.libs
-L/home/fsirl/rpmbuild/BUILD/gcc-14.0.0+gitr14+3924/obj-x86_64-suse-linux/prev-x86_64-
suse-linux/libstdc++-v3/libsupc++/.libs  -fno-PIE -c  -DIN_GCC_FRONTEND
-DIN_GCC_FRONTEND -DIN_GCC_FRONTEND -O2 -g -fmessage-length=0
-D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -
U_FORTIFY_SOURCE -fprofile-use -fprofile-reproducible=parallel-runs -DIN_GCC   
-fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing
-Wwrite-strings -Wcast-qual -Wmissing-for
mat-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic
-Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common 
-DHAVE_CONFIG_H -fno-PIE -I. -Ic-family -I../../gcc -I..
/../gcc/c-family -I../../gcc/../include  -I../../gcc/../libcpp/include
-I../../gcc/../libcody  -I../../gcc/../libdecnumber
-I../../gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc/../libbacktrace
   -o c-family/c-attribs.o -MT c-family/c-attribs.o -MMD -MP -MF
c-family/.deps/c-attribs.TPo ../../gcc/c-family/c-attribs.cc
../../gcc/c-family/c-attribs.cc: In function ??tree_node*
handle_noclone_attribute(tree_node**, tree, tree, int, bool*)??:
../../gcc/c-family/c-attribs.cc:1369:1: error: probability of edge 3->4 not
initialized
 1369 | handle_noclone_attribute (tree *node, tree name,
      | ^~~~~~~~~~~~~~~~~~~~~~~~
during IPA pass: inline
../../gcc/c-family/c-attribs.cc:1369:1: internal compiler error:
verify_flow_info failed
0xa92b3e verify_flow_info()
        ../../gcc/cfghooks.cc:287
0xfde04c checking_verify_flow_info()
        ../../gcc/cfghooks.h:214
0xfde04c cleanup_tree_cfg_noloop
        ../../gcc/tree-cfgcleanup.cc:1154
0xfde04c cleanup_tree_cfg(unsigned int)
        ../../gcc/tree-cfgcleanup.cc:1205
0xe7b25c execute_function_todo
        ../../gcc/passes.cc:2057
0xe7b70e execute_todo
        ../../gcc/passes.cc:2142
0xe7e16f execute_one_ipa_transform_pass
        ../../gcc/passes.cc:2336
0xe7e16f execute_all_ipa_transforms(bool)
        ../../gcc/passes.cc:2396
0xacde5d cgraph_node::expand()
        ../../gcc/cgraphunit.cc:1834
0xacde5d cgraph_node::expand()
        ../../gcc/cgraphunit.cc:1794
0xacecec expand_all_functions
        ../../gcc/cgraphunit.cc:2000
0xacecec symbol_table::compile()
        ../../gcc/cgraphunit.cc:2398
0xad2197 symbol_table::compile()
        ../../gcc/cgraphunit.cc:2311
0xad2197 symbol_table::finalize_compilation_unit()
        ../../gcc/cgraphunit.cc:2583
Please submit a full bug report, with preprocessed source (by using
-freport-bug).

I'm attaching the compressed -freport-bug output, but I didn't manage to
reproduce the bug with it (probably related to the gcda file).

[Bug ipa/111283] [14 Regression] gnat profilebootstrap broken on trunk 20230902 on 32bit targets

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

--- Comment #9 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Proposed conservative fix as
https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631526.html

[Bug ipa/111283] [14 Regression] gnat profilebootstrap broken on trunk 20230902 on 32bit targets

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Sergei Trofimovich <slyfox@gcc.gnu.org>:

https://gcc.gnu.org/g:043a6fcbc27f8721301eb2f72a7839f54f393003

commit r14-4421-g043a6fcbc27f8721301eb2f72a7839f54f393003
Author: Sergei Trofimovich <siarheit@google.com>
Date:   Wed Sep 27 14:29:12 2023 +0100

    ipa-utils: avoid uninitialized probabilities on ICF [PR111559]

    r14-3459-g0c78240fd7d519 "Check that passes do not forget to define
profile"
    exposed check failures in cases when gcc produces uninitialized profile
    probabilities. In case of PR/111559 uninitialized profile is generated
    by edges executed 0 times reported by IPA profile:

        $ gcc -O2 -fprofile-generate pr111559.c -o b -fopt-info
        $ ./b
        $ gcc -O2 -fprofile-use -fprofile-correction pr111559.c -o b -fopt-info

        pr111559.c: In function 'rule1':
        pr111559.c:6:13: error: probability of edge 3->4 not initialized
            6 | static void rule1(void) { if (p) edge(); }
              |             ^~~~~
        during GIMPLE pass: fixup_cfg
        pr111559.c:6:13: internal compiler error: verify_flow_info failed

    The change conservatively ignores updates with zero execution counts and
    uses initially assigned probabilities (`always` probability in case of
    the example).

            PR ipa/111283
            PR gcov-profile/111559

    gcc/
            * ipa-utils.cc (ipa_merge_profiles): Avoid producing
            uninitialized probabilities when merging counters with zero
            denominators.

    gcc/testsuite/
            * gcc.dg/tree-prof/pr111559.c: New test.

[Bug ipa/111283] [14 Regression] gnat profilebootstrap broken on trunk 20230902 on 32bit targets

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111283

Sergei Trofimovich <slyfox at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassigned at gcc dot gnu.org      |slyfox at gcc dot gnu.org

--- Comment #11 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Should be fixed in master.

Thank you for the report!