public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/111303] New: ICE: in type, at value-range.h:869
@ 2023-09-06 8:24 shaohua.li at inf dot ethz.ch
2023-09-06 9:21 ` [Bug c/111303] " shaohua.li at inf dot ethz.ch
` (11 more replies)
0 siblings, 12 replies; 13+ messages in thread
From: shaohua.li at inf dot ethz.ch @ 2023-09-06 8:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
Bug ID: 111303
Summary: ICE: in type, at value-range.h:869
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c
Assignee: unassigned at gcc dot gnu.org
Reporter: shaohua.li at inf dot ethz.ch
Target Milestone: ---
gcc at -O2 crashes on the following test case.
Compiler explorer: https://godbolt.org/z/qK6dMTK14
$ cat a.c
unsigned char a;
int b(int c) {
if (c >= 5000)
return c / 5;
}
void d() { b(a - 5); }
int main() {}
$
$ gcc -O2 a.c
during GIMPLE pass: evrp
<source>: In function 'd':
<source>:7:1: internal compiler error: in type, at value-range.h:869
7 | int main() {}
| ^~~
0x21af71e internal_error(char const*, ...)
???:0
0x9dd814 fancy_abort(char const*, int, char const*)
???:0
0x16cada5 gimple_simplify_TRUNC_DIV_EXPR(gimple_match_op*, gimple**, tree_node*
(*)(tree_node*), code_helper, tree_node*, tree_node*, tree_node*)
???:0
0x180c22a gimple_match_op::resimplify(gimple**, tree_node* (*)(tree_node*))
???:0
0x180c880 gimple_simplify(gimple*, gimple_match_op*, gimple**, tree_node*
(*)(tree_node*), tree_node* (*)(tree_node*))
???:0
0x1f41940 gimple_ranger::fold_stmt(gimple_stmt_iterator*, tree_node*
(*)(tree_node*))
???:0
0x13c5478 rvrp_folder::fold_stmt(gimple_stmt_iterator*)
???:0
0x12a653e substitute_and_fold_dom_walker::before_dom_children(basic_block_def*)
???:0
0x1f09107 dom_walker::walk(basic_block_def*)
???:0
0x12a568b substitute_and_fold_engine::substitute_and_fold(basic_block_def*)
???:0
0x13c4f9c execute_ranger_vrp(function*, bool, bool)
???:0
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
Compiler returned: 1
$
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug c/111303] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
@ 2023-09-06 9:21 ` shaohua.li at inf dot ethz.ch
2023-09-06 11:12 ` guojiufu at gcc dot gnu.org
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: shaohua.li at inf dot ethz.ch @ 2023-09-06 9:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
Shaohua Li <shaohua.li at inf dot ethz.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |guojiufu at gcc dot gnu.org
--- Comment #1 from Shaohua Li <shaohua.li at inf dot ethz.ch> ---
Bisected to r14-3644-g1aceceb1e2
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug c/111303] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
2023-09-06 9:21 ` [Bug c/111303] " shaohua.li at inf dot ethz.ch
@ 2023-09-06 11:12 ` guojiufu at gcc dot gnu.org
2023-09-06 11:13 ` guojiufu at gcc dot gnu.org
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: guojiufu at gcc dot gnu.org @ 2023-09-06 11:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
Jiu Fu Guo <guojiufu at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |guojiufu at gcc dot gnu.org
--- Comment #2 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> ---
Thanks for reporting this!
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug c/111303] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
2023-09-06 9:21 ` [Bug c/111303] " shaohua.li at inf dot ethz.ch
2023-09-06 11:12 ` guojiufu at gcc dot gnu.org
@ 2023-09-06 11:13 ` guojiufu at gcc dot gnu.org
2023-09-06 12:36 ` guojiufu at gcc dot gnu.org
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: guojiufu at gcc dot gnu.org @ 2023-09-06 11:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
Jiu Fu Guo <guojiufu at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2023-09-06
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug c/111303] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
` (2 preceding siblings ...)
2023-09-06 11:13 ` guojiufu at gcc dot gnu.org
@ 2023-09-06 12:36 ` guojiufu at gcc dot gnu.org
2023-09-06 12:47 ` guojiufu at gcc dot gnu.org
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: guojiufu at gcc dot gnu.org @ 2023-09-06 12:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
--- Comment #3 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> ---
In the pattern of match.pd, there is:
&& range_op_handler (PLUS_EXPR).overflow_free_p (vr0, vr1)
&& get_range_query (cfun)->range_of_expr (vr3, @3)
/* "X+C" and "X" are not of opposite sign. */
&& (TYPE_UNSIGNED (type)
|| (vr0.nonnegative_p () && vr3.nonnegative_p ())
|| (vr0.nonpositive_p () && vr3.nonpositive_p ())))
For this case, "vr3" is "undefined_p", then "vr3.nonnegative_p ()" trige ICE.
Checking "!vr3.undefine_p ()" would be a safe fix for this ICE.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug c/111303] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
` (3 preceding siblings ...)
2023-09-06 12:36 ` guojiufu at gcc dot gnu.org
@ 2023-09-06 12:47 ` guojiufu at gcc dot gnu.org
2023-09-06 22:52 ` [Bug tree-optimization/111303] [14 Regression] " pinskia at gcc dot gnu.org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: guojiufu at gcc dot gnu.org @ 2023-09-06 12:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
--- Comment #4 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> ---
For the pattern: "(X + C) / N", "op (plus@3 @0 INTEGER_CST@1) INTEGER_CST@2)"
where "X" has value-range, and "X + C" does not overflow:
&& get_range_query (cfun)->range_of_expr (vr0, @0))
&& get_range_query (cfun)->range_of_expr (vr1, @1)
&& range_op_handler (PLUS_EXPR).overflow_free_p (vr0, vr1)
Then "@3"(it is X+C) would be with value-range usually.
But for particular cases, like this PR, "vr3" is undefined.
Below would be the reason for why "vr3" is undefined:
_3 = _2 + -5;
if (0 != 0)
goto <bb 3>; [34.00%]
else
goto <bb 4>; [66.00%]
;; succ: 3
;; 4
;; basic block 3, loop depth 0
;; pred: 2
_5 = _3 / 5;
;; succ: 4
The whole pattern "(_2 + -5 ) / 5" is in "bb 3", but "bb" would be unreachable
(because "if (0 != 0)" is always false).
And "get_range_query (cfun)->range_of_expr (vr3, @3)" is checked in "bb 3",
"range_of_expr" gets an "undefined vr3".
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug tree-optimization/111303] [14 Regression] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
` (4 preceding siblings ...)
2023-09-06 12:47 ` guojiufu at gcc dot gnu.org
@ 2023-09-06 22:52 ` pinskia at gcc dot gnu.org
2023-09-09 16:03 ` pinskia at gcc dot gnu.org
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-09-06 22:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|ICE: in type, at |[14 Regression] ICE: in
|value-range.h:869 |type, at value-range.h:869
Keywords| |ice-on-valid-code
Status|NEW |ASSIGNED
Component|c |tree-optimization
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug tree-optimization/111303] [14 Regression] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
` (5 preceding siblings ...)
2023-09-06 22:52 ` [Bug tree-optimization/111303] [14 Regression] " pinskia at gcc dot gnu.org
@ 2023-09-09 16:03 ` pinskia at gcc dot gnu.org
2023-09-09 16:04 ` pinskia at gcc dot gnu.org
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-09-09 16:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |14.0
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug tree-optimization/111303] [14 Regression] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
` (6 preceding siblings ...)
2023-09-09 16:03 ` pinskia at gcc dot gnu.org
@ 2023-09-09 16:04 ` pinskia at gcc dot gnu.org
2023-09-13 1:32 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-09-09 16:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zhendong.su at inf dot ethz.ch
--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 111355 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug tree-optimization/111303] [14 Regression] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
` (7 preceding siblings ...)
2023-09-09 16:04 ` pinskia at gcc dot gnu.org
@ 2023-09-13 1:32 ` cvs-commit at gcc dot gnu.org
2023-09-18 2:19 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-09-13 1:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jiu Fu Guo <guojiufu@gcc.gnu.org>:
https://gcc.gnu.org/g:8d8bc560b6ab7f3153db23ffb37157528e5b2c9a
commit r14-3913-g8d8bc560b6ab7f3153db23ffb37157528e5b2c9a
Author: Jiufu Guo <guojiufu@linux.ibm.com>
Date: Wed Sep 6 21:38:11 2023 +0800
Checking undefined_p before using the vr
For pattern "(X + C) / N": "div (plus@3 @0 INTEGER_CST@1) INTEGER_CST@2)",
Even if "X" has value-range and "X + C" does not overflow, "@3" may still
be undefined. Like below example:
_3 = _2 + -5;
if (0 != 0)
goto <bb 3>; [34.00%]
else
goto <bb 4>; [66.00%]
;; succ: 3
;; 4
;; basic block 3, loop depth 0
;; pred: 2
_5 = _3 / 5;
;; succ: 4
The whole pattern "(_2 + -5 ) / 5" is in "bb 3", but "bb 3" would be
unreachable (because "if (0 != 0)" is always false).
And "get_range_query (cfun)->range_of_expr (vr3, @3)" is checked in
"bb 3", "range_of_expr" gets an "undefined vr3". Where "@3" is "_5".
So, before using "vr3", it would be safe to check "!vr3.undefined_p ()".
PR tree-optimization/111303
gcc/ChangeLog:
* match.pd ((X - N * M) / N): Add undefined_p checking.
((X + N * M) / N): Likewise.
((X + C) div_rshift N): Likewise.
gcc/testsuite/ChangeLog:
* gcc.dg/pr111303.c: New test.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug tree-optimization/111303] [14 Regression] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
` (8 preceding siblings ...)
2023-09-13 1:32 ` cvs-commit at gcc dot gnu.org
@ 2023-09-18 2:19 ` cvs-commit at gcc dot gnu.org
2023-09-18 2:31 ` guojiufu at gcc dot gnu.org
2023-09-18 2:38 ` guojiufu at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-09-18 2:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jiu Fu Guo <guojiufu@gcc.gnu.org>:
https://gcc.gnu.org/g:55b22a6f630e76a0be913ced8bf1b017eaffd89b
commit r14-4082-g55b22a6f630e76a0be913ced8bf1b017eaffd89b
Author: Jiufu Guo <guojiufu@linux.ibm.com>
Date: Wed Sep 13 16:12:05 2023 +0800
use local range for one more pattern in match.pd
For "get_global_range_query" SSA_NAME_RANGE_INFO can be queried.
For "get_range_query", it could get more context-aware range info.
And look at the implementation of "get_range_query", it returns
global range if no local fun info.
ATTRIBUTE_RETURNS_NONNULL inline range_query *
get_range_query (const struct function *fun)
{
return (fun && fun->x_range_query) ? fun->x_range_query : &global_ranges;
}
So, using "get_range_query" would cover more case.
For example, the test case of "pr111303.c".
PR middle-end/111303
gcc/ChangeLog:
* match.pd ((t * 2) / 2): Update pattern.
gcc/testsuite/ChangeLog:
* gcc.dg/tree-ssa/pr111303.c: New test.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug tree-optimization/111303] [14 Regression] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
` (9 preceding siblings ...)
2023-09-18 2:19 ` cvs-commit at gcc dot gnu.org
@ 2023-09-18 2:31 ` guojiufu at gcc dot gnu.org
2023-09-18 2:38 ` guojiufu at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: guojiufu at gcc dot gnu.org @ 2023-09-18 2:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
Jiu Fu Guo <guojiufu at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> ---
Fix is committed via r14-3913-g8d8bc560b6ab7f3153db23ffb37157528e5b2c9a.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug tree-optimization/111303] [14 Regression] ICE: in type, at value-range.h:869
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
` (10 preceding siblings ...)
2023-09-18 2:31 ` guojiufu at gcc dot gnu.org
@ 2023-09-18 2:38 ` guojiufu at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: guojiufu at gcc dot gnu.org @ 2023-09-18 2:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111303
--- Comment #9 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> ---
(In reply to CVS Commits from comment #7) this comment should be linked to
PR111324.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-09-18 2:38 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-06 8:24 [Bug c/111303] New: ICE: in type, at value-range.h:869 shaohua.li at inf dot ethz.ch
2023-09-06 9:21 ` [Bug c/111303] " shaohua.li at inf dot ethz.ch
2023-09-06 11:12 ` guojiufu at gcc dot gnu.org
2023-09-06 11:13 ` guojiufu at gcc dot gnu.org
2023-09-06 12:36 ` guojiufu at gcc dot gnu.org
2023-09-06 12:47 ` guojiufu at gcc dot gnu.org
2023-09-06 22:52 ` [Bug tree-optimization/111303] [14 Regression] " pinskia at gcc dot gnu.org
2023-09-09 16:03 ` pinskia at gcc dot gnu.org
2023-09-09 16:04 ` pinskia at gcc dot gnu.org
2023-09-13 1:32 ` cvs-commit at gcc dot gnu.org
2023-09-18 2:19 ` cvs-commit at gcc dot gnu.org
2023-09-18 2:31 ` guojiufu at gcc dot gnu.org
2023-09-18 2:38 ` guojiufu at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).