[Bug tree-optimization/111462] New: [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[Bug tree-optimization/111462] New: [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

            Bug ID: 111462
           Summary: [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails
                    after r14-4089-gd45ddc2c04e471
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:d45ddc2c04e471d0dcee016b6edacc00b8341b16, r14-4089-gd45ddc2c04e471
make  -k check-gcc RUNTESTFLAGS="tree-ssa.exp=gcc.dg/tree-ssa/ssa-sink-18.c"
FAIL: gcc.dg/tree-ssa/ssa-sink-18.c scan-tree-dump-times sink2 "Sunk
statements: 5" 1
# of expected passes            1
# of unexpected failures        1

commit d45ddc2c04e471d0dcee016b6edacc00b8341b16 (HEAD)
Author: Richard Biener <rguenther@suse.de>
Date:   Thu Sep 14 13:06:51 2023 +0200

    tree-optimization/111294 - backwards threader PHI costing

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tree-optimization           |testsuite
           Keywords|                            |testsuite-fail

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I wonder if the rule for the xfail/target should change here due to the IV-OPTS
difference like the riscv64-*-* case (note that should really be riscv*-*-*).

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

--- Comment #2 from seurer at gcc dot gnu.org ---
Also this one:

make  -k check-gcc RUNTESTFLAGS="vect.exp=gcc.dg/vect/vect-117.c"
FAIL: gcc.dg/vect/vect-117.c scan-tree-dump-not optimized "Invalid sum"
FAIL: gcc.dg/vect/vect-117.c -flto -ffat-lto-objects  scan-tree-dump-not
optimized "Invalid sum"

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
   Target Milestone|---                         |14.0
   Last reconfirmed|                            |2023-09-19
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.  We should possibly disable IVOPTs.

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[stefansf at linux dot ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

Stefan Schulze Frielinghaus <stefansf at linux dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stefansf at linux dot ibm.com

--- Comment #4 from Stefan Schulze Frielinghaus <stefansf at linux dot ibm.com> ---
Since r14-4089-gd45ddc2c04e471 bootstrap fails on s390 with

/devel/gcc/build/./prev-gcc/xg++ -B/devel/gcc/build/./prev-gcc/
-B/devel/gcc/dst/s390x-ibm-linux-gnu/bin/ -nostdinc++
-B/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/src/.libs
-B/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/libsupc++/.libs 
-I/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/include/s390x-ibm-linux-gnu
 -I/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/include 
-I/devel/gcc/src/libstdc++-v3/libsupc++
-L/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/src/.libs
-L/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/libsupc++/.libs 
-I/devel/gcc/src/libcpp -I. -I/devel/gcc/src/libcpp/../include
-I/devel/gcc/src/libcpp/include  -g -O2 -fchecking=1 -W -Wall -Wno-narrowing
-Wwrite-strings -Wmissing-format-attribute -pedantic -Wno-long-long -Werror
-fno-exceptions -fno-rtti -I/devel/gcc/src/libcpp -I.
-I/devel/gcc/src/libcpp/../include -I/devel/gcc/src/libcpp/include    -c -o
line-map.o -MT line-map.o -MMD -MP -MF .deps/line-map.Tpo
/devel/gcc/src/libcpp/line-map.cc
/devel/gcc/src/libcpp/line-map.cc: In function 'int
linemap_compare_locations(line_maps*, location_t, location_t)':
/devel/gcc/src/libcpp/line-map.cc:1434:1: error: statement uses released SSA
name
 1434 | linemap_compare_locations (line_maps *set,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
_219 = _216;
The use of _216 should have been replaced
during GIMPLE pass: dom
/devel/gcc/src/libcpp/line-map.cc:1434:1: internal compiler error: cannot
update SSA form

If you think it might be helpful to reduce line-map.cc then just give me a
ping.

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Stefan Schulze Frielinghaus from comment #4)
> Since r14-4089-gd45ddc2c04e471 bootstrap fails on s390 with
> 
> /devel/gcc/build/./prev-gcc/xg++ -B/devel/gcc/build/./prev-gcc/
> -B/devel/gcc/dst/s390x-ibm-linux-gnu/bin/ -nostdinc++
> -B/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/src/.libs
> -B/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/libsupc++/.libs 
> -I/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/include/s390x-ibm-
> linux-gnu  -I/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/include 
> -I/devel/gcc/src/libstdc++-v3/libsupc++
> -L/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/src/.libs
> -L/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/libsupc++/.libs 
> -I/devel/gcc/src/libcpp -I. -I/devel/gcc/src/libcpp/../include
> -I/devel/gcc/src/libcpp/include  -g -O2 -fchecking=1 -W -Wall -Wno-narrowing
> -Wwrite-strings -Wmissing-format-attribute -pedantic -Wno-long-long -Werror
> -fno-exceptions -fno-rtti -I/devel/gcc/src/libcpp -I.
> -I/devel/gcc/src/libcpp/../include -I/devel/gcc/src/libcpp/include    -c -o
> line-map.o -MT line-map.o -MMD -MP -MF .deps/line-map.Tpo
> /devel/gcc/src/libcpp/line-map.cc
> /devel/gcc/src/libcpp/line-map.cc: In function 'int
> linemap_compare_locations(line_maps*, location_t, location_t)':
> /devel/gcc/src/libcpp/line-map.cc:1434:1: error: statement uses released SSA
> name
>  1434 | linemap_compare_locations (line_maps *set,
>       | ^~~~~~~~~~~~~~~~~~~~~~~~~
> _219 = _216;
> The use of _216 should have been replaced
> during GIMPLE pass: dom
> /devel/gcc/src/libcpp/line-map.cc:1434:1: internal compiler error: cannot
> update SSA form
> 
> If you think it might be helpful to reduce line-map.cc then just give me a
> ping.

that's PR111465, fixed by r14-4128-g564ecb7d5afb0b hopefully

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[stefansf at linux dot ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

--- Comment #6 from Stefan Schulze Frielinghaus <stefansf at linux dot ibm.com> ---
(In reply to Richard Biener from comment #5)
> (In reply to Stefan Schulze Frielinghaus from comment #4)
> > Since r14-4089-gd45ddc2c04e471 bootstrap fails on s390 with
> > 
> > /devel/gcc/build/./prev-gcc/xg++ -B/devel/gcc/build/./prev-gcc/
> > -B/devel/gcc/dst/s390x-ibm-linux-gnu/bin/ -nostdinc++
> > -B/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/src/.libs
> > -B/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/libsupc++/.libs 
> > -I/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/include/s390x-ibm-
> > linux-gnu  -I/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/include 
> > -I/devel/gcc/src/libstdc++-v3/libsupc++
> > -L/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/src/.libs
> > -L/devel/gcc/build/prev-s390x-ibm-linux-gnu/libstdc++-v3/libsupc++/.libs 
> > -I/devel/gcc/src/libcpp -I. -I/devel/gcc/src/libcpp/../include
> > -I/devel/gcc/src/libcpp/include  -g -O2 -fchecking=1 -W -Wall -Wno-narrowing
> > -Wwrite-strings -Wmissing-format-attribute -pedantic -Wno-long-long -Werror
> > -fno-exceptions -fno-rtti -I/devel/gcc/src/libcpp -I.
> > -I/devel/gcc/src/libcpp/../include -I/devel/gcc/src/libcpp/include    -c -o
> > line-map.o -MT line-map.o -MMD -MP -MF .deps/line-map.Tpo
> > /devel/gcc/src/libcpp/line-map.cc
> > /devel/gcc/src/libcpp/line-map.cc: In function 'int
> > linemap_compare_locations(line_maps*, location_t, location_t)':
> > /devel/gcc/src/libcpp/line-map.cc:1434:1: error: statement uses released SSA
> > name
> >  1434 | linemap_compare_locations (line_maps *set,
> >       | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > _219 = _216;
> > The use of _216 should have been replaced
> > during GIMPLE pass: dom
> > /devel/gcc/src/libcpp/line-map.cc:1434:1: internal compiler error: cannot
> > update SSA form
> > 
> > If you think it might be helpful to reduce line-map.cc then just give me a
> > ping.
> 
> that's PR111465, fixed by r14-4128-g564ecb7d5afb0b hopefully

Right, fixed on current trunk. Thanks!

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

--- Comment #7 from seurer at gcc dot gnu.org ---
I am still seeing the same failure on power.

tried with g:668c4c3783970e7adf0591396b6d0d5286cc0541, r14-4930-g668c4c3783970e 

make  -k check-gcc RUNTESTFLAGS="--target_board=unix'{-m32,-m64}'
tree-ssa.exp=gcc.dg/tree-ssa/ssa-sink-18.c"
FAIL: gcc.dg/tree-ssa/ssa-sink-18.c scan-tree-dump-times sink2 "Sunk
statements: 5" 1

make  -k check-gcc RUNTESTFLAGS="--target_board=unix'{-m32,-m64}'
vect.exp=gcc.dg/vect/vect-117.c"
FAIL: gcc.dg/vect/vect-117.c scan-tree-dump-not optimized "Invalid sum"
FAIL: gcc.dg/vect/vect-117.c -flto -ffat-lto-objects  scan-tree-dump-not
optimized "Invalid sum"

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Hm, so with -fno-ivopts there's not much useful sinking left.  That means
the only way to make the testcase less fragile is to add to the list of
xfail ..

I'm going to add powerpc64le-*-* there.

I think the gcc.dg/vect/vect-117.c fallout is sth different and Honzas area
(separate PRs always help ..).

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:ff4cea05a6e6d034eed5212109133c4b5da8520c

commit r14-5005-gff4cea05a6e6d034eed5212109133c4b5da8520c
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Oct 30 11:01:17 2023 +0100

    PR testsuite/111462 - add powerpc64le to list of ssa-sink-18.c XFAIL

            PR testsuite/111462
    gcc/testsuite/
            * gcc.dg/tree-ssa/ssa-sink-18.c: XFAIL also powerpc64le.

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|rguenth at gcc dot gnu.org         |unassigned at gcc dot gnu.org
             Status|ASSIGNED                    |NEW

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Should be fixed now.

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #11 from seurer at gcc dot gnu.org ---
I goofed on the original report as this also failed (and still does) on
powerpc64 BE.  The patch fixed things on LE.

make  -k check-gcc RUNTESTFLAGS="--target_board=unix'{-m32,-m64}'
tree-ssa.exp=gcc.dg/tree-ssa/ssa-sink-18.c"
FAIL: gcc.dg/tree-ssa/ssa-sink-18.c scan-tree-dump-times sink2 "Sunk
statements: 5" 1

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

--- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:92f07eb406612fa341dc33d9d6e4f3781dc09452

commit r14-9208-g92f07eb406612fa341dc33d9d6e4f3781dc09452
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Feb 28 12:09:04 2024 +0100

    testsuite: XFAIL ssa-sink-18.c also on powerpc64 [PR111462]

    powerpc64-linux apparently (not very surprisingly) behaves the same
    way as powerpc64le-linux and has 4 sunk statements rather than 5,
    so we should xfail it on powerpc64*-*-* rather than just powerpc64le-*-*.
    powerpc-linux has 3 sunk statements, but the scan pattern is done for
    lp64 only as the comment explains.

    2024-02-28  Jakub Jelinek  <jakub@redhat.com>

            PR testsuite/111462
            * gcc.dg/tree-ssa/ssa-sink-18.c: XFAIL also on powerpc64.

[Bug testsuite/111462] [14 regression] gcc.dg/tree-ssa/ssa-sink-18.c fails after r14-4089-gd45ddc2c04e471

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111462

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.