public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/111591] ppc64be: miscompilation with -mstrict-align / -O3 Date: Thu, 19 Oct 2023 11:06:08 +0000 [thread overview] Message-ID: <bug-111591-4-R3vUnOp5kh@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111591-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111591 --- Comment #22 from Richard Biener <rguenth at gcc dot gnu.org> --- I see the mems properly get their base adjusted: (insn 384 383 0 (set (mem/c:V2DI (plus:DI (reg/f:DI 112 virtual-stack-vars) (const_int 16 [0x10])) [7 MEM[(struct Vec128D.30433 *)_10]+0 S16 A128]) (reg:V2DI 616)) -1 (nil)) vs. (insn 389 388 390 (set (reg:HI 619) (mem/c:HI (plus:DI (reg/f:DI 112 virtual-stack-vars) (const_int 16 [0x10])) [4 MEM[(struct Vec128D.30212 *)_10].rawD.30221[0]+0 S2 A128])) "test.cc":218:14 -1 (nil)) both are based off a fake _10. But we get alias sets 7 and 4 used here which might be a problem. See update_alias_info_with_stack_vars and uses of decls_to_pointers, in particular from set_mem_attributes_minus_bitpos where we preserve TBAA info with the rewrite. I'm not sure why that should be OK ... (but I'm sure I must have thought of this problem back in time) Does the following fix the testcase? diff --git a/gcc/emit-rtl.cc b/gcc/emit-rtl.cc index 84b6833225e..81c0a63eddc 100644 --- a/gcc/emit-rtl.cc +++ b/gcc/emit-rtl.cc @@ -2128,7 +2128,7 @@ set_mem_attributes_minus_bitpos (rtx ref, tree t, int objectp, tree *orig_base = &attrs.expr; while (handled_component_p (*orig_base)) orig_base = &TREE_OPERAND (*orig_base, 0); - tree aptrt = reference_alias_ptr_type (*orig_base); + tree aptrt = ptr_type_node; *orig_base = build2 (MEM_REF, TREE_TYPE (*orig_base), *namep, build_int_cst (aptrt, 0)); }
next prev parent reply other threads:[~2023-10-19 11:06 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-25 11:53 [Bug target/111591] New: " malat at debian dot org 2023-09-25 11:55 ` [Bug target/111591] " malat at debian dot org 2023-09-25 11:59 ` rguenth at gcc dot gnu.org 2023-09-25 12:20 ` malat at debian dot org 2023-09-25 13:15 ` malat at debian dot org 2023-09-25 13:41 ` malat at debian dot org 2023-09-26 6:50 ` linkw at gcc dot gnu.org 2023-09-26 7:56 ` rguenth at gcc dot gnu.org 2023-09-26 8:14 ` linkw at gcc dot gnu.org 2023-09-26 9:28 ` malat at debian dot org 2023-09-26 9:28 ` malat at debian dot org 2023-09-26 9:31 ` malat at debian dot org 2023-09-26 9:31 ` malat at debian dot org 2023-09-27 9:24 ` linkw at gcc dot gnu.org 2023-09-27 9:26 ` rguenth at gcc dot gnu.org 2023-09-28 0:20 ` linkw at gcc dot gnu.org 2023-10-13 10:19 ` linkw at gcc dot gnu.org 2023-10-13 11:08 ` rguenth at gcc dot gnu.org 2023-10-13 12:09 ` linkw at gcc dot gnu.org 2023-10-13 12:32 ` rguenth at gcc dot gnu.org 2023-10-16 9:11 ` linkw at gcc dot gnu.org 2023-10-19 7:27 ` linkw at gcc dot gnu.org 2023-10-19 11:06 ` rguenth at gcc dot gnu.org [this message] 2023-10-19 11:12 ` rguenth at gcc dot gnu.org 2023-10-20 5:53 ` linkw at gcc dot gnu.org 2023-10-20 6:25 ` rguenth at gcc dot gnu.org 2023-10-23 3:21 ` linkw at gcc dot gnu.org 2023-10-23 9:48 ` rguenth at gcc dot gnu.org 2023-10-23 12:36 ` matz at gcc dot gnu.org 2023-10-23 13:30 ` rguenth at gcc dot gnu.org 2023-10-23 14:04 ` rguenth at gcc dot gnu.org 2023-10-24 2:59 ` linkw at gcc dot gnu.org 2023-10-31 6:40 ` linkw at gcc dot gnu.org 2023-12-13 8:00 ` cvs-commit at gcc dot gnu.org 2023-12-13 8:02 ` rguenth at gcc dot gnu.org 2023-12-13 8:12 ` rguenth at gcc dot gnu.org 2023-12-15 7:32 ` malat at debian dot org 2023-12-15 7:43 ` rguenth at gcc dot gnu.org 2023-12-15 10:01 ` linkw at gcc dot gnu.org 2023-12-15 10:23 ` rguenth at gcc dot gnu.org 2023-12-15 11:28 ` malat at debian dot org 2023-12-15 11:32 ` rguenth at gcc dot gnu.org 2023-12-18 6:01 ` linkw at gcc dot gnu.org 2023-12-18 6:03 ` linkw at gcc dot gnu.org 2023-12-19 5:38 ` linkw at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111591-4-R3vUnOp5kh@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).