public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111591] ppc64be: miscompilation with -mstrict-align / -O3
Date: Thu, 19 Oct 2023 07:27:27 +0000	[thread overview]
Message-ID: <bug-111591-4-YeYIZijWOt@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111591-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111591

--- Comment #21 from Kewen Lin <linkw at gcc dot gnu.org> ---
For optimized IR:

  a$raw$3_220 = D.39813.rawD.30221[3];
  vect_a_raw_4_70.539_1584 = MEM <vector(4) short intD.20> [(short intD.20
*)&D.39813 + 8B];
  _1640 = a$raw$0_221 & 255;
  _1649 = a$raw$1_74 & 255;
  _1658 = a$raw$2_264 & 255;
  _52 = a$raw$3_220 & 255;
  vD.39776 = bD.39739;                  // involved decl1
  MEM <unsigned charD.25[16]> [(charD.5 * {ref-all})&b00D.39742] = MEM
<unsigned charD.25[16]> [(charD.5 * {ref-all})&vD.39776];
  vD.39776 ={v} {CLOBBER(eol)};
  vD.39779 = b00D.39742;                // involved decl2
  raw_u_1614 = vD.39779.rawD.30221[0];
  _1615 = raw_u_1614 << 8;
  vD.39779.rawD.30221[0] = _1615;
  raw_u_1622 = vD.39779.rawD.30221[1];
  _1623 = raw_u_1622 << 8;
  vD.39779.rawD.30221[1] = _1623;
...

Partition 1: size 16 align 16
        D.39819 vD.39749        vD.39756        vD.39764        aD.39773       
vD.39779        vD.39735        vD.39736        aD.39630        vD.39636       
aD.39640        vD.39753        vD.39761        vD.39776        vD.39782

vD.39776 and vD.39779 are coalesced.

It's expanded as:

  vD.39776 = bD.39739;    

(insn 383 382 384 (set (reg:V2DI 616)
        (mem/c:V2DI (plus:DI (reg/f:DI 112 virtual-stack-vars)
                (const_int 48 [0x30])) [7 MEM[(struct Vec128D.30433 *)_1274]+0
S16 A128])) -1
     (nil))

(insn 384 383 0 (set (mem/c:V2DI (plus:DI (reg/f:DI 112 virtual-stack-vars)
                (const_int 16 [0x10])) [7 MEM[(struct Vec128D.30433 *)_10]+0
S16 A128])
        (reg:V2DI 616)) -1
     (nil))

  MEM <unsigned charD.25[16]> [(charD.5 * {ref-all})&b00D.39742] = MEM
<unsigned charD.25[16]> [(charD.5 * {ref-all})&vD.39776];

(insn 385 384 386 (set (reg:V2DI 617)
        (mem/c:V2DI (plus:DI (reg/f:DI 112 virtual-stack-vars)
                (const_int 16 [0x10])) [0 MEM <unsigned charD.25[16]> [(charD.5
* {ref-all})_10]+0 S16 A128])) "test.cc":14:19 -1
     (nil))

(insn 386 385 0 (set (mem/c:V2DI (plus:DI (reg/f:DI 112 virtual-stack-vars)
                (const_int 80 [0x50])) [0 MEM <unsigned charD.25[16]> [(charD.5
* {ref-all})_1277]+0 S16 A128])
        (reg:V2DI 617)) "test.cc":14:19 -1
     (nil))

  vD.39776 ={v} {CLOBBER(eol)};

  vD.39779 = b00D.39742;

(insn 387 386 388 (set (reg:V2DI 618)
        (mem/c:V2DI (plus:DI (reg/f:DI 112 virtual-stack-vars)
                (const_int 80 [0x50])) [5 MEM[(struct Vec128D.30212 *)_1277]+0
S16 A128])) -1
     (nil))

(insn 388 387 0 (set (mem/c:V2DI (plus:DI (reg/f:DI 112 virtual-stack-vars)
                (const_int 16 [0x10])) [5 MEM[(struct Vec128D.30212 *)_10]+0
S16 A128])
        (reg:V2DI 618)) -1
     (nil))

  raw_u_1614 = vD.39779.rawD.30221[0];
  _1615 = raw_u_1614 << 8;
  vD.39779.rawD.30221[0] = _1615;

;; v.raw[0] = _1615;

(insn 389 388 390 (set (reg:HI 619)
        (mem/c:HI (plus:DI (reg/f:DI 112 virtual-stack-vars)
                (const_int 16 [0x10])) [4 MEM[(struct Vec128D.30212
*)_10].rawD.30221[0]+0 S2 A128])) "test.cc":218:14 -1
     (nil))

(insn 390 389 391 (set (reg:SI 620)
        (ashift:SI (subreg:SI (reg:HI 619) 0)
            (const_int 8 [0x8]))) "test.cc":218:14 -1
     (nil))

(insn 391 390 0 (set (mem/c:HI (plus:DI (reg/f:DI 112 virtual-stack-vars)
                (const_int 16 [0x10])) [4 MEM[(struct Vec128D.30212
*)_10].rawD.30221[0]+0 S2 A128])
        (subreg:HI (reg:SI 620) 2)) "test.cc":218:14 -1
     (nil))

=========

Later, insn 388 gets removed (also insn 387 and 385), as the store value is
exactly the same as what insn 384 has. And the scheduler doesn't consider there
is a dependence between insn 389 and insn 384 then results in unexpected move.

Hi Richi, do you think that this is exactly duplicated of known -fstack-reuse
issue?

  parent reply	other threads:[~2023-10-19  7:27 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 11:53 [Bug target/111591] New: " malat at debian dot org
2023-09-25 11:55 ` [Bug target/111591] " malat at debian dot org
2023-09-25 11:59 ` rguenth at gcc dot gnu.org
2023-09-25 12:20 ` malat at debian dot org
2023-09-25 13:15 ` malat at debian dot org
2023-09-25 13:41 ` malat at debian dot org
2023-09-26  6:50 ` linkw at gcc dot gnu.org
2023-09-26  7:56 ` rguenth at gcc dot gnu.org
2023-09-26  8:14 ` linkw at gcc dot gnu.org
2023-09-26  9:28 ` malat at debian dot org
2023-09-26  9:28 ` malat at debian dot org
2023-09-26  9:31 ` malat at debian dot org
2023-09-26  9:31 ` malat at debian dot org
2023-09-27  9:24 ` linkw at gcc dot gnu.org
2023-09-27  9:26 ` rguenth at gcc dot gnu.org
2023-09-28  0:20 ` linkw at gcc dot gnu.org
2023-10-13 10:19 ` linkw at gcc dot gnu.org
2023-10-13 11:08 ` rguenth at gcc dot gnu.org
2023-10-13 12:09 ` linkw at gcc dot gnu.org
2023-10-13 12:32 ` rguenth at gcc dot gnu.org
2023-10-16  9:11 ` linkw at gcc dot gnu.org
2023-10-19  7:27 ` linkw at gcc dot gnu.org [this message]
2023-10-19 11:06 ` rguenth at gcc dot gnu.org
2023-10-19 11:12 ` rguenth at gcc dot gnu.org
2023-10-20  5:53 ` linkw at gcc dot gnu.org
2023-10-20  6:25 ` rguenth at gcc dot gnu.org
2023-10-23  3:21 ` linkw at gcc dot gnu.org
2023-10-23  9:48 ` rguenth at gcc dot gnu.org
2023-10-23 12:36 ` matz at gcc dot gnu.org
2023-10-23 13:30 ` rguenth at gcc dot gnu.org
2023-10-23 14:04 ` rguenth at gcc dot gnu.org
2023-10-24  2:59 ` linkw at gcc dot gnu.org
2023-10-31  6:40 ` linkw at gcc dot gnu.org
2023-12-13  8:00 ` cvs-commit at gcc dot gnu.org
2023-12-13  8:02 ` rguenth at gcc dot gnu.org
2023-12-13  8:12 ` rguenth at gcc dot gnu.org
2023-12-15  7:32 ` malat at debian dot org
2023-12-15  7:43 ` rguenth at gcc dot gnu.org
2023-12-15 10:01 ` linkw at gcc dot gnu.org
2023-12-15 10:23 ` rguenth at gcc dot gnu.org
2023-12-15 11:28 ` malat at debian dot org
2023-12-15 11:32 ` rguenth at gcc dot gnu.org
2023-12-18  6:01 ` linkw at gcc dot gnu.org
2023-12-18  6:03 ` linkw at gcc dot gnu.org
2023-12-19  5:38 ` linkw at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111591-4-YeYIZijWOt@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).