public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/111784] New: [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures
@ 2023-10-12 13:02 acoplan at gcc dot gnu.org
2023-10-12 15:30 ` [Bug target/111784] " acoplan at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: acoplan at gcc dot gnu.org @ 2023-10-12 13:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111784
Bug ID: 111784
Summary: [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test
failures
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: acoplan at gcc dot gnu.org
Target Milestone: ---
Since r14-4579-g0bdb9bb5607edd7df1ee74ddfcadb87324ca00c2 the following aarch64
tests are failing:
FAIL: gcc.target/aarch64/ldp_stp_15.c check-function-bodies dup_8_int32_t
FAIL: gcc.target/aarch64/ldp_stp_15.c check-function-bodies cons2_16_int32_t
FAIL: gcc.target/aarch64/ldp_stp_15.c check-function-bodies cons4_8_int32_t
FAIL: gcc.target/aarch64/ldp_stp_16.c check-function-bodies cons2_4_float
FAIL: gcc.target/aarch64/ldp_stp_17.c check-function-bodies dup_16_int64_t
FAIL: gcc.target/aarch64/ldp_stp_17.c check-function-bodies cons2_16_int64_t
FAIL: gcc.target/aarch64/ldp_stp_17.c check-function-bodies cons4_16_int64_t
FAIL: gcc.target/aarch64/ldp_stp_18.c check-function-bodies dup_8_double
FAIL: gcc.target/aarch64/ldp_stp_18.c check-function-bodies dup_16_double
FAIL: gcc.target/aarch64/ldp_stp_18.c check-function-bodies cons2_4_double
FAIL: gcc.target/aarch64/ldp_stp_18.c check-function-bodies cons2_8_double
FAIL: gcc.target/aarch64/ldp_stp_18.c check-function-bodies cons2_8_double
FAIL: gcc.target/aarch64/ldp_stp_18.c check-function-bodies cons2_8_double
E.g. for dup8_int32_t, we now generate:
dup_8_int32_t:
.LFB9:
.cfi_startproc
stp w1, w1, [x0]
stp w1, w1, [x0, 8]
stp w1, w1, [x0, 16]
stp w1, w1, [x0, 24]
ret
instead of a dup with a q-register stp. Most likely we need to update the costs
on the aarch64 side.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/111784] [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures
2023-10-12 13:02 [Bug target/111784] New: [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures acoplan at gcc dot gnu.org
@ 2023-10-12 15:30 ` acoplan at gcc dot gnu.org
2023-10-13 0:52 ` [Bug target/111784] [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures since r14-4579 linkw at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: acoplan at gcc dot gnu.org @ 2023-10-12 15:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111784
--- Comment #1 from Alex Coplan <acoplan at gcc dot gnu.org> ---
More context/details about the issue in 8/10 of the original patch series (that
the above revision comes from):
https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630234.html
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/111784] [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures since r14-4579
2023-10-12 13:02 [Bug target/111784] New: [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures acoplan at gcc dot gnu.org
2023-10-12 15:30 ` [Bug target/111784] " acoplan at gcc dot gnu.org
@ 2023-10-13 0:52 ` linkw at gcc dot gnu.org
2023-10-13 6:48 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: linkw at gcc dot gnu.org @ 2023-10-13 0:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111784
Kewen Lin <linkw at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[14 Regression] aarch64: |[14 Regression] aarch64:
|ldp_stp_{15,16,17,18}.c |ldp_stp_{15,16,17,18}.c
|test failures |test failures since
| |r14-4579
Assignee|unassigned at gcc dot gnu.org |linkw at gcc dot gnu.org
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2023-10-13
CC| |linkw at gcc dot gnu.org
--- Comment #2 from Kewen Lin <linkw at gcc dot gnu.org> ---
Thanks for reporting!
(In reply to Alex Coplan from comment #1)
> More context/details about the issue in 8/10 of the original patch series
> (that the above revision comes from):
> https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630234.html
Yeah, there are some discussion under this thread, I'll make a patch to cover
both load and store.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/111784] [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures since r14-4579
2023-10-12 13:02 [Bug target/111784] New: [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures acoplan at gcc dot gnu.org
2023-10-12 15:30 ` [Bug target/111784] " acoplan at gcc dot gnu.org
2023-10-13 0:52 ` [Bug target/111784] [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures since r14-4579 linkw at gcc dot gnu.org
@ 2023-10-13 6:48 ` rguenth at gcc dot gnu.org
2023-10-23 2:24 ` cvs-commit at gcc dot gnu.org
2023-10-23 6:16 ` linkw at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-10-13 6:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111784
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |14.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/111784] [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures since r14-4579
2023-10-12 13:02 [Bug target/111784] New: [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures acoplan at gcc dot gnu.org
` (2 preceding siblings ...)
2023-10-13 6:48 ` rguenth at gcc dot gnu.org
@ 2023-10-23 2:24 ` cvs-commit at gcc dot gnu.org
2023-10-23 6:16 ` linkw at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-10-23 2:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111784
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:
https://gcc.gnu.org/g:1908775f7982bd2de36df5d94396eca0865bad9a
commit r14-4842-g1908775f7982bd2de36df5d94396eca0865bad9a
Author: Kewen Lin <linkw@linux.ibm.com>
Date: Sun Oct 22 21:18:40 2023 -0500
vect: Cost adjacent vector loads/stores together [PR111784]
As comments[1][2], this patch is to change the costing way
on some adjacent vector loads/stores from costing one by
one to costing them together with the total number once.
It helps to fix the exposed regression PR111784 on aarch64,
as aarch64 specific costing could make different decisions
according to the different costing ways (counting with total
number vs. counting one by one). Based on a reduced test
case from PR111784, only considering vec_num can fix the
regression already, but vector loads/stores in regard to
ncopies are also adjacent accesses, so they are considered
as well.
btw, this patch leaves the costing on dr_explicit_realign
and dr_explicit_realign_optimized alone to make it simple.
The costing way change can cause the differences for them
since there is one costing depending on targetm.vectorize.
builtin_mask_for_load and it's costed according to the
calling times. IIUC, these two dr_alignment_support are
mainly used for old Power? (only having 16 bytes aligned
vector load/store but no unaligned vector load/store).
[1] https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630742.html
[2] https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630744.html
PR tree-optimization/111784
gcc/ChangeLog:
* tree-vect-stmts.cc (vectorizable_store): Adjust costing way for
adjacent vector stores, by costing them with the total number
rather than costing them one by one.
(vectorizable_load): Adjust costing way for adjacent vector
loads, by costing them with the total number rather than costing
them one by one.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/111784] [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures since r14-4579
2023-10-12 13:02 [Bug target/111784] New: [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures acoplan at gcc dot gnu.org
` (3 preceding siblings ...)
2023-10-23 2:24 ` cvs-commit at gcc dot gnu.org
@ 2023-10-23 6:16 ` linkw at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: linkw at gcc dot gnu.org @ 2023-10-23 6:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111784
Kewen Lin <linkw at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Kewen Lin <linkw at gcc dot gnu.org> ---
Should be fixed on trunk.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-23 6:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-12 13:02 [Bug target/111784] New: [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures acoplan at gcc dot gnu.org
2023-10-12 15:30 ` [Bug target/111784] " acoplan at gcc dot gnu.org
2023-10-13 0:52 ` [Bug target/111784] [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures since r14-4579 linkw at gcc dot gnu.org
2023-10-13 6:48 ` rguenth at gcc dot gnu.org
2023-10-23 2:24 ` cvs-commit at gcc dot gnu.org
2023-10-23 6:16 ` linkw at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).