public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/111787] New: [14 regression] xxx breaks build
@ 2023-10-12 15:08 seurer at gcc dot gnu.org
2023-10-12 15:11 ` [Bug bootstrap/111787] [14 regression] r14-4592-g0d00385eaf72cc " jakub at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: seurer at gcc dot gnu.org @ 2023-10-12 15:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111787
Bug ID: 111787
Summary: [14 regression] xxx breaks build
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: bootstrap
Assignee: unassigned at gcc dot gnu.org
Reporter: seurer at gcc dot gnu.org
Target Milestone: ---
g:0d00385eaf72ccacff17935b0d214a26773e095f, r14-4592-g0d00385eaf72cc
g++ -c -g -O2 -DIN_GCC -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -Wconditionally-supported
-Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros
-Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -DGENERATOR_FILE -I.
-Ibuild -I/home/seurer/gcc/git/gcc-trunk/gcc
-I/home/seurer/gcc/git/gcc-trunk/gcc/build
-I/home/seurer/gcc/git/gcc-trunk/gcc/../include
-I/home/seurer/gcc/git/gcc-trunk/gcc/../libcpp/include \
-o build/gencondmd.o build/gencondmd.cc
In file included from /home/seurer/gcc/git/gcc-trunk/gcc/recog.h:24,
from build/gencondmd.cc:40:
/home/seurer/gcc/git/gcc-trunk/gcc/tree.h:6296:10: error: template argument
'wi::int_traits<wi::extended_tree<N> >::precision_type' involves template
parameter(s)
struct ints_for <generic_wide_int <extended_tree <N> >,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
int_traits <extended_tree <N> >::precision_type>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:2951: build/gencondmd.o] Error 1
commit 0d00385eaf72ccacff17935b0d214a26773e095f (HEAD)
Author: Jakub Jelinek <jakub@redhat.com>
Date: Thu Oct 12 16:01:12 2023 +0200
wide-int: Allow up to 16320 bits wide_int and change widest_int precision
to 32640 bits [PR102989]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug bootstrap/111787] [14 regression] r14-4592-g0d00385eaf72cc breaks build
2023-10-12 15:08 [Bug bootstrap/111787] New: [14 regression] xxx breaks build seurer at gcc dot gnu.org
@ 2023-10-12 15:11 ` jakub at gcc dot gnu.org
2023-10-12 15:23 ` seurer at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-10-12 15:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111787
--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Does
2023-10-12 Jakub Jelinek <jakub@redhat.com>
PR bootstrap/111787
* tree.h (wi::int_traits <unextended_tree>::needs_write_val_arg): New
static data member.
(int_traits <extended_tree <N>>::needs_write_val_arg): Likewise.
(wi::ints_for): Provide separate partial specializations for
generic_wide_int <extended_tree <N>> and INL_CONST_PRECISION or that
and CONST_PRECISION, rather than using
int_traits <extended_tree <N> >::precision_type as the second template
argument.
* rtl.h (wi::int_traits <rtx_mode_t>::needs_write_val_arg): New
static data member.
* double-int.h (wi::int_traits <double_int>::needs_write_val_arg):
Likewise.
--- gcc/tree.h.jj 2023-10-12 16:01:04.000000000 +0200
+++ gcc/tree.h 2023-10-12 16:52:51.977954615 +0200
@@ -6237,6 +6237,7 @@ namespace wi
static const enum precision_type precision_type = VAR_PRECISION;
static const bool host_dependent_precision = false;
static const bool is_sign_extended = false;
+ static const bool needs_write_val_arg = false;
};
template <int N>
@@ -6262,6 +6263,7 @@ namespace wi
= N == ADDR_MAX_PRECISION ? INL_CONST_PRECISION : CONST_PRECISION;
static const bool host_dependent_precision = false;
static const bool is_sign_extended = true;
+ static const bool needs_write_val_arg = false;
static const unsigned int precision = N;
};
@@ -6293,8 +6295,14 @@ namespace wi
tree_to_poly_wide_ref to_poly_wide (const_tree);
template <int N>
- struct ints_for <generic_wide_int <extended_tree <N> >,
- int_traits <extended_tree <N> >::precision_type>
+ struct ints_for <generic_wide_int <extended_tree <N> >, INL_CONST_PRECISION>
+ {
+ typedef generic_wide_int <extended_tree <N> > extended;
+ static extended zero (const extended &);
+ };
+
+ template <int N>
+ struct ints_for <generic_wide_int <extended_tree <N> >, CONST_PRECISION>
{
typedef generic_wide_int <extended_tree <N> > extended;
static extended zero (const extended &);
@@ -6532,8 +6540,15 @@ wi::to_poly_wide (const_tree t)
template <int N>
inline generic_wide_int <wi::extended_tree <N> >
wi::ints_for <generic_wide_int <wi::extended_tree <N> >,
- wi::int_traits <wi::extended_tree <N> >::precision_type
- >::zero (const extended &x)
+ wi::INL_CONST_PRECISION>::zero (const extended &x)
+{
+ return build_zero_cst (TREE_TYPE (x.get_tree ()));
+}
+
+template <int N>
+inline generic_wide_int <wi::extended_tree <N> >
+wi::ints_for <generic_wide_int <wi::extended_tree <N> >,
+ wi::CONST_PRECISION>::zero (const extended &x)
{
return build_zero_cst (TREE_TYPE (x.get_tree ()));
}
--- gcc/rtl.h.jj 2023-09-29 22:04:44.463012421 +0200
+++ gcc/rtl.h 2023-10-12 16:54:59.915240074 +0200
@@ -2270,6 +2270,7 @@ namespace wi
/* This ought to be true, except for the special case that BImode
is canonicalized to STORE_FLAG_VALUE, which might be 1. */
static const bool is_sign_extended = false;
+ static const bool needs_write_val_arg = false;
static unsigned int get_precision (const rtx_mode_t &);
static wi::storage_ref decompose (HOST_WIDE_INT *, unsigned int,
const rtx_mode_t &);
--- gcc/double-int.h.jj 2023-10-12 16:01:04.260164202 +0200
+++ gcc/double-int.h 2023-10-12 16:53:41.401292272 +0200
@@ -442,6 +442,7 @@ namespace wi
{
static const enum precision_type precision_type = INL_CONST_PRECISION;
static const bool host_dependent_precision = true;
+ static const bool needs_write_val_arg = false;
static const unsigned int precision = HOST_BITS_PER_DOUBLE_INT;
static unsigned int get_precision (const double_int &);
static wi::storage_ref decompose (HOST_WIDE_INT *, unsigned int,
fix this?
It works for me in stage3 gcc subdir, but that worked fine without it too (I've
been using g++ 12 as stage1 compiler).
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug bootstrap/111787] [14 regression] r14-4592-g0d00385eaf72cc breaks build
2023-10-12 15:08 [Bug bootstrap/111787] New: [14 regression] xxx breaks build seurer at gcc dot gnu.org
2023-10-12 15:11 ` [Bug bootstrap/111787] [14 regression] r14-4592-g0d00385eaf72cc " jakub at gcc dot gnu.org
@ 2023-10-12 15:23 ` seurer at gcc dot gnu.org
2023-10-12 15:24 ` cvs-commit at gcc dot gnu.org
2023-10-13 6:48 ` rguenth at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: seurer at gcc dot gnu.org @ 2023-10-12 15:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111787
--- Comment #2 from seurer at gcc dot gnu.org ---
This system is on RHEL 8 which has gcc 8.5 as the distro compiler.
And yes, the patch worked.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug bootstrap/111787] [14 regression] r14-4592-g0d00385eaf72cc breaks build
2023-10-12 15:08 [Bug bootstrap/111787] New: [14 regression] xxx breaks build seurer at gcc dot gnu.org
2023-10-12 15:11 ` [Bug bootstrap/111787] [14 regression] r14-4592-g0d00385eaf72cc " jakub at gcc dot gnu.org
2023-10-12 15:23 ` seurer at gcc dot gnu.org
@ 2023-10-12 15:24 ` cvs-commit at gcc dot gnu.org
2023-10-13 6:48 ` rguenth at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-10-12 15:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111787
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:53a94071fa9e90e268a94adbdc903bd868ddeec1
commit r14-4596-g53a94071fa9e90e268a94adbdc903bd868ddeec1
Author: Jakub Jelinek <jakub@redhat.com>
Date: Thu Oct 12 17:20:36 2023 +0200
wide-int: Fix build with gcc < 12 or clang++ [PR111787]
While my wide_int patch bootstrapped/regtested fine when I used GCC 12
as system gcc, apparently it doesn't with GCC 11 and older or clang++.
For GCC before PR96555 C++ DR1315 implementation the compiler complains
about template argument involving template parameters, for clang++ the
same + complains about missing needs_write_val_arg static data member
in some wi::int_traits specializations.
2023-10-12 Jakub Jelinek <jakub@redhat.com>
PR bootstrap/111787
* tree.h (wi::int_traits <unextended_tree>::needs_write_val_arg):
New
static data member.
(int_traits <extended_tree <N>>::needs_write_val_arg): Likewise.
(wi::ints_for): Provide separate partial specializations for
generic_wide_int <extended_tree <N>> and INL_CONST_PRECISION or
that
and CONST_PRECISION, rather than using
int_traits <extended_tree <N> >::precision_type as the second
template
argument.
* rtl.h (wi::int_traits <rtx_mode_t>::needs_write_val_arg): New
static data member.
* double-int.h (wi::int_traits <double_int>::needs_write_val_arg):
Likewise.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug bootstrap/111787] [14 regression] r14-4592-g0d00385eaf72cc breaks build
2023-10-12 15:08 [Bug bootstrap/111787] New: [14 regression] xxx breaks build seurer at gcc dot gnu.org
` (2 preceding siblings ...)
2023-10-12 15:24 ` cvs-commit at gcc dot gnu.org
@ 2023-10-13 6:48 ` rguenth at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-10-13 6:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111787
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
Target Milestone|--- |14.0
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-13 6:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-12 15:08 [Bug bootstrap/111787] New: [14 regression] xxx breaks build seurer at gcc dot gnu.org
2023-10-12 15:11 ` [Bug bootstrap/111787] [14 regression] r14-4592-g0d00385eaf72cc " jakub at gcc dot gnu.org
2023-10-12 15:23 ` seurer at gcc dot gnu.org
2023-10-12 15:24 ` cvs-commit at gcc dot gnu.org
2023-10-13 6:48 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).