[Bug tree-optimization/112419] New: [14 Regression] gcc.dg/Wnonnull-4.c excess error for 32-bit targets

[Bug tree-optimization/112419] New: [14 Regression] gcc.dg/Wnonnull-4.c excess error for 32-bit targets

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112419

            Bug ID: 112419
           Summary: [14 Regression] gcc.dg/Wnonnull-4.c excess error for
                    32-bit targets
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hp at gcc dot gnu.org
                CC: uecker at gcc dot gnu.org
  Target Milestone: ---

This test started failing with r14-5115-g6e9ee44d96e5 thus:
Running /x/gcc/testsuite/gcc.dg/dg.exp ...
FAIL: gcc.dg/Wnonnull-4.c (test for excess errors)

In gcc.log (after all PASS lines):
FAIL: gcc.dg/Wnonnull-4.c (test for excess errors)
Excess errors:
/o/gcc/gcc/testsuite/gcc.dg/Wnonnull-4.c:144:3: warning: 'fda_n_5' specified
size 4294967256 exceeds maximum object size 2147483647 [-Wstringop-overflow=]

The same happen for all 32-bit targets (including 64-bit targets when testing
with a "-m32"-type option), according to posts to gcc-testresults@ around this
commit.

[Bug tree-optimization/112419] [14 Regression] gcc.dg/Wnonnull-4.c excess error for 32-bit targets

[uecker at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112419

uecker at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=98541
   Last reconfirmed|                            |2023-11-07
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from uecker at gcc dot gnu.org ---

Confirmed. I think adding -Wstringop-overflow= to the test might fix it. It is
just some test which is wrong for 32 bit targets and somehow this problems
appeared now due to an unrelated change.

I will try this and submit a patch.

[Bug testsuite/112419] [14 Regression] gcc.dg/Wnonnull-4.c excess error for 32-bit targets

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112419

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testsuite-fail
   Target Milestone|---                         |14.0

[Bug testsuite/112419] [14 Regression] gcc.dg/Wnonnull-4.c excess error for 32-bit targets

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112419

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |uecker at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #2 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Hah, I missed that there was indeed some deliberate play with overflow-large
objects, so testsuite is the right component designation.  Perhaps there's even
a missing warning or two.  Out of scope for this ticket though.  I took the
liberty of assigning you the ticket, obvious since you say you're in the
process already.

[Bug testsuite/112419] [14 Regression] gcc.dg/Wnonnull-4.c excess error for 32-bit targets

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112419

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
           Assignee|uecker at gcc dot gnu.org          |hp at gcc dot gnu.org
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2023-Novembe
                   |                            |r/636717.html

--- Comment #3 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to uecker from comment #1)
> Confirmed. I think adding -Wstringop-overflow= to the test might fix it. It
> is just some test which is wrong for 32 bit targets and somehow this
> problems appeared now due to an unrelated change.
> 
> I will try this and submit a patch.

I guess you got side-tracked.  I posted a patch hence taking the PR.

[Bug testsuite/112419] [14 Regression] gcc.dg/Wnonnull-4.c excess error for 32-bit targets

[uecker at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112419

--- Comment #4 from uecker at gcc dot gnu.org ---

I was a bit busy. My idea would have been to split the file up into warnings
for Wnonnull and Wstringop. Your patch should work though (but I can't
approve).

[Bug testsuite/112419] [14 Regression] gcc.dg/Wnonnull-4.c excess error for 32-bit targets

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112419

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hans-Peter Nilsson <hp@gcc.gnu.org>:

https://gcc.gnu.org/g:0d51e17791c7876396ed0f6cc51bf103e518877d

commit r14-6203-g0d51e17791c7876396ed0f6cc51bf103e518877d
Author: Hans-Peter Nilsson <hp@axis.com>
Date:   Thu Nov 16 03:50:31 2023 +0100

    gcc.dg/Wnonnull-4.c: Handle new overflow warning for 32-bit targets
[PR112419]

            PR testsuite/112419
            * gcc.dg/Wnonnull-4.c (test_fda_n_5): Expect warning for exceeding
            maximum object size for 32-bit targets.

[Bug testsuite/112419] [14 Regression] gcc.dg/Wnonnull-4.c excess error for 32-bit targets

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112419

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.  I guess.

[Bug testsuite/112419] [14 Regression] gcc.dg/Wnonnull-4.c excess error for 32-bit targets

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112419

--- Comment #7 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #6)
> Fixed.  I guess.

Correct; sorry, I should have close it myself after the commit.