public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/112724] New: C++ "'excess_precision_expr' not supported by dump_expr<expression error>"
@ 2023-11-27 9:52 tschwinge at gcc dot gnu.org
2023-11-27 9:53 ` [Bug c++/112724] " tschwinge at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2023-11-27 9:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112724
Bug ID: 112724
Summary: C++ "'excess_precision_expr' not supported by
dump_expr<expression error>"
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Keywords: diagnostic, testsuite-fail
Severity: normal
Priority: P3
Component: c++
Assignee: unassigned at gcc dot gnu.org
Reporter: tschwinge at gcc dot gnu.org
CC: burnus at gcc dot gnu.org, jakub at gcc dot gnu.org
Target Milestone: ---
(Only) in '-m32' testing of x86_64-pc-linux-gnu, I see (only) for C++ testing
of the test case added in commit
r14-5827-g1802f64e674eeef0c0d7e8f6ca2846145ec16315 "OpenMP: Accept argument to
depobj's destroy clause":
+PASS: c-c++-common/gomp/depobj-3.c -std=c++98 at line 17 (test for
warnings, line 15)
+FAIL: c-c++-common/gomp/depobj-3.c -std=c++98 at line 39 (test for
warnings, line 37)
+PASS: c-c++-common/gomp/depobj-3.c -std=c++98 at line 43 (test for
errors, line 41)
+PASS: c-c++-common/gomp/depobj-3.c -std=c++98 (test for warnings, line
45)
+FAIL: c-c++-common/gomp/depobj-3.c -std=c++98 (test for excess errors)
[...]/c-c++-common/gomp/depobj-3.c: In function 'int main()':
[...]/c-c++-common/gomp/depobj-3.c:37:38: warning: the 'destroy' expression
''excess_precision_expr' not supported by dump_expr<expression error>' should
be the same as the 'depobj' argument 'obj' [-Wopenmp]
This should be:
[...]/c-c++-common/gomp/depobj-3.c:37:38: warning: the 'destroy' expression
'(a + (float)5)' should be the same as the 'depobj' argument 'obj' [-Wopenmp]
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug c++/112724] C++ "'excess_precision_expr' not supported by dump_expr<expression error>"
2023-11-27 9:52 [Bug c++/112724] New: C++ "'excess_precision_expr' not supported by dump_expr<expression error>" tschwinge at gcc dot gnu.org
@ 2023-11-27 9:53 ` tschwinge at gcc dot gnu.org
2023-11-27 10:01 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2023-11-27 9:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112724
--- Comment #1 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
I found that PR108698 "decltype ((T() + ‘excess_precision_expr’ not supported
by dump_expr<expression error>)) median(ndarray<T>) [with T = double]’: since
r13-3290-g98e341130f87984a" discussed a similar issue, but I don't know if it's
actually related.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug c++/112724] C++ "'excess_precision_expr' not supported by dump_expr<expression error>"
2023-11-27 9:52 [Bug c++/112724] New: C++ "'excess_precision_expr' not supported by dump_expr<expression error>" tschwinge at gcc dot gnu.org
2023-11-27 9:53 ` [Bug c++/112724] " tschwinge at gcc dot gnu.org
@ 2023-11-27 10:01 ` rguenth at gcc dot gnu.org
2024-03-22 9:26 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-11-27 10:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112724
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2023-11-27
Ever confirmed|0 |1
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug c++/112724] C++ "'excess_precision_expr' not supported by dump_expr<expression error>"
2023-11-27 9:52 [Bug c++/112724] New: C++ "'excess_precision_expr' not supported by dump_expr<expression error>" tschwinge at gcc dot gnu.org
2023-11-27 9:53 ` [Bug c++/112724] " tschwinge at gcc dot gnu.org
2023-11-27 10:01 ` rguenth at gcc dot gnu.org
@ 2024-03-22 9:26 ` cvs-commit at gcc dot gnu.org
2024-03-26 9:04 ` cvs-commit at gcc dot gnu.org
2024-03-26 9:11 ` jakub at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-03-22 9:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112724
--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:ca27c3b3a09fa051c0112769ba680e43b197aa97
commit r14-9614-gca27c3b3a09fa051c0112769ba680e43b197aa97
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Mar 22 10:20:11 2024 +0100
testsuite: Fix up depobj-3.c test on i686-linux [PR112724]
While I've posted a patch to handle EXCESS_PRECISION_EXPR in C/C++
pretty printing, still we'd need to handle
(a + (float)5)
and
(float)(((long double)a) + (long double)5)
and possibly
(float)(((double)a) + (double)5)
too for s390?, so the following patch just uses -fexcess-precision=fast,
so that the expression is always the same.
2024-03-22 Jakub Jelinek <jakub@redhat.com>
PR c++/112724
* c-c++-common/gomp/depobj-3.c: Add -fexcess-precision=fast as
dg-additional-options.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug c++/112724] C++ "'excess_precision_expr' not supported by dump_expr<expression error>"
2023-11-27 9:52 [Bug c++/112724] New: C++ "'excess_precision_expr' not supported by dump_expr<expression error>" tschwinge at gcc dot gnu.org
` (2 preceding siblings ...)
2024-03-22 9:26 ` cvs-commit at gcc dot gnu.org
@ 2024-03-26 9:04 ` cvs-commit at gcc dot gnu.org
2024-03-26 9:11 ` jakub at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-03-26 9:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112724
--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:10accfde57951db9f726e996f1b0be165df00f5c
commit r14-9663-g10accfde57951db9f726e996f1b0be165df00f5c
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Mar 26 10:03:27 2024 +0100
c-family, c++: Handle EXCESS_PRECISION_EXPR in pretty printers [PR112724]
I've noticed that the c-c++-common/gomp/depobj-3.c test FAILs on
i686-linux:
PASS: c-c++-common/gomp/depobj-3.c -std=c++17 at line 17 (test for
warnings, line 15)
FAIL: c-c++-common/gomp/depobj-3.c -std=c++17 at line 39 (test for
warnings, line 37)
PASS: c-c++-common/gomp/depobj-3.c -std=c++17 at line 43 (test for
errors, line 41)
PASS: c-c++-common/gomp/depobj-3.c -std=c++17 (test for warnings, line
45)
FAIL: c-c++-common/gomp/depobj-3.c -std=c++17 (test for excess errors)
Excess errors:
/home/jakub/src/gcc/gcc/testsuite/c-c++-common/gomp/depobj-3.c:37:38:
warning: the 'destroy' expression ''excess_precision_expr' not supported by
dump_expr<expression error>' should
+be the same as the 'depobj' argument 'obj' [-Wopenmp]
The following patch replaces that 'excess_precision_expr' not supported by
dump_expr<expression error>
with (float)(((long double)a) + (long double)5)
Still ugly and doesn't actually fix the FAIL (will deal with that
incrementally), but at least valid C/C++ and shows the excess precision
handling in action.
2024-03-26 Jakub Jelinek <jakub@redhat.com>
PR c++/112724
gcc/c-family/
* c-pretty-print.cc (pp_c_cast_expression,
c_pretty_printer::expression): Handle EXCESS_PRECISION_EXPR like
NOP_EXPR.
gcc/cp/
* error.cc (dump_expr): Handle EXCESS_PRECISION_EXPR like NOP_EXPR.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug c++/112724] C++ "'excess_precision_expr' not supported by dump_expr<expression error>"
2023-11-27 9:52 [Bug c++/112724] New: C++ "'excess_precision_expr' not supported by dump_expr<expression error>" tschwinge at gcc dot gnu.org
` (3 preceding siblings ...)
2024-03-26 9:04 ` cvs-commit at gcc dot gnu.org
@ 2024-03-26 9:11 ` jakub at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-03-26 9:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112724
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-26 9:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-27 9:52 [Bug c++/112724] New: C++ "'excess_precision_expr' not supported by dump_expr<expression error>" tschwinge at gcc dot gnu.org
2023-11-27 9:53 ` [Bug c++/112724] " tschwinge at gcc dot gnu.org
2023-11-27 10:01 ` rguenth at gcc dot gnu.org
2024-03-22 9:26 ` cvs-commit at gcc dot gnu.org
2024-03-26 9:04 ` cvs-commit at gcc dot gnu.org
2024-03-26 9:11 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).